From patchwork Sat Dec 2 17:01:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843904 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GyloptcT"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ypy8V6kllz9sNd for ; Sun, 3 Dec 2017 04:01:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbdLBRBO (ORCPT ); Sat, 2 Dec 2017 12:01:14 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:41200 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdLBRBN (ORCPT ); Sat, 2 Dec 2017 12:01:13 -0500 Received: by mail-pl0-f66.google.com with SMTP id g2so8032460pli.8; Sat, 02 Dec 2017 09:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=8K4KxeWeenLq5438mX43MD8ijxQUZKt2DFPv+jkiX/o=; b=GyloptcTp4ZwpBqFLFe+rUGJd4ME+lP540t3BSxt6npcHCxMQTNvxOEtXhFAa5R2Uj 4unBWZSe89E/4l310olJ66U18weyymoKMfHOnzAndBYlwK5+6h8bAOY8MtUSlbEcZJTF +6ZpJirvi8jQR0Q33LV8WNnsQxmlJ0HOHia8eB3+SV3PVdhK2cPITB4t4uhjsUO+slLl Y9gjVbXo8QrfcWa4c2nuKnqov3hZ2QctLKu+UBpe6i4Eo+slejC4BGOR8ZKhoCvvuo20 bfcPXy/z6gQJbTSpid6MTqqlMTJ20vqaGOfif4zM5H/wJHqcJtzo1oIYKA0ZiBZIQcBD OSKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8K4KxeWeenLq5438mX43MD8ijxQUZKt2DFPv+jkiX/o=; b=jC/B/EYdvDn0CPpnnsPckixJQNZpu3JdCWPuvNcG6qSV/p+COfxUGLFaD6HCxZouWr geehFM65nd6qA5+LAcapGPNsE/KEG7t1OzNl+pB6+26K/bcvymeMFbPSqJzSvIfBXlvq J+hAfDy3cwSB0+eVxeLzIX5XSUOIQyFJt7ylbmQiokTtAbX1CVUsMUtTw702yCpx8bHV eIXE7GvFwX66MTTd/v2BNvEuc7B3xlM0+ociSILg35Gf++J8jqlIy9wAvVI678SMSWD/ axQToXCjEVvsLCxZmcm4CHSc9Zs1+HXtDaMsJu5YqB4j3Pvh3GutrOj2zMu2j7wgLrZR TKAQ== X-Gm-Message-State: AJaThX5+MUM8TvvizIAVJ9nhZ2+qOg6jjECmv6SK4d/pnRb4APKpe447 +kFGrr4dHVxma7kgrcdOduQ= X-Google-Smtp-Source: AGs4zMZVkDNhMjY/H4EKfab5q5MbofeWP3+F22QhAkClvpxur2ugjPloQl+DE6Awq/B7gdme/5lB3Q== X-Received: by 10.159.230.13 with SMTP id u13mr9251697plq.293.1512234072858; Sat, 02 Dec 2017 09:01:12 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id x4sm16528911pfb.13.2017.12.02.09.01.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 09:01:11 -0800 (PST) From: Arvind Yadav To: linus.walleij@linaro.org Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking Date: Sat, 2 Dec 2017 22:31:01 +0530 Message-Id: <5abcacf8ee7ecb1e084f93c82cae1768e99fd4e6.1512233762.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: It's should be 'irq <= 0' instead of 'irq < 0'. drivers/gpio/gpio-ftgpio010.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c index 139f73d..fbb12f6 100644 --- a/drivers/gpio/gpio-ftgpio010.c +++ b/drivers/gpio/gpio-ftgpio010.c @@ -176,8 +176,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev) return PTR_ERR(g->base); irq = platform_get_irq(pdev, 0); - if (!irq) - return -EINVAL; + if (irq <= 0) + return irq ? irq : -EINVAL; ret = bgpio_init(&g->gc, dev, 4, g->base + GPIO_DATA_IN,