From patchwork Fri Dec 1 23:26:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Yeryomin X-Patchwork-Id: 843811 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ajamLFEF"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ypVnK0ZHyz9sMN for ; Sat, 2 Dec 2017 10:28:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:Date:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6bX/pIGkuio7NcbElzZNuLQsJx/ALAszRvgdhZVHR3o=; b=ajamLFEFxCFxhS m9yk4e25cAUzKcRBiQS9eIuzBAjzZJIeTdBhwO47gWZnWDKmGi/2sNPPttG+iPLs8MrCwnK9V6xMo uYSwBDshtNxni7bgTV7aiJSrnbeqhbOznNWkFjuYboA998aawfvgBdtezQLKUO8oL200iVOzvK8XP eXIr+/h7r1vfnD8zI8qFUKrid7XEaua60IHxiNDD7yMm1z/GzGq9rodMBFd/txvepLDwqMPBgrXpq QbeEbhg2Ls7Wcbopd3liapLmZFH8NEDizc3NPw/fjrFLZmRGSnHOfORXROHTLWlkTS4XKCGJAaQyX RhZxDzPh4y5Z9/N9TvnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eKuin-0001Qm-BF; Fri, 01 Dec 2017 23:27:53 +0000 Received: from [213.175.92.62] (helo=mail.pbx.lv) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eKuij-0001PR-7B for lede-dev@lists.infradead.org; Fri, 01 Dec 2017 23:27:51 +0000 Received: from localhost.localdomain (unknown [213.175.92.61]) by mail.pbx.lv (MailSystem) with ESMTPSA id 832A519E425 for ; Sat, 2 Dec 2017 01:27:21 +0200 (EET) From: Roman Yeryomin To: LEDE Development List Date: Sat, 2 Dec 2017 01:26:48 +0200 Message-Id: <20171201232648.4670-1-roman@advem.lv> X-Mailer: git-send-email 2.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171201_152749_455807_EB98E45A X-CRM114-Status: UNSURE ( 4.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.1 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Subject: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Moving a file between tmpfs and other fs is neither faster nor safer, thus no point in doing it in two steps. Signed-off-by: Roman Yeryomin --- package/base-files/files/lib/functions/uci-defaults.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/base-files/files/lib/functions/uci-defaults.sh b/package/base-files/files/lib/functions/uci-defaults.sh index 0cd519a147..8eab5ac1e1 100755 --- a/package/base-files/files/lib/functions/uci-defaults.sh +++ b/package/base-files/files/lib/functions/uci-defaults.sh @@ -633,6 +633,5 @@ board_config_update() { } board_config_flush() { - json_dump -i > /tmp/.board.json - mv /tmp/.board.json ${CFG} + json_dump -i > ${CFG} }