From patchwork Mon Feb 10 18:31:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikle Lappo X-Patchwork-Id: 1235959 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=jHqRjhgD; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48GbGL2r5wz9sPJ for ; Tue, 11 Feb 2020 06:15:38 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB0E780227; Mon, 10 Feb 2020 20:15:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jHqRjhgD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 17A9E80221; Mon, 10 Feb 2020 19:31:52 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F99F80221 for ; Mon, 10 Feb 2020 19:31:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miklelappo@gmail.com Received: by mail-il1-x143.google.com with SMTP id b15so1107723iln.3 for ; Mon, 10 Feb 2020 10:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=by+Fl7uy9Cn8hB+R+AwWpZVhBiTQH/VDHhXvSMnI9II=; b=jHqRjhgDBSOx0l2WDVUokn9Y4T/3WiIoIjKhA7CdNDXaBrvQkfmSjOnW/i+g1yaDCj YLevsF7+SBK68TnR7oefkzowozorDBfT8TYj0S2PlSwDcLGyYv+7CW6SOFuAQdhjJPJr Wlp/pUPadl1qc00l68CarCtBxfGBL5GXW6aSr/n7FuKPQW1HluIjT4LLV8T2vtddKtdx HhB7g8Goz+TBkXR5hhPHM4H40pkr3+m9kJPZTA4MMD0TUWSUmqsCRj+QMt9euvCZERHt +Aga27UXhmJOtaF63YnAB3hsh4g4uS7T3QpmQ5x8Hy0TpT4BwHmd6qDyJ4jJNdaTprFd ehcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=by+Fl7uy9Cn8hB+R+AwWpZVhBiTQH/VDHhXvSMnI9II=; b=im6LnqflDNd5ui+9oLUyLVh67EE3HPXiATcdD3lMx0qRHIYlJI4UrOykVsLh0hDKqO fszssvdzwwTI3HH/C5W/t0x3+N0XZQ+qlsNZJdVBKnhBqkmEZcJt4yOHjJLwE6D4MhQ0 DtHJw5t6RmvCCUzHTcakFqbW2wfD6CQGKMdoz9ngmjm+1BVX3v0qlErfDqz4syjjDAyh nO0eoD+0z9xw98Nd95YwZILFCsEbKf1fW5nUp4dddBE9cQGflu+P4DwhUh1eNNyuzS9R eXpz7J1/6X1dx/FPg2U+QOSd5TwcHwCRs6IFwVIJG59a8MfveYcp1UDzcYO82HMxX6U5 gzIA== X-Gm-Message-State: APjAAAUo69cFdDUVJqrG+HfdbHJtaAbrY1k6KsAfE/jSUgZMZGOiVrus zwMdw7aBw3lNXzz8pkBNk6WylwxFSilKPkLOD65lBHuThqI= X-Google-Smtp-Source: APXvYqwMQzScjfNLu8hNRqSCQa3cA3CNPguGD9R7OrZKA8rU2pG/n0B/Gs+u0bg6kSTcJXcIU1OYBxe120tPGqsDM9o= X-Received: by 2002:a92:c886:: with SMTP id w6mr2556468ilo.219.1581359507558; Mon, 10 Feb 2020 10:31:47 -0800 (PST) MIME-Version: 1.0 From: Mikle Lappo Date: Mon, 10 Feb 2020 19:31:11 +0100 Message-ID: Subject: [PATCH] eth: Fix crash while enabling fixed-phy To: u-boot@lists.denx.de X-Mailman-Approved-At: Mon, 10 Feb 2020 20:15:30 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.1 at phobos.denx.de X-Virus-Status: Clean From db35a238c5ae530e82d6de4cab180d570a3d8fc9 Mon Sep 17 00:00:00 2001 From: Mikhail Lappo Date: Fri, 7 Feb 2020 14:13:25 +0100 Subject: [PATCH] eth: Fix crash while enabling fixed-phy Fixed phy is always enabled and doesn't implement writeext function Signed-off-by: Mikhail Lappo CC: Marek Vasut --- drivers/net/ravb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c index fb4a628d63..46e02ed14c 100644 --- a/drivers/net/ravb.c +++ b/drivers/net/ravb.c @@ -434,7 +434,8 @@ static int ravb_config(struct udevice *dev) writel(mask, eth->iobase + RAVB_REG_ECMR); - phy->drv->writeext(phy, -1, 0x02, 0x08, (0x0f << 5) | 0x19); + if (phy->drv->writeext) + phy->drv->writeext(phy, -1, 0x02, 0x08, (0x0f << 5) | 0x19); return 0; }