From patchwork Sat Feb 8 16:21:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 1235330 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-519176-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=qbupIZMS; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=JrRJRi9U; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48FHVY4cHGz9sRQ for ; Sun, 9 Feb 2020 03:21:40 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=vsFMsQ/18cGZSzIQjxte5nKh4tV89QQORb7HzU1CsEFdiuwByA bK9B34AmbnA45FDwpvCQh+MuY5PM0NaWwAwNbitaFHtCWXz2mNGyUd5gMNk63orl Sp2maT/KPc6OkJGZnegfUHPpgzp12qJtRP25FmHtixbpnLi3ltbaGziIY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=NIOipgbOBm0uz/tcLN0ut/DmQKs=; b=qbupIZMS6v2iDTIPNXaV f22UjPufOqNixRhYvBq0dWbltaTkhAa0Bw+lRsBgvYeabXE6DT9iVAaIvvIF/YwQ 6hrcQtrnk4jd+rPTZRY0d3gM7ikaa3ESIZZ4i+6Ya2qJnPYMw72r9GV+gloGSiFL ytxnKpV3c2Spd8QUh1XA0vM= Received: (qmail 64418 invoked by alias); 8 Feb 2020 16:21:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 64405 invoked by uid 89); 8 Feb 2020 16:21:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS autolearn=ham version=3.3.1 spammy=Canadian, canadian, crossed, HX-Envelope-From:prvs X-HELO: esa1.hgst.iphmx.com Received: from esa1.hgst.iphmx.com (HELO esa1.hgst.iphmx.com) (68.232.141.245) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Feb 2020 16:21:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1581178880; x=1612714880; h=date:from:to:cc:subject:message-id:mime-version; bh=x2Y2BeUOdls+7vvSxzQVi4I8PF2YkUBv7wgE6m77b20=; b=JrRJRi9U2Mwf3wVAFrZUahhsufycuXMOzBCTncFbLbBsMoxbIiCPqrVw ouMipouxmTrakPN9gPjfLWEjLln2Qr/kVoM7Yb+UMBytGjZRRa/3S6i1B 03rPqZ5ilfb9DwRpwbcBUuL3LpsZ1+oV7gHFROBLmq8FKSbHVaR3iLSLr U9oxo2PzPUWg1AabheWfbFAqFjx9XGiHJjklLin9WSiuwbp1MBDs/R3ND /UTfDj/g/VBqUX/G40a7Vhz3wksbRA81r1EXR24YmBnk6uMO/e/6MYHAJ JNdy1NQaCUSnC9Fdhi8a1vjOBmqeJ2Vhh/Qo+J5QAW21TBl4kYZ7VLJQw w==; IronPort-SDR: unLtw1v1A1RQoRwAlaMVyDe0UK4igBWeRkJtBmoLslE2oba6v/pttufAK2n6n42VWpTDIMl0DS bMQOlNsb54C0g7Mj393YWjRQxjgyFc187KcVdMvvi4ben+Jbh/oUVTbRayy/8KeJUp9GusH0gg 199YI2KScqTyUoBPFdxH3H3UpU6suAY/l1HqsQePOO8NNLsImQ9tLAn8ygdkcp9B7xH15kvw8L 6zHOnG/gnRh8umJiltUQn8OtS4sqB7ki1/qIjlWcHl+rosEO92zhEhOSFG9zcFLFg5epOabhAf c1s= Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 09 Feb 2020 00:21:18 +0800 IronPort-SDR: ih0pGzwyQSlP2CjVYJFBdwjJ23BL/mYfAfUc4B8JTM/fufsvk3Mn1k5a18OrmaCSqR2/7WhFqI XC4xzcuPo6UBbzrc7QN2s6Foq79dsM9yXd4N5DNO2HVN3gqXT3gN0yzPEt7gFIloqM82M8/iLg UKVwsMssZvmJbAuRt6xV6toEy4ZI+QqknX0l8RFC2VBJBW5Sj6toizm1vwQZninIsd+LvZcTQ7 HOyz28N6hO0yoSLH1ta804HR8K6/hVZUNvplKbWEL1UiNqUNh/CyfW3K9sibcST0g9HjpqdxMl 4cNYTSXkBVaM+7QeBwNOFamj Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2020 08:14:14 -0800 IronPort-SDR: ExyP020YsChlrVeABqL92bpSCpdaw+o5xoxfc+orAZTCdNTxlbKJp9c4Mf4IXomFE/l9ATk02H o908yqsQ/jygOLNbgeVjfrSEcjGO8qpNbecjt45i0Llj9G0LVuUbq3RFAKxPdwptIvovTufKR0 15lv7+YiYq2jvHsCzm/CuKzIIC72lAB7DvI1vdOMHajQy8tir7lcRrI0rVzyHOLtYoovmLIUxU O8muWKXvbQ15fhxXhAiZHv/ex/6EoZtFfWKqAtl026GXKg8K3AUUjk17/t9wx+IXhWukXpliHi CQE= WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2020 08:21:17 -0800 Date: Sat, 8 Feb 2020 16:21:12 +0000 (GMT) From: "Maciej W. Rozycki" To: gcc-patches@gcc.gnu.org cc: Tom Tromey , gdb-patches@sourceware.org, binutils@sourceware.org Subject: [PATCH] configure: Re-disable building cross-gdbserver Message-ID: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Correct fallout from commit 919adfe84092 ("Move gdbserver to top level") and revert to not building `gdbserver' in a cross-configuration, that is where host != target, matching the documented behaviour. We have no way to support non-native `gdbserver', and native `gdbserver' is usually of no use with cross-GDB of the chosen host. * configure.ac: Do not build `gdbserver' if $is_cross_compiler. * configure: Regenerate. --- Hi, Verified with a native build, a crossed build of a native configuration and a build of a cross-debugger; Canadian Cross not checked. OK to apply? NB I have noticed that the gdbserver(1) man page is still being built and installed (as ${target_alias}-gdbserver.1, if building a cross-debugger), even if `gdbserver' itself is not (and it is not built if only `gdbserver' is while GDB is not). Obviously this is due to the man page still living under gdb/doc/, and I presume it will be addressed sometime soon, by moving the man page somewhere under gdbserver/, right? Also there are currently a number of mismatches in configure.ac between the gcc and the binutils-gdb repositories; what is the plan to eliminate them? Maciej --- configure | 5 +++-- configure.ac | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) gdbserver-no-cross.diff Index: binutils-gdb/configure =================================================================== --- binutils-gdb.orig/configure +++ binutils-gdb/configure @@ -3538,12 +3538,13 @@ case "${target}" in ;; esac -# Only allow gdbserver on some systems. +# Only allow native gdbserver and then only on some systems. if test -d ${srcdir}/gdbserver; then if test x$enable_gdbserver = x; then { $as_echo "$as_me:${as_lineno-$LINENO}: checking for gdbserver support" >&5 $as_echo_n "checking for gdbserver support... " >&6; } - if (srcdir=${srcdir}/gdbserver; \ + if test x${is_cross_compiler} = xyes \ + || (srcdir=${srcdir}/gdbserver; \ . ${srcdir}/configure.srv; \ test -n "$UNSUPPORTED") then Index: binutils-gdb/configure.ac =================================================================== --- binutils-gdb.orig/configure.ac +++ binutils-gdb/configure.ac @@ -782,11 +782,12 @@ case "${target}" in ;; esac -# Only allow gdbserver on some systems. +# Only allow native gdbserver and then only on some systems. if test -d ${srcdir}/gdbserver; then if test x$enable_gdbserver = x; then AC_MSG_CHECKING([for gdbserver support]) - if (srcdir=${srcdir}/gdbserver; \ + if test x${is_cross_compiler} = xyes \ + || (srcdir=${srcdir}/gdbserver; \ . ${srcdir}/configure.srv; \ test -n "$UNSUPPORTED") then