From patchwork Wed Jan 22 15:01:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfgang Wallner X-Patchwork-Id: 1227316 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=br-automation.com Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 482pYc6VTkz9sPn for ; Thu, 23 Jan 2020 02:03:00 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E8B00818C8; Wed, 22 Jan 2020 16:02:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 9A235817BE; Wed, 22 Jan 2020 16:02:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail2.br-automation.com (mail2.br-automation.com [213.33.116.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A8ED2817B0 for ; Wed, 22 Jan 2020 16:01:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wolfgang.wallner@br-automation.com X-AuditID: c0a80110-935ff70000001e72-c9-5e2863e1767d Received: from brsmtp01.br-automation.co.at (Unknown_Domain [192.168.1.60]) by mail2.br-automation.com () with SMTP id F7.B5.07794.1E3682E5; Wed, 22 Jan 2020 16:01:53 +0100 (CET) From: "Wolfgang Wallner" To: u-boot@lists.denx.de,"Simon Glass" ,"Bin Meng" Subject: [RFC PATCH 1/4] x86: apl: Add the term "Interrupt Timer Subsystem" to ITSS files Date: Wed, 22 Jan 2020 16:01:44 +0100 Message-Id: <20200122150147.25709-2-wolfgang.wallner@br-automation.com> In-Reply-To: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> X-Mailer: git-send-email 2.25.0 References: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Serialize by Router on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Itemize by SMTP Server on BRSMTP01/Eggelsberg/AT/B&R(Release 10.0.1FP3|August 09, 2019) at 01/22/2020 04:01:52 PM X-TNEFEvaluated: 1 X-Disclaimed: 56687 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsVyYAWjje7DZI04g+4ZqhZTe+Itvm3Zxmjx dm8nuwOzx+yGiyweO2fdZfc4e2cHYwBzFJdNSmpOZllqkb5dAlfGow//GQuucVVcXhTewPiF o4uRg0NCwETi0w3DLkZODiGBLYwSC786gthsArYSjUe2soHYIgLREs/aOhhBbGYBa4mpq94x g9jCApESD1atZwKxWQRUJY52XQWr5xVwl3i15geYzSngIXFn5U02iF5tiWULX4P1SgjIS8xu PM0Gsddd4m3DfFaIXkGJkzOfsHQxcgHV3GeSmLduESNEg5DE6cVnoZqFJW61TGKfwCgwC8nc WUj6FzAyrWIUz03MzDHSSyrSTSwtyc9NLMnMz9NLzs/dxAgJSIEdjLvfaB9iZOJgPMQowcGs JMK7oEk1Tog3JbGyKrUoP76oNCe1+BCjNAeLkjjvdclPsUIC6YklqdmpqQWpRTBZJg5OqQZG XkP5rti+zPuCAcpBER9e88dE+6lWyut0brI+4zLV2P5dtNlKrwyWNSzu+lcmWa3yNNlzrNVC avX7/Qdv73d5zlESuDzjbO32oq1mbZz6vl78YflyLR7ucQ/NGBwKv5hVOCdZrswx6JVs0Rbd XbVgU8yshW4CKQ/ZbESs0gtNTkpd31X+VomlOCPRUIu5qDgRABHNHQQ2AgAA X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean ITSS stands for "Interrupt Timer Subsystem", so add that term to the description of the relevant files. Signed-off-by: Wolfgang Wallner Reviewed-by: Simon Glass Reviewed-by: Bin Meng --- ITSS stands for "Interrupt Timer Subsystem", at least according to coreboot [1]. [1] https://coreboot.org/status/kconfig-options.html arch/x86/cpu/apollolake/itss.c | 2 +- arch/x86/include/asm/arch-apollolake/itss.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/cpu/apollolake/itss.c b/arch/x86/cpu/apollolake/itss.c index 8789f8e6bb..95c9ebddc1 100644 --- a/arch/x86/cpu/apollolake/itss.c +++ b/arch/x86/cpu/apollolake/itss.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Something to do with Interrupts, but I don't know what ITSS stands for + * Interrupt Timer Subsystem * * Copyright (C) 2017 Intel Corporation. * Copyright (C) 2017 Siemens AG diff --git a/arch/x86/include/asm/arch-apollolake/itss.h b/arch/x86/include/asm/arch-apollolake/itss.h index 1e29503974..c75d8fe8c2 100644 --- a/arch/x86/include/asm/arch-apollolake/itss.h +++ b/arch/x86/include/asm/arch-apollolake/itss.h @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* + * Interrupt Timer Subsystem + * * Copyright (C) 2017 Intel Corporation. * Copyright 2019 Google LLC * From patchwork Wed Jan 22 15:01:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfgang Wallner X-Patchwork-Id: 1227313 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=br-automation.com Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 482pXw3ygqz9sPn for ; Thu, 23 Jan 2020 02:02:24 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C96538179C; Wed, 22 Jan 2020 16:02:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CE7C4817AC; Wed, 22 Jan 2020 16:01:57 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail2.br-automation.com (mail2.br-automation.com [213.33.116.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 47BA68179E for ; Wed, 22 Jan 2020 16:01:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wolfgang.wallner@br-automation.com X-AuditID: c0a80110-91fff70000001e72-ca-5e2863e1871c Received: from brsmtp01.br-automation.co.at (Unknown_Domain [192.168.1.60]) by mail2.br-automation.com () with SMTP id 38.B5.07794.1E3682E5; Wed, 22 Jan 2020 16:01:53 +0100 (CET) From: "Wolfgang Wallner" To: u-boot@lists.denx.de,"Simon Glass" ,"Bin Meng" Subject: [RFC PATCH 2/4] x86: Move itss.h from Apollo Lake to the generic x86 include directory Date: Wed, 22 Jan 2020 16:01:45 +0100 Message-Id: <20200122150147.25709-3-wolfgang.wallner@br-automation.com> In-Reply-To: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> X-Mailer: git-send-email 2.25.0 References: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Serialize by Router on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Itemize by SMTP Server on BRSMTP01/Eggelsberg/AT/B&R(Release 10.0.1FP3|August 09, 2019) at 01/22/2020 04:01:52 PM X-TNEFEvaluated: 1 X-Disclaimed: 12991 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGLMWRmVeSWpSXmKPExsVyYAWjje7DZI04gzsvtC2m9sRbfNuyjdHi 7d5Odgdmj9kNF1k8ds66y+5x9s4OxgDmKC6blNSczLLUIn27BK6M280t7AX/eCquXJjI2MD4 g6uLkZNDQsBEYvH1pcxdjFwcQgJbGCUOH13FApJgE7CVaDyylQ3EFhGIlnjW1sEIYjMLWEtM XfWOGcQWFoiXON/0ignEZhFQlTg04QpYPa+Au8SDc5fA5nAKeEjcWXmTDaJXW2LZwtfMEIvl JWY3ngaLCwHVv22YzwrRKyhxcuYTFpCDJATuM0nMW7eIEaJBSOL04rNQzcISe/quskxgFJiF ZO4sJP0LGJlWMYrnJmbmGOklFekmlpbk5yaWZObn6SXn525ihISlwA7G3W+0DzEycTAeYpTg YFYS4V3QpBonxJuSWFmVWpQfX1Sak1p8iFGag0VJnPe65KdYIYH0xJLU7NTUgtQimCwTB6dU AyN/pHb/bIYfE9LS7nnd2jTpcx07w//I/B87Kz62Caewz7txMunMl1jvR+l7k8or//Dtybl1 t5zZjiX3yKKJl9I3X+rYLX0z2NiQd3m2052PdaUM8vEtu7/c+fBnu/vPTWWPHvIc+jA/ycRP yUTu2roVkz/UtE02Wc0y4/F/lbBJa9sW705Ym79biaU4I9FQi7moOBEAnC20BDkCAAA= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean The code in this file is not specific to Apollo Lake. According to coreboot sources (where this code comes from), it is common to at least: * Apollo Lake * Cannon Lake * Ice Lake * Skylake Signed-off-by: Wolfgang Wallner Reviewed-by: Simon Glass Reviewed-by: Bin Meng --- arch/x86/cpu/apollolake/itss.c | 2 +- arch/x86/include/asm/{arch-apollolake => }/itss.h | 0 drivers/pinctrl/intel/pinctrl.c | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename arch/x86/include/asm/{arch-apollolake => }/itss.h (100%) diff --git a/arch/x86/cpu/apollolake/itss.c b/arch/x86/cpu/apollolake/itss.c index 95c9ebddc1..ff7a83d618 100644 --- a/arch/x86/cpu/apollolake/itss.c +++ b/arch/x86/cpu/apollolake/itss.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include struct apl_itss_platdata { #if CONFIG_IS_ENABLED(OF_PLATDATA) diff --git a/arch/x86/include/asm/arch-apollolake/itss.h b/arch/x86/include/asm/itss.h similarity index 100% rename from arch/x86/include/asm/arch-apollolake/itss.h rename to arch/x86/include/asm/itss.h diff --git a/drivers/pinctrl/intel/pinctrl.c b/drivers/pinctrl/intel/pinctrl.c index 4875a3b0b5..5bf5d8b0e2 100644 --- a/drivers/pinctrl/intel/pinctrl.c +++ b/drivers/pinctrl/intel/pinctrl.c @@ -25,7 +25,7 @@ #include #include #include -#include +#include #include #include From patchwork Wed Jan 22 15:01:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfgang Wallner X-Patchwork-Id: 1227314 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=br-automation.com Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 482pYC4Chbz9sPn for ; Thu, 23 Jan 2020 02:02:39 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B37E8194A; Wed, 22 Jan 2020 16:02:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 62D968179E; Wed, 22 Jan 2020 16:02:00 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail2.br-automation.com (mail2.br-automation.com [213.33.116.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DB90817A6 for ; Wed, 22 Jan 2020 16:01:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wolfgang.wallner@br-automation.com X-AuditID: c0a80110-935ff70000001e72-cb-5e2863e1c533 Received: from brsmtp01.br-automation.co.at (Unknown_Domain [192.168.1.60]) by mail2.br-automation.com () with SMTP id 78.B5.07794.1E3682E5; Wed, 22 Jan 2020 16:01:53 +0100 (CET) From: "Wolfgang Wallner" To: u-boot@lists.denx.de,"Simon Glass" ,"Bin Meng" Subject: [RFC PATCH 3/4] x86: Move itss.c from Apollo Lake to a more generic location Date: Wed, 22 Jan 2020 16:01:46 +0100 Message-Id: <20200122150147.25709-4-wolfgang.wallner@br-automation.com> In-Reply-To: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> X-Mailer: git-send-email 2.25.0 References: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Serialize by Router on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Itemize by SMTP Server on BRSMTP01/Eggelsberg/AT/B&R(Release 10.0.1FP3|August 09, 2019) at 01/22/2020 04:01:52 PM X-TNEFEvaluated: 1 X-Disclaimed: 45555 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrALMWRmVeSWpSXmKPExsVyYAWjje7DZI04g027jCym9sRbfLnRymrx bcs2Rou3ezvZHVg8ZjdcZPHYOesuu8fZOzsYPdY+2sASwBLFZZOSmpNZllqkb5fAlXF26SOm gtc8FR+uXWNsYLzH1cXIySEhYCJx7dMu5i5GLg4hgS2MEisuz2AGSbAJ2Eo0HtnKBmKLCERL PGvrYASxmQXKJTadvgQWFxYIlWiYsIsVxGYRUJVo3XeNHcTmFXCXWLx8LVgNp4CHxJ2VN9kg erUlli18zQyxWF5iduNpsLgQUP3bhvmsEL2CEidnPmEBOUhC4D6TxLx1ixghGoQkTi8+C9Us LPFrwyWWCYwCs5DMnYWkfwEj0ypG8dzEzBwjvaQi3cTSkvzcxJLM/Dy95PzcTYyQUBXYwbj7 jfYhRiYOxkOMEhzMSiK8C5pU44R4UxIrq1KL8uOLSnNSiw8xSnOwKInzXpf8FCskkJ5Ykpqd mlqQWgSTZeLglGpgzK38cPW1TEWd7A/nNX8f8320fbft6OuNszIPPvkxkfm/w+S6PQtMw79M lQ7j005i/hDzdKGwdryNCb/o3mkl/112XarIZbFWdai4wf82ipXt/ga1oi6eu/NOW+4SDTdJ OjRPNaY75/AC88o1Vx6vT+rorr6yUFRifpyBtLlGz6+L2StbvVkTlFiKMxINtZiLihMByDuE skMCAAA= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean The Interrupt Timer Subsystem (ITSS) is not specific to Apollo Lake, so move it to a common location within arch/x86. Signed-off-by: Wolfgang Wallner Reviewed-by: Simon Glass Reviewed-by: Bin Meng --- At the moment, this commit enables building of itss.o unconditionally. which is a bad idea I guess. What is the preferred way to handle this? Should I add a kconfig option e.g. in arch/x86/Kconfig? arch/x86/cpu/apollolake/Makefile | 1 - arch/x86/cpu/intel_common/Makefile | 1 + arch/x86/cpu/{apollolake => intel_common}/itss.c | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename arch/x86/cpu/{apollolake => intel_common}/itss.c (100%) diff --git a/arch/x86/cpu/apollolake/Makefile b/arch/x86/cpu/apollolake/Makefile index 1760df54d8..f99f2c6473 100644 --- a/arch/x86/cpu/apollolake/Makefile +++ b/arch/x86/cpu/apollolake/Makefile @@ -19,7 +19,6 @@ obj-y += fsp_s.o endif obj-y += hostbridge.o -obj-y += itss.o obj-y += lpc.o obj-y += p2sb.o obj-y += pch.o diff --git a/arch/x86/cpu/intel_common/Makefile b/arch/x86/cpu/intel_common/Makefile index cc4e1c962b..266e6e26fa 100644 --- a/arch/x86/cpu/intel_common/Makefile +++ b/arch/x86/cpu/intel_common/Makefile @@ -27,6 +27,7 @@ obj-y += microcode.o endif endif obj-y += pch.o +obj-y += itss.o ifdef CONFIG_SPL ifndef CONFIG_SPL_BUILD diff --git a/arch/x86/cpu/apollolake/itss.c b/arch/x86/cpu/intel_common/itss.c similarity index 100% rename from arch/x86/cpu/apollolake/itss.c rename to arch/x86/cpu/intel_common/itss.c From patchwork Wed Jan 22 15:01:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfgang Wallner X-Patchwork-Id: 1227315 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=br-automation.com Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 482pYP1sDnz9sPn for ; Thu, 23 Jan 2020 02:02:49 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 54E0E81953; Wed, 22 Jan 2020 16:02:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 6EB91817C0; Wed, 22 Jan 2020 16:02:04 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail2.br-automation.com (mail2.br-automation.com [213.33.116.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C4F8C817BD for ; Wed, 22 Jan 2020 16:01:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=br-automation.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wolfgang.wallner@br-automation.com X-AuditID: c0a80110-91fff70000001e72-cc-5e2863e10d22 Received: from brsmtp01.br-automation.co.at (Unknown_Domain [192.168.1.60]) by mail2.br-automation.com () with SMTP id C8.B5.07794.1E3682E5; Wed, 22 Jan 2020 16:01:54 +0100 (CET) From: "Wolfgang Wallner" To: u-boot@lists.denx.de,"Simon Glass" ,"Bin Meng" Subject: [RFC PATCH 4/4] x86: itss: Remove apl-prefix Date: Wed, 22 Jan 2020 16:01:47 +0100 Message-Id: <20200122150147.25709-5-wolfgang.wallner@br-automation.com> In-Reply-To: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> X-Mailer: git-send-email 2.25.0 References: <20200122150147.25709-1-wolfgang.wallner@br-automation.com> MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Serialize by Router on BRSMTPINTERN2/InternSMTP(Release 9.0.1FP5|November 22, 2015) at 22/01/2020 16:01:52, Itemize by SMTP Server on BRSMTP01/Eggelsberg/AT/B&R(Release 10.0.1FP3|August 09, 2019) at 01/22/2020 04:01:52 PM X-TNEFEvaluated: 1 X-Disclaimed: 23423 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKLMWRmVeSWpSXmKPExsVyYAWjje6jZI04gzP3mC2m9sRbfNuyjdHi 7d5Odgdmj9kNF1k8ds66y+5x9s4OxgDmKC6blNSczLLUIn27BK6Mjf82Mhf80K5YOOszSwPj QtUuRk4OCQETiV1dx1i7GLk4hAS2MEp0HTnECJJgE7CVaDyylQ3EFhGIlnjW1gEWZxawlpi6 6h0ziC0sYCpxvmsFUDMHB4uAqkTr00qQMK+Au8T53vNg5ZwCHhJ3Vt5kg2jVlli28DUzxF55 idmNp8HiQkD1bxvms0L0CkqcnPmEBeQeCYH7TBLz1i1ihGgQkji9+CxUs7DElI2PWCYwCsxC MncWkv4FjEyrGMVzEzNzjPSSinQTS0vycxNLMvPz9JLzczcxQoJSYAfj7jfahxiZOBgPMUpw MCuJ8C5oUo0T4k1JrKxKLcqPLyrNSS0+xCjNwaIkzntd8lOskEB6YklqdmpqQWoRTJaJg1Oq gVEnMqyyq2oif82ByWl+E/wmyFdesK9dpWB4QKtX11mvedX3M5u9C9l15v1YtyhM4WRu2uLg WwfvXX5cf2Pjxb/H/woVSPFIP/Zh8Jv2cXHrrb2a+a/F7KY+12m6zHjt2cNHv1Ztjqp/+a2p tfXbdW4NwRbud2eV75X5yUt4RttM/t67wSQw5K0SS3FGoqEWc1FxIgDId46COAIAAA== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean The Interrupt Timer Subsystem (ITSS) is not specific to Apollo Lake, so remove the apl-prefix of the implemented functions/structures/... Signed-off-by: Wolfgang Wallner Reviewed-by: Simon Glass Reviewed-by: Bin Meng --- arch/x86/cpu/intel_common/itss.c | 56 +++++++++++++++---------------- arch/x86/dts/chromebook_coral.dts | 2 +- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/arch/x86/cpu/intel_common/itss.c b/arch/x86/cpu/intel_common/itss.c index ff7a83d618..9df51adecc 100644 --- a/arch/x86/cpu/intel_common/itss.c +++ b/arch/x86/cpu/intel_common/itss.c @@ -17,10 +17,10 @@ #include #include -struct apl_itss_platdata { +struct itss_platdata { #if CONFIG_IS_ENABLED(OF_PLATDATA) /* Put this first since driver model will copy the data here */ - struct dtd_intel_apl_itss dtplat; + struct dtd_intel_itss dtplat; #endif }; @@ -30,13 +30,13 @@ struct pmc_route { u32 gpio; }; -struct apl_itss_priv { +struct itss_priv { struct pmc_route *route; uint route_count; u32 irq_snapshot[NUM_IPC_REGS]; }; -static int apl_set_polarity(struct udevice *dev, uint irq, bool active_low) +static int set_polarity(struct udevice *dev, uint irq, bool active_low) { u32 mask; uint reg; @@ -53,9 +53,9 @@ static int apl_set_polarity(struct udevice *dev, uint irq, bool active_low) } #ifndef CONFIG_TPL_BUILD -static int apl_snapshot_polarities(struct udevice *dev) +static int snapshot_polarities(struct udevice *dev) { - struct apl_itss_priv *priv = dev_get_priv(dev); + struct itss_priv *priv = dev_get_priv(dev); const int start = GPIO_IRQ_START; const int end = GPIO_IRQ_END; int reg_start; @@ -86,9 +86,9 @@ static void show_polarities(struct udevice *dev, const char *msg) } } -static int apl_restore_polarities(struct udevice *dev) +static int restore_polarities(struct udevice *dev) { - struct apl_itss_priv *priv = dev_get_priv(dev); + struct itss_priv *priv = dev_get_priv(dev); const int start = GPIO_IRQ_START; const int end = GPIO_IRQ_END; int reg_start; @@ -132,9 +132,9 @@ static int apl_restore_polarities(struct udevice *dev) } #endif -static int apl_route_pmc_gpio_gpe(struct udevice *dev, uint pmc_gpe_num) +static int route_pmc_gpio_gpe(struct udevice *dev, uint pmc_gpe_num) { - struct apl_itss_priv *priv = dev_get_priv(dev); + struct itss_priv *priv = dev_get_priv(dev); struct pmc_route *route; int i; @@ -146,14 +146,14 @@ static int apl_route_pmc_gpio_gpe(struct udevice *dev, uint pmc_gpe_num) return -ENOENT; } -static int apl_itss_ofdata_to_platdata(struct udevice *dev) +static int itss_ofdata_to_platdata(struct udevice *dev) { - struct apl_itss_priv *priv = dev_get_priv(dev); + struct itss_priv *priv = dev_get_priv(dev); int ret; #if CONFIG_IS_ENABLED(OF_PLATDATA) - struct apl_itss_platdata *plat = dev_get_platdata(dev); - struct dtd_intel_apl_itss *dtplat = &plat->dtplat; + struct itss_platdata *plat = dev_get_platdata(dev); + struct dtd_intel_itss *dtplat = &plat->dtplat; /* * It would be nice to do this in the bind() method, but with @@ -189,26 +189,26 @@ static int apl_itss_ofdata_to_platdata(struct udevice *dev) return 0; } -static const struct irq_ops apl_itss_ops = { - .route_pmc_gpio_gpe = apl_route_pmc_gpio_gpe, - .set_polarity = apl_set_polarity, +static const struct irq_ops itss_ops = { + .route_pmc_gpio_gpe = route_pmc_gpio_gpe, + .set_polarity = set_polarity, #ifndef CONFIG_TPL_BUILD - .snapshot_polarities = apl_snapshot_polarities, - .restore_polarities = apl_restore_polarities, + .snapshot_polarities = snapshot_polarities, + .restore_polarities = restore_polarities, #endif }; -static const struct udevice_id apl_itss_ids[] = { - { .compatible = "intel,apl-itss"}, +static const struct udevice_id itss_ids[] = { + { .compatible = "intel,itss"}, { } }; -U_BOOT_DRIVER(apl_itss_drv) = { - .name = "intel_apl_itss", +U_BOOT_DRIVER(itss_drv) = { + .name = "intel_itss", .id = UCLASS_IRQ, - .of_match = apl_itss_ids, - .ops = &apl_itss_ops, - .ofdata_to_platdata = apl_itss_ofdata_to_platdata, - .platdata_auto_alloc_size = sizeof(struct apl_itss_platdata), - .priv_auto_alloc_size = sizeof(struct apl_itss_priv), + .of_match = itss_ids, + .ops = &itss_ops, + .ofdata_to_platdata = itss_ofdata_to_platdata, + .platdata_auto_alloc_size = sizeof(struct itss_platdata), + .priv_auto_alloc_size = sizeof(struct itss_priv), }; diff --git a/arch/x86/dts/chromebook_coral.dts b/arch/x86/dts/chromebook_coral.dts index 24fcbb5063..a1820fa187 100644 --- a/arch/x86/dts/chromebook_coral.dts +++ b/arch/x86/dts/chromebook_coral.dts @@ -171,7 +171,7 @@ itss { u-boot,dm-pre-reloc; - compatible = "intel,apl-itss"; + compatible = "intel,itss"; intel,p2sb-port-id = ; intel,pmc-routes = < PMC_GPE_SW_31_0 GPIO_GPE_SW_31_0