From patchwork Mon Oct 21 21:06:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 1180883 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46xq1s1zDkz9sP4; Tue, 22 Oct 2019 08:06:24 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1iMese-0002ry-HA; Mon, 21 Oct 2019 21:06:20 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iMesc-0002ra-Lc for kernel-team@lists.ubuntu.com; Mon, 21 Oct 2019 21:06:18 +0000 Received: from mail-io1-f72.google.com ([209.85.166.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iMesc-0002PN-DS for kernel-team@lists.ubuntu.com; Mon, 21 Oct 2019 21:06:18 +0000 Received: by mail-io1-f72.google.com with SMTP id d11so3412863ioc.21 for ; Mon, 21 Oct 2019 14:06:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KIIdRWDpVMoTwnF7zRxrZZETBFBOc37bFlt3Fs18n90=; b=eqFkKxltscK/pl7HYHPw36adiB5tZNyvTinuumqhd60vW4URohz1l2+vO82eonow0W 0E5RVgxbCzM7SagxnHBZXUJsjPw79bn8lGJ+rec0rBhGq+H+9iAY3h1UA7qUc7MrKCWu yGCXhM5YAWo1ctLJqLKjS/hEI7HxzYFuEl8IuL1uNocMLk2GjWR+84PElc/qqIR9O9x5 dXJHhQccNGcDjcEqz5AsTwWDcsl8dr8k1VeY6Ow+HLzPEqdCu3ZasACwOb2BumnbDAUH Cyu1IgSuMQhpruFDFW9So0jXtf/dDpqmGruDuBR7WaPMtw+RIlAFYn13uyWwkLCs+M8+ w9dA== X-Gm-Message-State: APjAAAWKoSV0EwRXdPH5IrbMYB18WPtBp2GeZlmvjqgi8vaO5aokrkNs kxW7rdU8KC/Vx8kVM+5jBPZCesjd3Sb8ZnfjbmMvYpnTwCH0OmiybzOkL+MIJwHL5hCxVjrQJEi y3AaV4qvKrLQxbQt1WkQbZzCuhPeKn/E9ZWLl1yvJWg== X-Received: by 2002:a6b:9089:: with SMTP id s131mr227249iod.107.1571691977433; Mon, 21 Oct 2019 14:06:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzjV6y8hf6F/QiQ7Zwq9L4VHzQZbs8xOaGZ2C2YuSDkXj43bZQ9B5KcwUw1Sx4xNjyz4/t5QA== X-Received: by 2002:a6b:9089:: with SMTP id s131mr227218iod.107.1571691977123; Mon, 21 Oct 2019 14:06:17 -0700 (PDT) Received: from localhost ([2605:a601:ac3:9720:445f:c78a:4de3:957d]) by smtp.gmail.com with ESMTPSA id s90sm4581262ill.40.2019.10.21.14.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 14:06:16 -0700 (PDT) Date: Mon, 21 Oct 2019 16:06:15 -0500 From: Seth Forshee To: Hui Wang Subject: ACK/cmt: [SRU][EOAN/unstable][PATCH 0/1] alsa/sof: Enable SOF_HDA link and codec Message-ID: <20191021210615.GH3768@ubuntu-xps13> References: <20191017122850.23090-1-hui.wang@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191017122850.23090-1-hui.wang@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" On Thu, Oct 17, 2019 at 08:28:49PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1848490 > > So far, only OEM-B-OSP1, EOAN and later kernels have the alsa/sof driver, > and the OEM-B-OSP1 kernel already enabled these CONFIGs. > > [Impact] > We tested the EOAN kernel on the LENOVO or Dell machines which have > dmic directly connnected to PCH, the dmic didn't work. > > [Fix] > We need to enable SOF_HDA link and codec, then the sof driver > and Legacy HDA driver work together to make the dmic work. > > [Test Case] > Install the latest 19.10 image, build a new kernel with this > patch and replace the existing kernel, After installing the blacklist > package (blacklist snd_hda_intel and snd_soc_skl) and ucm package, > the dmic and all output devices (speaker/hdmi) work. > > [Regression Risk] > Low, these configs are already enabled in the oem-b-osp1 kernel > for a long time, and we tested it on many lenovo/dell machines witch > have or have no dmic, all worked well. I got an email separately regarding these config problems, this is a needed change. Acked-by: Seth Forshee The recommended configs we received from Intel's had additional changes, see the full diff below. It seems that with the SOF driver makes some options are now considered deprecated. I'll probably apply this change to unstable. Perhaps for eoan it's better to stick with the more conservative changes you sent -- what do you think? Thanks, Seth Acked-by: Kleber Sacilotto de Souza diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu index 555862498d8f..988767d260bc 100644 --- a/debian.master/config/config.common.ubuntu +++ b/debian.master/config/config.common.ubuntu @@ -9081,14 +9081,14 @@ CONFIG_SND_SOC_INTEL_BYT_CHT_CX2072X_MACH=m CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH=m CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH=m # CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH is not set -CONFIG_SND_SOC_INTEL_CFL=m +# CONFIG_SND_SOC_INTEL_CFL is not set CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH=m CONFIG_SND_SOC_INTEL_CHT_BSW_NAU8824_MACH=m CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH=m CONFIG_SND_SOC_INTEL_CHT_BSW_RT5672_MACH=m -CONFIG_SND_SOC_INTEL_CML_H=m -CONFIG_SND_SOC_INTEL_CML_LP=m -CONFIG_SND_SOC_INTEL_CNL=m +# CONFIG_SND_SOC_INTEL_CML_H is not set +# CONFIG_SND_SOC_INTEL_CML_LP is not set +# CONFIG_SND_SOC_INTEL_CNL is not set CONFIG_SND_SOC_INTEL_GLK=m CONFIG_SND_SOC_INTEL_GLK_RT5682_MAX98357A_MACH=m CONFIG_SND_SOC_INTEL_HASWELL=m @@ -9105,10 +9105,10 @@ CONFIG_SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH=m CONFIG_SND_SOC_INTEL_SKL_NAU88L25_MAX98357A_MACH=m CONFIG_SND_SOC_INTEL_SKL_NAU88L25_SSM4567_MACH=m CONFIG_SND_SOC_INTEL_SKL_RT286_MACH=m -CONFIG_SND_SOC_INTEL_SKYLAKE=m +# CONFIG_SND_SOC_INTEL_SKYLAKE is not set CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON=m CONFIG_SND_SOC_INTEL_SKYLAKE_FAMILY=m -CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=y +# CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC is not set CONFIG_SND_SOC_INTEL_SKYLAKE_SSP_CLK=m CONFIG_SND_SOC_INTEL_SOF_RT5682_MACH=m CONFIG_SND_SOC_INTEL_SST=m @@ -9248,7 +9248,10 @@ CONFIG_SND_SOC_SOF_COMETLAKE_LP_SUPPORT=y # CONFIG_SND_SOC_SOF_DEBUG is not set CONFIG_SND_SOC_SOF_GEMINILAKE=m CONFIG_SND_SOC_SOF_GEMINILAKE_SUPPORT=y +CONFIG_SND_SOC_SOF_HDA=m +CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC=y CONFIG_SND_SOC_SOF_HDA_COMMON=m +CONFIG_SND_SOC_SOF_HDA_LINK=y CONFIG_SND_SOC_SOF_HDA_LINK_BASELINE=m CONFIG_SND_SOC_SOF_ICELAKE=m CONFIG_SND_SOC_SOF_ICELAKE_SUPPORT=y @@ -9260,10 +9263,10 @@ CONFIG_SND_SOC_SOF_INTEL_PCI=m CONFIG_SND_SOC_SOF_INTEL_TOPLEVEL=y CONFIG_SND_SOC_SOF_MERRIFIELD=m CONFIG_SND_SOC_SOF_MERRIFIELD_SUPPORT=y -CONFIG_SND_SOC_SOF_NOCODEC=m -CONFIG_SND_SOC_SOF_NOCODEC_SUPPORT=y +# CONFIG_SND_SOC_SOF_NOCODEC_SUPPORT is not set CONFIG_SND_SOC_SOF_OPTIONS=m CONFIG_SND_SOC_SOF_PCI=m +CONFIG_SND_SOC_SOF_PROBE_WORK_QUEUE=y # CONFIG_SND_SOC_SOF_STRICT_ABI_CHECKS is not set CONFIG_SND_SOC_SOF_TOPLEVEL=y CONFIG_SND_SOC_SOF_XTENSA=m