From patchwork Mon Sep 30 07:20:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damijan Skvarc X-Patchwork-Id: 1169147 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ib+wF7Ka"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46hYj400pjz9sPG for ; Mon, 30 Sep 2019 17:20:55 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id C45631472; Mon, 30 Sep 2019 07:20:52 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 24B07146D for ; Mon, 30 Sep 2019 07:20:52 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 10C723D0 for ; Mon, 30 Sep 2019 07:20:50 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id 5so12089220wmg.0 for ; Mon, 30 Sep 2019 00:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=eERYF/JBRHI0w7h5eYoG+wIoaEW9wjmxzZLT70Umql0=; b=ib+wF7Ka4/RIJWnhCOn2PeeFrPZTidQwUqlom/Dam94vd2B5nU+nsNmc6Vw2h/BVaG IefSzXyo53pOxcjV/Lj2lJ+Uef/1evdwHdcM2wSjiS/G2kdPujkrovEoTLqhDhYwuizb hc3F4XCiry8Rcw8qq+8zwo9EEaWHPCvLmfsBoaR4X4pZb1SKHrnJ43STQ/JCQNEBGk57 1oRDN38Dc40pGQ7zhJF1mLBhRZaIIGqp6xarqm564iHhbUUSxAaFi7WOS5mhzhLTqaNN 3RkvYEgiFRMYx/iDDfYNZvPhHay9qaCe/HrTW4JTVreqnt3FUxJeyL//DTcVlUI5i4gZ U4Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=eERYF/JBRHI0w7h5eYoG+wIoaEW9wjmxzZLT70Umql0=; b=YYxA4Un8zzWwfGqNhZwK/c7J0ETs7E/PNrIkGgqSuVnRmZBIrhMqOE2qWDPunOyrHr PFeJpTpTtrjXLoXXGvK2w6qeyTdui98CgcVAh9URZUlJeTPkBAWFslGwPUGUwqMUml0B cwxBq3c6Eycj+WTc6Ds3QBIxFR2dBAordfGzT/3vy0RqyoR8V6LfhtzVyXzSM6SpL+Xv WVXKHKZS7024Xm4/lJCa/2EDX2Xvh700EtsJuhEWNEfmnaAj7K962ALms+aSMb7GcPnz XvMecWDiHm5b7h3PeRnOnX3AIGD6XKlLaHmaYHhBlexSDIIg2NTI83GSWJFmRfd0NPsq Hcrg== X-Gm-Message-State: APjAAAU2F4Ld0pNszWrjV1JJoQBSjk2iWeTqzWpuwa603FltRnbMbsWg 7drtOh+LHcVsPNkOZFTp9hwa6CkkRcM= X-Google-Smtp-Source: APXvYqzCn2jyxnYxHRbl+eF9Gw3EMIruAnQ05Lrrbe1lp6SPJW/HfLDDG00AtYi1xSSYgGsBZ9RWOA== X-Received: by 2002:a1c:6a06:: with SMTP id f6mr17097402wmc.113.1569828048240; Mon, 30 Sep 2019 00:20:48 -0700 (PDT) Received: from damijan-PC.i-tech.local (mail.i-tech.si. [89.212.78.105]) by smtp.gmail.com with ESMTPSA id d9sm17662484wrc.44.2019.09.30.00.20.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Sep 2019 00:20:47 -0700 (PDT) From: Damijan Skvarc To: dev@openvswitch.org Date: Mon, 30 Sep 2019 09:20:39 +0200 Message-Id: <1569828039-19297-1-git-send-email-damjan.skvarc@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 1/1] ovsdb-client: fix memory leak to prevent valgrind reporting memory leaks while running test suite X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org memory leaks are reported in several tests and are expressed in a following way: ==29840== 208 (48 direct, 160 indirect) bytes in 1 blocks are definitely lost in loss record 43 of 44 ==29840== at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29840== by 0x449D12: xcalloc (util.c:121) ==29840== by 0x432949: jsonrpc_msg_from_json (jsonrpc.c:697) ==29840== by 0x432A8F: jsonrpc_parse_received_message (jsonrpc.c:472) ==29840== by 0x432A8F: jsonrpc_recv.part.7 (jsonrpc.c:338) ==29840== by 0x4338F7: jsonrpc_recv (jsonrpc.c:1139) ==29840== by 0x4338F7: jsonrpc_session_recv (jsonrpc.c:1112) ==29840== by 0x40719B: do_wait (ovsdb-client.c:2463) ==29840== by 0x405F76: main (ovsdb-client.c:282) Signed-off-by: Damijan Skvarc --- ovsdb/ovsdb-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index bfc90e6..bc12d42 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -2464,11 +2464,13 @@ do_wait(struct jsonrpc *rpc_unused OVS_UNUSED, if (reply && reply->id) { if (sdca_id && json_equal(sdca_id, reply->id)) { if (reply->type == JSONRPC_ERROR) { + jsonrpc_msg_destroy(reply); ovs_fatal(0, "%s: set_db_change_aware failed (%s)", jsonrpc_session_get_name(js), json_to_string(reply->error, 0)); } } else if (txn_id && json_equal(txn_id, reply->id)) { + jsonrpc_msg_destroy(reply); check_transaction_reply(reply); exit(0); }