From patchwork Wed Sep 11 11:08:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 1160904 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="08DePBNn"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46Szfn6rFPz9sDB for ; Wed, 11 Sep 2019 21:08:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727695AbfIKLIt (ORCPT ); Wed, 11 Sep 2019 07:08:49 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:43637 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbfIKLIs (ORCPT ); Wed, 11 Sep 2019 07:08:48 -0400 Received: by mail-qk1-f193.google.com with SMTP id h126so12665828qke.10 for ; Wed, 11 Sep 2019 04:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H7dm5LylxBCKDzcEYDJbXJgGjdRd2Jacret0oWgWP8M=; b=08DePBNnPNEqO7I2YEHkuw/6RhDnUl+Z1zOBRFHDZVJYoPTDs9R4FyBQvAaokwtTWk nwaiX2Fh7Tfm7oYIMDLcVqwkpF2QwFvppZKJfKrYekzTXLD1V6B5/Wm4icI5sgDSzYSH YH46LoVYDt06zIRVBjpDsBIjErc33UUNrEniQJitSnaA3KKjaBNjOddIk6TMK3yZ5r63 FwX+QRO8Gpyvsd7CLinzHOoPvT94+Wkx6+GiPd3RHB1dNbmD9KN+oeDwGdyd9UnQ0mNh Fwzs2pZN7vf1H/2kaQmPViCB+kxA01JRavmz0a055kI+YP/yhfSR0KR3r51hfiKOdNRe ka7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H7dm5LylxBCKDzcEYDJbXJgGjdRd2Jacret0oWgWP8M=; b=hJHVwruXVPz5PfNgcK5NiZz4xgSIU0UoTb7pB/R2nREaJL/FCZBsBlxqKDNNTBziWg OsBhTGZga0KeSDIjkAYq2x/TljxLk0JI1uWMYLxvMLdnfj4j6qLPZUKKDLthAL3RsBjq 4WY7zr0g450VClh3s4lybyRk+9yrjCAFv3v8CV+4oXhPfJyiCHDLQWPMjSYpx/QG7y/X nmIrqgxTDOmw2P+0Moe7uTBBCM9U2eFjVbiWBCv/Rm+IjAPZTeTOXnWIS6DJ3lWxp3XD umqlYFP7XnsOZD4TI9GqwlHVQXNWRDl+o17PIEDF0hlJwX6b3cDcIYFAwIHf7wALe+Tn /p7A== X-Gm-Message-State: APjAAAWcdmqd7kTDYloOy/NWvG9PoYsXXqqArY3TrX6chNXeX5jNvNUt wMX+HzXIfdYz+nIGFT7bm2KEZTZKyAntPg== X-Google-Smtp-Source: APXvYqws8d4+cYdj3QpWpQltul55gM2fIVWXxd4Ux2h6Ze+XzoiH5hl+kQP4DG8LyFAl1kS67wUGww== X-Received: by 2002:a05:620a:1539:: with SMTP id n25mr34238279qkk.0.1568200127619; Wed, 11 Sep 2019 04:08:47 -0700 (PDT) Received: from penelope.pa.netronome.com ([148.69.85.38]) by smtp.gmail.com with ESMTPSA id a190sm10232501qkf.118.2019.09.11.04.08.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Sep 2019 04:08:46 -0700 (PDT) From: Simon Horman To: David Miller Cc: Jakub Kicinski , netdev@vger.kernel.org, oss-drivers@netronome.com, Dirk van der Merwe , Simon Horman Subject: [PATCH net-next 1/2] devlink: add unknown 'fw_load_policy' value Date: Wed, 11 Sep 2019 12:08:32 +0100 Message-Id: <20190911110833.9005-2-simon.horman@netronome.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190911110833.9005-1-simon.horman@netronome.com> References: <20190911110833.9005-1-simon.horman@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dirk van der Merwe Similar to the 'reset_dev_on_drv_probe' devlink parameter, it is useful to have an unknown value which can be used by drivers to report that the hardware value isn't recognized or is otherwise invalid instead of failing the operation. This is especially useful for u8/enum parameters. Suggested-by: Jakub Kicinski Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- include/uapi/linux/devlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 1da3e83f1fd4..8da5365850cd 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linux/devlink.h @@ -203,6 +203,7 @@ enum devlink_param_fw_load_policy_value { DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_DRIVER, DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_FLASH, DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_DISK, + DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_UNKNOWN, }; enum devlink_param_reset_dev_on_drv_probe_value { From patchwork Wed Sep 11 11:08:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 1160905 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="YLpPWAup"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46Szfr19Nbz9sDB for ; Wed, 11 Sep 2019 21:08:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727726AbfIKLIv (ORCPT ); Wed, 11 Sep 2019 07:08:51 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:38919 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbfIKLIu (ORCPT ); Wed, 11 Sep 2019 07:08:50 -0400 Received: by mail-qt1-f195.google.com with SMTP id n7so24704617qtb.6 for ; Wed, 11 Sep 2019 04:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=axfcNZ/bC29h7dYz9Zn0syjDqRnOdjO40Rz4inJlsr4=; b=YLpPWAupUbWFMnXvhsZ3ptYNC05VABx5KYCg/G12jc4bWWRUJvcRYGNMLOzHdRpec4 aeAa2QsYTKbwoI28zJ1W8mvwqN1YpNKll60IplGn1kOZ47Q2okH/rN13QMVSDn3qKib8 7GA9oKq1oFHmfSTKG4bytn5xlKoNSrvXlZIa4vc1RsQtBlRMYGb70g/ourEWyFdmbau6 FO09F03rzvy10Kyhpf5P0mNBj1Cq17H3pZlc1TIEI6B4b3WcrVYLcnpxLMoeOaaMkqud YK4I0c+2rWB1EtpixQjFqnDxei4gxt6nA4XNcdMMTbX2StQa3HZzVIYM624v9vW1CyRS sG5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=axfcNZ/bC29h7dYz9Zn0syjDqRnOdjO40Rz4inJlsr4=; b=MyO5tLTyop62gw79bKooOIo/lP2DHYyzKXg4Sx5lW+reAvGak7Q8CbMrvuugOOZVJS HUafTSugPCiTk+UC899hFzxVMqhJ1S7AdtIJnQMESR86mU5XJpZGZsNCMidQAdOHzwn8 9YRsvv9du+u6ELSjOdyfOuM6I82ge86E4k2xclLPcydu60dDh3aLlY4+uatUFfmo9EFE 2mMLkYXdy+qJp4hdqjU66/TpGqeNIUHFw35BlWxy9SX/z9CZH0IKV61uJ4kfKAxmsT87 +5MnPjMHprlGqx8nAhFR13FIZThfVXTSw6z/CV+EXNT/iVLEucpE2MZPbBE86h0JzWhS vLdw== X-Gm-Message-State: APjAAAUJOkMgCs1CvmT/0CGiDqbSNOL9bZv4iwVU1hKbWTapIqCGVe4y 4oJhiEYQAA/TdZc3FQM8IOFeCA== X-Google-Smtp-Source: APXvYqyKqRziO4ohIw7LqjSfrswNdWm7v/46iQ50mPu/iyM9jMy1yR1TS1q6GQ8J+iPbIidB2J7vnw== X-Received: by 2002:a0c:e74b:: with SMTP id g11mr16010814qvn.62.1568200129574; Wed, 11 Sep 2019 04:08:49 -0700 (PDT) Received: from penelope.pa.netronome.com ([148.69.85.38]) by smtp.gmail.com with ESMTPSA id a190sm10232501qkf.118.2019.09.11.04.08.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Sep 2019 04:08:48 -0700 (PDT) From: Simon Horman To: David Miller Cc: Jakub Kicinski , netdev@vger.kernel.org, oss-drivers@netronome.com, Dirk van der Merwe , Simon Horman Subject: [PATCH net-next 2/2] nfp: devlink: set unknown fw_load_policy Date: Wed, 11 Sep 2019 12:08:33 +0100 Message-Id: <20190911110833.9005-3-simon.horman@netronome.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190911110833.9005-1-simon.horman@netronome.com> References: <20190911110833.9005-1-simon.horman@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dirk van der Merwe If the 'app_fw_from_flash' HWinfo key is invalid, set the 'fw_load_policy' devlink parameter value to unknown. Suggested-by: Jakub Kicinski Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/devlink_param.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/devlink_param.c b/drivers/net/ethernet/netronome/nfp/devlink_param.c index 4a8141b4d625..36491835ac65 100644 --- a/drivers/net/ethernet/netronome/nfp/devlink_param.c +++ b/drivers/net/ethernet/netronome/nfp/devlink_param.c @@ -32,7 +32,8 @@ static const struct nfp_devlink_param_u8_arg nfp_devlink_u8_args[] = { [DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY] = { .hwinfo_name = "app_fw_from_flash", .default_hi_val = NFP_NSP_APP_FW_LOAD_DEFAULT, - .invalid_dl_val = -EINVAL, + .invalid_dl_val = + DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_UNKNOWN, .hi_to_dl = { [NFP_NSP_APP_FW_LOAD_DISK] = DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_DISK,