From patchwork Tue Aug 27 18:09:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1154004 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WRftCuMg"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46Hxjr5hJWz9sNC for ; Wed, 28 Aug 2019 04:10:07 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E7A591A66; Tue, 27 Aug 2019 18:10:05 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id AA08D1A55 for ; Tue, 27 Aug 2019 18:10:04 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8C448756 for ; Tue, 27 Aug 2019 18:10:03 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id n190so13129652pgn.0 for ; Tue, 27 Aug 2019 11:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=acNgZoVNl0k+jIq9q+78OnpqHqRzXWu7fkL4PORK1q8=; b=WRftCuMgFeT4D2MkyqI/FtNNVhHpwC4/1rAYR0gLLGF+D+S33UK1+ACBKUNSRSgayy GqUTdiJYc3gLQTTM/ozTk7RleeQgWd7+/5QUM1mLiI4eIBd+n05T0H3kDslTuo8UbXq9 8PUcL2DzaDSA3VFOPgxm4st+P9o15+UTYLdCXzc2/ngmGj2CJ1X6BqhGyzCVCftcwv46 fHe8r9bn4OtH6oghYTRE0WrlPoHNN2bYvLf8a9uTZDbUW7na7n6ucF6dTndwwYdjSF4J sAv+GVtLvS+68fTa0pBfWcGVRxaeqkXFucOpAlwLdVqC34hbOaRfpTfxj6bOXHoBZT0L iERg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=acNgZoVNl0k+jIq9q+78OnpqHqRzXWu7fkL4PORK1q8=; b=h7h0RPg1at2HGe4f4eMscGHLqceUFjD+cG8xjK3zcYDeosgYZaN42CurUfNLIQVXDw VBtYQUW6n8F5As+rItGnliAXyGFPBeKqv7USyvMnkC/YQTvYPn1biPArPQSlIqz8s9y2 InPuWH2zqlb4Y8JGTG77hGpav/dW7RIfM5U4rD+yT7F9BNYWftgdZqyR589PXiKj/WjM dXe3EC06b2B5L3my88xqYLooATl4Xi6wtlb2FoWyhnNQjmWtOryOfkvH1BV3cz6HPEng DJ++UbFdDRJ+b6q80efNbQ8xui0tlOZIsEEycdfJwNcXg0A3tjxqSGGKNnqc5QX1BMZ8 m6Wg== X-Gm-Message-State: APjAAAVZ6IPU4und84qlglXy3Kko/rSGMB51mUN7ykVMlpWNitjbm8e4 wreBs/eHeSS6qUZnLbSiHUlRueio X-Google-Smtp-Source: APXvYqzI6w/Dgigi7LdJKa8tYLKN7Xqbo8/UL4tbgcPr6XZmN6jOudivAKGE5hR4vVNFpVF/LB2n5A== X-Received: by 2002:aa7:9abc:: with SMTP id x28mr28015230pfi.234.1566929402767; Tue, 27 Aug 2019 11:10:02 -0700 (PDT) Received: from sc9-mailhost3.vmware.com ([66.170.99.95]) by smtp.gmail.com with ESMTPSA id 195sm17435759pfu.75.2019.08.27.11.10.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Aug 2019 11:10:02 -0700 (PDT) From: William Tu To: dev@openvswitch.org Date: Tue, 27 Aug 2019 11:09:13 -0700 Message-Id: <1566929353-22329-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Gurucharan Shetty Subject: [ovs-dev] [PATCHv2] ovs-lib: Add timeout at ovs-check-dead-ifs. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read an entry in /proc//fd/ but hangs forever. The pid is a qemu-system-x86_64 process and we suspect it's an issue related to qemu, not ovs. As a result, force-reload-kmod hangs and OVS bridge never gets restarted. This patch adds a timeout of 5-seconds to ovs-check-dead-ifs. VMware-BZ: #2408059 Signed-off-by: William Tu Cc: Ashish Varma Cc: Gurucharan Shetty --- v2: address feedback from Guru --- utilities/ovs-lib.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index 76ce79b9c39f..c8c09dd12d31 100644 --- a/utilities/ovs-lib.in +++ b/utilities/ovs-lib.in @@ -654,7 +654,8 @@ force_reload_kmod () { restore_interfaces - "$datadir/scripts/ovs-check-dead-ifs" + action "Finding processes on dead interfaces" timeout 5 \ + "$datadir/scripts/ovs-check-dead-ifs" || true } ## ------- ##