From patchwork Thu Aug 15 18:12:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Michelson X-Patchwork-Id: 1147748 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 468ZL12mh9z9sND for ; Fri, 16 Aug 2019 04:12:24 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B636FECC; Thu, 15 Aug 2019 18:12:21 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 1A1C8E7D for ; Thu, 15 Aug 2019 18:12:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D34A187E for ; Thu, 15 Aug 2019 18:12:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 37C9F300442C for ; Thu, 15 Aug 2019 18:12:19 +0000 (UTC) Received: from monae.redhat.com (ovpn-122-89.rdu2.redhat.com [10.10.122.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id E13EA1EA for ; Thu, 15 Aug 2019 18:12:18 +0000 (UTC) From: Mark Michelson To: dev@openvswitch.org Date: Thu, 15 Aug 2019 14:12:18 -0400 Message-Id: <20190815181218.22206-1-mmichels@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 15 Aug 2019 18:12:19 +0000 (UTC) X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v2.12] OVN: Repair memory leak for OVN controller events. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Controller event action is leaking its genopts. This corrects the error. --- ovn/lib/actions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c index b0cb3490b..274297194 100644 --- a/ovn/lib/actions.c +++ b/ovn/lib/actions.c @@ -1760,8 +1760,9 @@ parse_trigger_event(struct action_context *ctx, } static void -ovnact_controller_event_free(struct ovnact_controller_event *event OVS_UNUSED) +ovnact_controller_event_free(struct ovnact_controller_event *event) { + free_gen_options(event->options, event->n_options); } static void