From patchwork Tue Aug 6 08:01:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 1142652 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WXwzjC9G"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ngkhyNar"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 462nCj14DWz9sBF for ; Tue, 6 Aug 2019 18:01:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GuvzqV34wjbVCZNyJb7+/PcHWjVpFY2V/WGiK7d/iYc=; b=WXwzjC9GsIrJ8W +SOsKAake3v38N+YCUjeEDpluwjNzXTQGNef07J9xx3AoMd45F/BC/vSfOSK0ULB4aNmcyjhBwgbF X9LJhoC29M8KZbXrZXr/nq2J/4SH3VX4ZMKE2GKVGtZFs1uOgknXAE1wf4Ew7bX3d18TY/LsbOta3 uf+LpjOO5Bs3NYk62TY0r5LbbUrJW8rT7yjNr7I9ZzvzOaiKzx3MVrOV75WZaeRmY1weKLZudE4Kv lo8NAV/ffOcfhbYogxoAoFdbJXHBPwlXBMvnWi/du1jHdu5G+nWANtM3OphaPE/X0TMVnGpHL/9Vq oPan21SNr9I+ONOYuNfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huuPV-0000gi-1L; Tue, 06 Aug 2019 08:01:33 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huuPR-0000gI-E1 for openwrt-devel@lists.openwrt.org; Tue, 06 Aug 2019 08:01:30 +0000 Received: by mail-lf1-x143.google.com with SMTP id v16so6417529lfg.11 for ; Tue, 06 Aug 2019 01:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ipyrEO/T1aelBNsUV0R/bF6/NaVrYfNCN79FrfhP4bs=; b=ngkhyNar6sZOMCMk2pfQ8s56LCAczoknGFK0BpbNxsFmqrN69MGvTv9mem5OjTZqvi Pc0jQ/y0uQ+bwMoorgyLc4s87tuoSQmRF3AKhaK023rXlfzu8IexWjGKntOj7BkGsS+L sisJx6uTFNzlKT8dUVcMs7WcsqYGLfIZJlO7Kr6LAwcCMREpAfJgUQ8ykyKG/dEDDGTL gIKtxdlLlhjL5gbC6si6g+gkYw+PCIgzo2kTGBrax5RHPvvBQL4DoKBYo5i2G2iyIOt3 CFBhZeg+bxvZLtCxYJp//ok/g14v9XSfrMzy9fmO/wwuD4lxdL/yvWTzTLOld+ZakBHm IJdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ipyrEO/T1aelBNsUV0R/bF6/NaVrYfNCN79FrfhP4bs=; b=Hd/a9xInJixur5GOKB4zQq3WNmbz912WN/nZwVBnodmlVSuchsn7U31wkMUqz2SI53 4WEPb9VMsbI8xqJpV8yjECcrJdw77T2mN8rqWdt4jbyl5vRl9dhKHzTtd2LqFmnKr6J/ CexVpGm/RC0iETEqRFD85CHNdhflFvZYH5p5f/riuyv5gsvICWHL8ivZvOwCv9WkRMtI WHlDNlrz/YLw1yS629NedzsoYSypxWLdz9MpYmVFtFAI89Y6lmQcl+nAzvPRUEanTVcr SaVJWjcZX1PxcRW2iOF0cSZf5Pb9l+TAnF3C5LOuiWv60p6Ki/Yj3/uhAga0ESBq9Ypc l7Ng== X-Gm-Message-State: APjAAAXYEPnoi+i+KnR1tsMgkkupqyx/x4/Sj0G95epgyr/oMJQM3f/m b/sTXUqdFy6ddjSWK0VrSJ6rHVlF X-Google-Smtp-Source: APXvYqxgwjRcC6e4NhxhT9lajO8TQJy/Sc9Qc2fCVbR7tWdEx3J6RSQuDoOsAOipd2dm4Sz8PCrkhA== X-Received: by 2002:a19:7908:: with SMTP id u8mr1476861lfc.178.1565078486709; Tue, 06 Aug 2019 01:01:26 -0700 (PDT) Received: from localhost.localdomain (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id x137sm15373529lff.23.2019.08.06.01.01.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 01:01:25 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: openwrt-devel@lists.openwrt.org Date: Tue, 6 Aug 2019 10:01:15 +0200 Message-Id: <20190806080115.17406-1-zajec5@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190806_010129_474278_685CCDEC X-CRM114-Status: GOOD ( 10.46 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:143 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (zajec5[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zajec5[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid Subject: [OpenWrt-Devel] [PATCH] kernel: drop Fon(Foxconn) parser matching for the "firmware" partition X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , NOGUCHI Hiroshi , =?utf-8?q?Petr_=C5=A0tetiar?= Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Rafał Miłecki This parser's matching function appears to be too generic as it matches e.g. Buffalo WZR-HP-G300NH. That results in incorrect parts parsing. Luckily this parser is needed by Fon FON2601 only which uses DT-based ramips target. It means we can depend on mtd subsystem matching of "fonfxc,uimage" string. That said triggering this parser based on the "firmware" (or whatever MTD_SPLIT_FIRMWARE_NAME is) partiiton name is not needed. It can be dropped which will automatically fix the Buffalo WZR-HP-G300NH case. Fixes: a1c6a316d299 ("ramips: add support for Fon FON2601") Signed-off-by: Rafał Miłecki --- .../linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c index 091403ae91..41347d0419 100644 --- a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c +++ b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c @@ -421,7 +421,6 @@ static struct mtd_part_parser uimage_fonfxc_parser = { .of_match_table = mtdsplit_uimage_fonfxc_of_match_table, #endif .parse_fn = mtdsplit_uimage_parse_fonfxc, - .type = MTD_PARSER_TYPE_FIRMWARE, }; /**************************************************