From patchwork Fri Jul 12 13:04:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1131362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="CrfArhFt"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45lYLV3Fv9z9s4Y for ; Fri, 12 Jul 2019 23:14:57 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id DA895586E; Fri, 12 Jul 2019 13:14:51 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 5679E5868 for ; Fri, 12 Jul 2019 13:04:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id CEFF1887 for ; Fri, 12 Jul 2019 13:04:47 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190712130445euoutp0292e4a09ada7c957a51db04f10e2d0f12~wqqKUeZc43168431684euoutp02N for ; Fri, 12 Jul 2019 13:04:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190712130445euoutp0292e4a09ada7c957a51db04f10e2d0f12~wqqKUeZc43168431684euoutp02N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1562936685; bh=2+0mNzNGaaKMcAKv4ZjcTBTBZM2VZe9kMF2zBxAHJSM=; h=From:To:Cc:Subject:Date:References:From; b=CrfArhFtz2rHpgjH5ZshYO1FQic0rX9kcpD3eXwXAwgLUBp6e3eMF6GerqLnUMtxJ 3C5lJ2X5AI7d5OCp/McPXkCRl/Vi7cpVuF96hUUdtrxpbHRkM8Wzej/OTdTLj1zNoF b2ZdazjliQcHufFN9ltqyLMOgzWrW+3TrBnTMSL8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190712130445eucas1p15aa43cfa7631ac99b9e9571035abd1a6~wqqJ6z84P2224022240eucas1p1j; Fri, 12 Jul 2019 13:04:45 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 4D.17.04298.D65882D5; Fri, 12 Jul 2019 14:04:45 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190712130444eucas1p21e516506297d77eaf396bcbaafe52efe~wqqJI0qH30500105001eucas1p2h; Fri, 12 Jul 2019 13:04:44 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190712130444eusmtrp1a373a44f146a1755097f52a69603a87e~wqqI6yfME2174921749eusmtrp1V; Fri, 12 Jul 2019 13:04:44 +0000 (GMT) X-AuditID: cbfec7f2-f13ff700000010ca-aa-5d28856d1e19 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B8.05.04140.C65882D5; Fri, 12 Jul 2019 14:04:44 +0100 (BST) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190712130443eusmtip14b69b96fed17e1deb8330c87b72afda1~wqqIfRuN31339813398eusmtip1G; Fri, 12 Jul 2019 13:04:43 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Fri, 12 Jul 2019 16:04:38 +0300 Message-Id: <20190712130438.7431-1-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWy7djP87q5rRqxBhtu8Fr8evOA3eLV5AZG i8b+bywWV9p/slvM/fSc0YHVY/Gel0wez27+Z/R4fq2HxeP9vqtsHn1bVjEGsEZx2aSk5mSW pRbp2yVwZaw/eoapYAJPxYSbyQ2M87i6GDk5JARMJG7+OcTexcjBISSwglFinnEXIxeQ+YVR YsurU8wQzmdGiaYPy1lhGro3NrKD2EICyxkldt/NgSj6wSixoXECM0iCTUBH4tTqI4wgtoiA tMTr3jdgzcwC0xklrs21B7GFBewlFqy6xwRiswioSszdt5MFxOYVsJLYtqmHCWKZvMTqDQfA rpAQOMEmseT+WWaIhIvE03vLoWxhiVfHt7BD2DISpyf3sEDY9RL3W14yQjR3MEpMP/QPaqq9 xJbX58B+ZhbQlFi/Sx8i7CjxZHcLG0hYQoBP4sZbQYib+SQmbZvODBHmlehoE4KoVpH4fRDm AimJm+8+Q13gIdHw6j8bJEBjJSZ885rAKDcLYdUCRsZVjOKppcW56anFhnmp5XrFibnFpXnp esn5uZsYgRF/+t/xTzsYv15KOsQowMGoxMN7w1I9Vog1say4MvcQowQHs5II76r/QCHelMTK qtSi/Pii0pzU4kOM0hwsSuK81QwPooUE0hNLUrNTUwtSi2CyTBycUg2Ma1hMpkRZzpLb8qtr z7MH05Y3TNwUKLLnYI7PtL4HytLFvz1Vz3PrzlkndC96XtjV2ADNyF8f+jZuXPZE9rpajax9 mHusbU/b/X2h8u2/ZrBw5bjnHT1z7d3Sm75Kf3lCJdcITPR2E8y2273t84rM7tJnfYzR+R/c q9SvM6+41C0gv+feva1cSizFGYmGWsxFxYkAdgZQ2PQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNLMWRmVeSWpSXmKPExsVy+t/xu7o5rRqxBhe+iVn8evOA3eLV5AZG i8b+bywWV9p/slvM/fSc0YHVY/Gel0wez27+Z/R4fq2HxeP9vqtsHn1bVjEGsEbp2RTll5ak KmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk5mSWpRbp2yXoZaw/eoapYAJPxYSb yQ2M87i6GDk5JARMJLo3NrJ3MXJxCAksZZQ4vuA/O0RCSuLHrwusELawxJ9rXWwgtpDAN0aJ abfKQGw2AR2JU6uPMILYIgLSEq9737CCDGIWmM0ocez3CiaQhLCAvcSCVffAbBYBVYm5+3ay gNi8AlYS2zb1MEEskJdYveEA8wRGngWMDKsYRVJLi3PTc4uN9IoTc4tL89L1kvNzNzECA27b sZ9bdjB2vQs+xCjAwajEw3vDUj1WiDWxrLgy9xCjBAezkgjvqv9AId6UxMqq1KL8+KLSnNTi Q4ymQMsnMkuJJucDoyGvJN7Q1NDcwtLQ3Njc2MxCSZy3Q+BgjJBAemJJanZqakFqEUwfEwen VAMj42PW7y5l3wrqjre/DRS+4vLoyhQt7Q380tzMc6sl0iekOoQ+/nb1r14Il8Xx7R96Xf/s +11kZVpwJ8z3Ylff6dAXKxss3ExbV2wqXvJm6ey27L+Jdxl+2CS6rzhy6YXxMzNWOUvt1Zxm KV80KlK2if3wtu3fOTV/16870iss16nM/Zz++WSEEktxRqKhFnNRcSIAGr1mW04CAAA= X-CMS-MailID: 20190712130444eucas1p21e516506297d77eaf396bcbaafe52efe X-Msg-Generator: CA X-RootMTR: 20190712130444eucas1p21e516506297d77eaf396bcbaafe52efe X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190712130444eucas1p21e516506297d77eaf396bcbaafe52efe References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH] checkpatch: Check FOR_EACH loops with numbers. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org OVS has defines for loops like 'BITMAP_FOR_EACH_1' or 'ULLONG_FOR_EACH_1', but the regexp in checkpatch doesn't match with numbers and skips these loops while checking. This patch adds numbers into regexp and adds some FOR_EACH loops to the unit tests. Signed-off-by: Ilya Maximets Acked-by: Ben Pfaff Acked-by: Aaron Conole --- tests/checkpatch.at | 2 +- utilities/checkpatch.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkpatch.at b/tests/checkpatch.at index 07f4b137c..f3b26dd34 100755 --- a/tests/checkpatch.at +++ b/tests/checkpatch.at @@ -179,7 +179,7 @@ m4_define([COMMON_PATCH_HEADER], [dnl AT_SETUP([checkpatch - parenthesized constructs]) -for ctr in 'if' 'while' 'switch'; do +for ctr in 'if' 'while' 'switch' 'HMAP_FOR_EACH' 'BITMAP_FOR_EACH_1'; do try_checkpatch \ "COMMON_PATCH_HEADER + $ctr (first_run) { diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index ae86937c8..de5061406 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -143,7 +143,7 @@ def reset_counters(): # something in parentheses (usually an expression) then a left curly brace. # # 'do' almost qualifies but it's also used as "do { ... } while (...);". -__parenthesized_constructs = 'if|for|while|switch|[_A-Z]+FOR_*EACH[_A-Z]*' +__parenthesized_constructs = 'if|for|while|switch|[_A-Z]+FOR_*EACH[_A-Z0-9]*' __regex_added_line = re.compile(r'^\+{1,2}[^\+][\w\W]*') __regex_subtracted_line = re.compile(r'^\-{1,2}[^\-][\w\W]*')