From patchwork Sat Nov 4 15:27:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 834193 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="k2eIImAO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yTjP722mzz9sPs for ; Sun, 5 Nov 2017 02:27:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932287AbdKDP1S (ORCPT ); Sat, 4 Nov 2017 11:27:18 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:46468 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbdKDP1R (ORCPT ); Sat, 4 Nov 2017 11:27:17 -0400 Received: by mail-pf0-f194.google.com with SMTP id p87so4451326pfj.3 for ; Sat, 04 Nov 2017 08:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=luIkSrBWo7GI6reVTsgItZhz6CtzYfsOb7psSPbCpsc=; b=k2eIImAOCm7hKm65tb1SjjJrSANFoFJXSN90bcWHgk9kgNRwKaWtERlI+sm5jrcds+ 8SRxzBafjNu083Fs1Y+6C4HllnvgQc9d8J/wgnNVO4mYqBBNoVna5kRG2rth/wwtA8yV 9Cn35Ol9ALS/FkjtGrpZJz3kxOPsudsZ3ABHdPOjaKC1ss4ldW98ih/brUQvojy1ktkM cL+iSwTCTaZphSqYN5XWoBO3VLRYVk45zJlI7f95pFLwtAeznd93BJilU9lBSZ+kM3Fr 7G1o5WO/Z8CwHHIVdjA/2ajCMPHcLy23RLusVCt/RvtotvCyUXwBb5SpJFmonmKW1jQ6 yHVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=luIkSrBWo7GI6reVTsgItZhz6CtzYfsOb7psSPbCpsc=; b=FmWgkMJodiHu/zrLSKQgNiBlynU0mcVf+YJ2Up2PVrY5/pFWyHbRnetDtTtUkJKu9U WkbIhqDoptA1DPzus+UxJ37iaFl5fisn2hrryc5yM/m7hmZgrhTNA/XVwj6bslP2Fwb2 bepICp2duH4UVAksLhZwmihA+4JsHFyr6NpNbCj7+rN22t75xSa+PXmsPJPrBJNQHHWa lpyviKlNC3RIdkp+rleFlaMPpfo0206GaYs6DQ7UkKq8zl9afdLzwK4NY4euSoradCFt 8RpreffwJ71//287pPJFFXu2s04A+Bu6zGcPhCOLuQtmcBUiyGpO6/PYGZZD2HDUfBJ7 4gZA== X-Gm-Message-State: AMCzsaVwrDelEXX8NPtPfmktFeqc1Tny3HcjQ6HjEBmG4+Qq3iyGVErq FWiTLlgf9+46G1VkLP2Td9KeNQ== X-Google-Smtp-Source: ABhQp+Tc2a3HeCQuZCN/mVUDMxx++x6/VzetfF1ubFRfDS0QqOil7bZD0Af4Ht3/6+YdZlc7RaFx9w== X-Received: by 10.99.60.11 with SMTP id j11mr10396535pga.21.1509809237473; Sat, 04 Nov 2017 08:27:17 -0700 (PDT) Received: from [192.168.86.171] (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.googlemail.com with ESMTPSA id o10sm13057684pgq.69.2017.11.04.08.27.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Nov 2017 08:27:16 -0700 (PDT) Message-ID: <1509809234.2849.73.camel@edumazet-glaptop3.roam.corp.google.com> Subject: [PATCH net-next] pktgen: do not abuse IN6_ADDR_HSIZE From: Eric Dumazet To: Eric Dumazet , David Miller Cc: Dan Carpenter , netdev Date: Sat, 04 Nov 2017 08:27:14 -0700 In-Reply-To: References: <20171104083119.kpl47mryrx3h27pl@mwanda> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet pktgen accidentally used IN6_ADDR_HSIZE, instead of using the size of an IPv6 address. Since IN6_ADDR_HSIZE recently was increased from 16 to 256, this old bug is hitting us. Fixes: 3f27fb23219e ("ipv6: addrconf: add per netns perturbation in inet6_addr_hash()") Signed-off-by: Eric Dumazet Reported-by: Dan Carpenter --- net/core/pktgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 6e1e10ff433a5f4097d1d4b33848ab13d4e005c6..e3fa53a07d34b3e5f6b438e08b440f520b3cd6d4 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2165,7 +2165,7 @@ static void pktgen_setup_inject(struct pktgen_dev *pkt_dev) + pkt_dev->pkt_overhead; } - for (i = 0; i < IN6_ADDR_HSIZE; i++) + for (i = 0; i < sizeof(struct in6_addr); i++) if (pkt_dev->cur_in6_saddr.s6_addr[i]) { set = 1; break;