From patchwork Mon Jun 17 16:49:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 1117145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45SHHS70zRz9sN4 for ; Tue, 18 Jun 2019 02:49:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728332AbfFQQtX (ORCPT ); Mon, 17 Jun 2019 12:49:23 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:35495 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbfFQQtX (ORCPT ); Mon, 17 Jun 2019 12:49:23 -0400 Received: from orion.localdomain ([77.2.173.233]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MPGiR-1hzh1w0jJF-00PaW9; Mon, 17 Jun 2019 18:49:21 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org Subject: [PATCH 1/7] drivers: gpio: rcar: pedantic formatting Date: Mon, 17 Jun 2019 18:49:14 +0200 Message-Id: <1560790160-3372-1-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 X-Provags-ID: V03:K1:SnjedU/ByefI/v0vNbinpChc6ZVtZNlZXKpElIxqUSAyHtl9+px 07HnozTKE3SX9mBPjHneNa/sjo5Q7zEGb1/X8kGbR4FM6uEhfj5EHfg40sURf3U4DoFPB3p 70L82paEJ6zUlXe5g70WkgJgg+3/KDbGXAPuslLcKR0pTBuYtagMMGkDZRch5Fe7ZEYW9Zx udjHnVPs6o8AnzJKZkhIg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:yFkVa1pZbcs=:NNJ0AO5YnYEUvwuMScIjYC zHUH+52tXowPfQmcQSjHODmvaCxdiVAHDYOBBk5rPBIoxeqXTxVO1tyZtb/93N/sIo8K2yuzk 2TZSCVhniXOZY0Q5xhEadiYtUh4FHKhiFcB+0/UcfdyY49oPDyFSvwsu1wV1Zhoqo8SAInyRz 7Mr57nqdcE8AkVlPa6awQlPgAU+lMFcrUOuezntcJVPtI+2WeHPbeJ6b2wpDuqE5k5SgDLHkC 77L3TUQ2pUxIizJJz0Ti3nrFk3v9tgUcftaRX4hJtfI4sH/ztOi0oHh8cgEOkwpcK25IDuivt VV5hRxlIuhAO8iEUnBRCMbZCzqf6bOGdJo5kNuSXeHcRH4AiwDafOtyiboSpoD5d2rP4u94Jt SAlRbpTyw3EJ1qaeUtPHk3035LT9seVRI2OQDEfGKyvpE/Kg7IYIRux7hccDwZ1DileJ5l7vg NaNM6md1zafVefA+4rmXrF8NRUkups9+AlgCVLRucaxPBwmLL8BNWekwh9qARvhSccQsPVT8H 2rnjLXbZdI/cW1KHCUKxIJiTjLWSTf20vmcG5944jSgu8N8ZC8X+eiHwcdERbt6ejihbpFw3T 4qO6XYAQJoZ52WpxmYOT+UoJZkO6RjfOcIYdibYnq6LWCF231ll0Ca+cEuQS04+qQC1cExs3A sIe82nKmobjJo/TOunyHfYNIYzwi8VJnsw4pcsDWQ0JJbLJgt3v/EGubcTJ01upiz72zFKDEG /NrXlxLr9rE1fHp83pD5+Yg8IXpHLEJUYV8zjg== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org A tab sneaked in, where it shouldn't be. Reviewed-by: Geert Uytterhoeven Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-rcar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 70e95fc..187984d 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -489,7 +489,7 @@ static int gpio_rcar_probe(struct platform_device *pdev) irq_chip->irq_unmask = gpio_rcar_irq_enable; irq_chip->irq_set_type = gpio_rcar_irq_set_type; irq_chip->irq_set_wake = gpio_rcar_irq_set_wake; - irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND; + irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND; ret = gpiochip_add_data(gpio_chip, p); if (ret) { From patchwork Mon Jun 17 16:49:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 1117151 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45SHHy05bjz9sN4 for ; Tue, 18 Jun 2019 02:49:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728602AbfFQQtp (ORCPT ); Mon, 17 Jun 2019 12:49:45 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:47831 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728284AbfFQQtX (ORCPT ); Mon, 17 Jun 2019 12:49:23 -0400 Received: from orion.localdomain ([77.2.173.233]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MzyAy-1iWGpD2UYo-00wzKU; Mon, 17 Jun 2019 18:49:21 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org Subject: [PATCH 2/7] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev Date: Mon, 17 Jun 2019 18:49:15 +0200 Message-Id: <1560790160-3372-2-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560790160-3372-1-git-send-email-info@metux.net> References: <1560790160-3372-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:Z3KuajUAaUUjLvsAg7Xpv8G/DgShgCtjBl3js4zSDDS61jfGx7s oEnwoORX3CnJNmya8kV5iANt4JSd0WRVdObYZpsWOXzhH1YK0yEMOBplGvAjU3evG7V+YoN Ixtw9mhS72bQhophVMdXVaratm3ZvZsn85Pc02/hujh2R7w2oZayxA2n6eyhBBCZb3KNidy VvgkLsJ3myN4KLJ5uhYvg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:4cTBDo7hRso=:7XE4qgatN8cKIgZKws7cr3 NwboWBqYLTMyLaahGrLMVKZZhyosrvEcwZBQWgH7Nj1XGL+VlciRg1WTEtJ2xDGTACtr5k+E9 4JO7vLwZtA+Ujj9dBYMid6zf0DDGH75ZPPIJwevXwzsB31WjcB2UU2b1hEmPqLZfqRBcO2Pag d50Lus0c67juIVtzIRRFVYxcDZ0GJ4+6KPtxIr7+r4izufR+ds4KDDKQ2BKAgZ0Z16w9JgN0F wRdEbrVKiWtWoLydh2CzcwqY6EvA5cAwlSXKuaY+RiP/j4aZ7Hkla9U1e8tYrkQhd6EBeylHy Ai1lO46PatkMXjXOyeC8YZTQRKWs4MuNyLik0Z5vHtjCdlA+ksXEV1LFBxouOomwbeH86gxIS iFRRFZrrR9Nliw7Z2HrUfWsEzTsWAQVFafoTDNFdrbvevecP17RQPRWUL91XhrHk2vksTabM3 vcMEAl2sHj9NuKx4MzcV6kVWMD7o/C/SFsrBxXM1kxTO+GUpAA08SkFhVo1U77AkZ+d2xvijO p9ATiShzT1bIM08MCfh2rhXAHBP9aT4DYFb/6FZ9DbNeziHpN6ndjUG5+35KwElkC3PmAOwxS vRkr2ObrmY8gU9nBdqMC7fu3KaneMm+gXwclOT7q3/fmcpHMHdrr5iTpmET50GQ3sodV+0Rrx LBTtNu/6jQ3Gwm/8fu/uzDvKan0/QhcZ6++Fdu1XSA1PZ+IfMh1UMrtDwStS3iDmJuuQN0NC2 sn5VRvLf/afi5CjVk9tRgTHXjtSmChlsOh5uTg== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org We already have the struct device* pointer in a local variable, so we can write this a bit shorter. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-amdpt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-amdpt.c b/drivers/gpio/gpio-amdpt.c index 1ffd7c2..2ec9d1f 100644 --- a/drivers/gpio/gpio-amdpt.c +++ b/drivers/gpio/gpio-amdpt.c @@ -91,7 +91,7 @@ static int pt_gpio_probe(struct platform_device *pdev) pt_gpio->reg_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pt_gpio->reg_base)) { - dev_err(&pdev->dev, "Failed to map MMIO resource for PT GPIO.\n"); + dev_err(dev, "Failed to map MMIO resource for PT GPIO.\n"); return PTR_ERR(pt_gpio->reg_base); } @@ -101,7 +101,7 @@ static int pt_gpio_probe(struct platform_device *pdev) pt_gpio->reg_base + PT_DIRECTION_REG, NULL, BGPIOF_READ_OUTPUT_REG_SET); if (ret) { - dev_err(&pdev->dev, "bgpio_init failed\n"); + dev_err(dev, "bgpio_init failed\n"); return ret; } @@ -110,11 +110,11 @@ static int pt_gpio_probe(struct platform_device *pdev) pt_gpio->gc.free = pt_gpio_free; pt_gpio->gc.ngpio = PT_TOTAL_GPIO; #if defined(CONFIG_OF_GPIO) - pt_gpio->gc.of_node = pdev->dev.of_node; + pt_gpio->gc.of_node = dev->of_node; #endif ret = gpiochip_add_data(&pt_gpio->gc, pt_gpio); if (ret) { - dev_err(&pdev->dev, "Failed to register GPIO lib\n"); + dev_err(dev, "Failed to register GPIO lib\n"); return ret; } @@ -124,7 +124,7 @@ static int pt_gpio_probe(struct platform_device *pdev) writel(0, pt_gpio->reg_base + PT_SYNC_REG); writel(0, pt_gpio->reg_base + PT_CLOCKRATE_REG); - dev_dbg(&pdev->dev, "PT GPIO driver loaded\n"); + dev_dbg(dev, "PT GPIO driver loaded\n"); return ret; } From patchwork Mon Jun 17 16:49:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 1117149 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45SHHn5MGzz9sNR for ; Tue, 18 Jun 2019 02:49:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728435AbfFQQtY (ORCPT ); Mon, 17 Jun 2019 12:49:24 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:41503 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728293AbfFQQtY (ORCPT ); Mon, 17 Jun 2019 12:49:24 -0400 Received: from orion.localdomain ([77.2.173.233]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mi23L-1iG7No45uD-00e52D; Mon, 17 Jun 2019 18:49:22 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org Subject: [PATCH 3/7] drivers: gpio: eic-sprd: use devm_platform_ioremap_resource() Date: Mon, 17 Jun 2019 18:49:16 +0200 Message-Id: <1560790160-3372-3-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560790160-3372-1-git-send-email-info@metux.net> References: <1560790160-3372-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:9Jlp9rHiItV3zqKzDwaWVBFkDeX7gjjyObSukf3rIXhuONjebUQ ZYl1jTOOEBWEPasLxvfcp6lvcVoJieD/5zCltzryi0HxWqabeTpHiI5eMLwqxjMBWvQ96K7 PAnrCBYF+Vv0JmjJrO8R1rjR1OcJNBnUAaOy342pFeyUgBhjPrdu8npOt6QW34kURcLHUKz g08VtqaX1ArHJHny9oZpg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:PE9+bm3ZAZs=:RxCy8vZlMN0lEU3XeOwMnE xlP7Ie4LoSPgLSa7TQXnr13nZi143W+uCLF8PCur7Rp/aYst41eeXTbInRPLxyABphzhQjJph TGYiJMAplHg8uawDU27OJlaS7oA+hhue5d0tYAqAzwkB/JPhpNhkDsMsL6jgShLpgujf6+xeO 8OGstXgtQgYacvA7hev/mIzgJeai30Zbi5tte4oekMp37dyx3TPSwBD8tBtWJ67lL/N7RY+dc Fn3pEgscFJIm9SSaliRKWoMUuA28Ibfn/gsFDGCvwEkkHlvT9yNtYTr4oNVNQ3e5GEtNnsOa2 RWukKF5+fTzyJOs1IsbZXRDOMQ8KVlz7KEXK8vz8/wiwYU1ZMhytWtF8HL6C1I1tnPrK5cn0p s/3WUb4lM7LR3KS3P8tzk+eJF6VzOv3N9ab149emDtHXplwK4IMhVjYg2fDUN5FSEuP005KT0 hi5so8QDsMJDHzWfkPhIJPaUxmb0YUOr9FoN8QCzcqXg1JrBf6BZdVbRSus+oRvA6ug6tJq+1 dsKhf2vsnBLjf3C75Oxf/wswIugIMhusT1OI2wvPkdbHkAa4p8IoMcE6of8cQDRr25fbZRo/l Umpe52UxLDp52rQ12Hr6n7gisK2ByVPkzfxRewskGbgmpgq2K6ULMCYBgJbx6NsPfTNBlEvIC FjP8Zjiwu/JaAOpwJNSOpD9rJoOKPmzJ+ULjHJPPvu/ulW3gxWCBmCvbsFrnfaZX/h2pZu03I fqm0AcYMQcF8OzvDPNxBaggG/OnrUJC1gAAMKA== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult Reviewed-by: Baolin Wang --- drivers/gpio/gpio-eic-sprd.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c index 7709226..7b9ac4a 100644 --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -568,7 +568,6 @@ static int sprd_eic_probe(struct platform_device *pdev) const struct sprd_eic_variant_data *pdata; struct gpio_irq_chip *irq; struct sprd_eic *sprd_eic; - struct resource *res; int ret, i; pdata = of_device_get_match_data(&pdev->dev); @@ -597,13 +596,9 @@ static int sprd_eic_probe(struct platform_device *pdev) * have one bank EIC, thus base[1] and base[2] can be * optional. */ - res = platform_get_resource(pdev, IORESOURCE_MEM, i); - if (!res) - continue; - - sprd_eic->base[i] = devm_ioremap_resource(&pdev->dev, res); + sprd_eic->base[i] = devm_platform_ioremap_resource(pdev, i); if (IS_ERR(sprd_eic->base[i])) - return PTR_ERR(sprd_eic->base[i]); + continue; } sprd_eic->chip.label = sprd_eic_label_name[sprd_eic->type]; From patchwork Mon Jun 17 16:49:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 1117150 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45SHHs3QHLz9sN4 for ; Tue, 18 Jun 2019 02:49:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbfFQQtk (ORCPT ); Mon, 17 Jun 2019 12:49:40 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:39909 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728326AbfFQQtY (ORCPT ); Mon, 17 Jun 2019 12:49:24 -0400 Received: from orion.localdomain ([77.2.173.233]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MNcYX-1i0FWj1aFn-00P21P; Mon, 17 Jun 2019 18:49:22 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org Subject: [PATCH 4/7] drivers: gpio: ep93xx: devm_platform_ioremap_resource() Date: Mon, 17 Jun 2019 18:49:17 +0200 Message-Id: <1560790160-3372-4-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560790160-3372-1-git-send-email-info@metux.net> References: <1560790160-3372-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:H4qj98BbLOw+mGWAX5h5qWEEin3AlwZ525u9DEJ1MMHd94IDpsn JscsLMjH9VX6d6SYtBFBdId1yTeaw2CfElhPfxH2txNR+JhcirfbfoKacaFi8XeJwblTC2l bGe6lnOQghIaZsiXlLZT7tJtkOT9x5Vy3wR3rV6/yLqoRyn6LTHgj8v7lLKfFBqBaf5ieKd MtYsu+Qm4qUGiYh3WQepg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:+rn2MCBHp40=:XmAcjRlG1LY/odOk1iCh8J XRlSIL6Xod1FloyyWAUvYMdROiw9lzRImHFuVpsiEFyukU4qVh2+Z1bF9YO98/ry9cTZTjQFB UwuKcsJzU9Pq4HLeCFi0bnN4yF6NdC/9WaAN/3h2nE+J8H1jpjRLYvseDvEwn2ROQoe7cvVjX /9robZRr70KzyDczwgob0FBg0KVwWLfQ0FMhP/GMISTC8OFzEdi8kOSyBdCAKrFqfiq2Mgn5a 0J82EAd34uRKCr5C48sPKI1cc4jlDSK2DbotgpOYFeHX9znHE0zHIZZoIVkrHCDlTcYIHuK2u X8GUmKZso6kj++J9PjXrXK/4hUI9UFZ+G1edYUq8O2/8ctXQQTXRNSGnXDlhylzilh7SUbP/4 8TMpKrEaMY0GD765Cj9RVeYtopMo25j4rMey9V8GnZ4ERWgVEwrds5Z3QKOW4d+k2LRIzDtAf VzJ45RsmaX/aekYZIkFvK57FkfgSlh/EyS1pHF91fmXwCkB5n4gTZqDj51HtwI+xtzw5RfnJe 90gNMH+GjHIuHsgjl8Ypq+BayMgGvP0dVr5/WJznyevj88CRFPN70y6waZZhB01qkZjM4dqWz uXnf1ECoclUMH2AHcQ5knI0rYZlqIS+DNI1YaRBsT/ELhiob3A5MWIz+Jyn/CO4PzyYJm2s5Z 2T0z0pbi//i66TSyBE0bcBxuf6O3GrVbN1W5M870k/Qy8hMGKh1oqpmbyGFRCbyGUKFxNRwWP F9jc5t5NRdJgcMODfkDwK8nB5wjGtWGFZe4Xcw== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-ep93xx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c index 71728d6..a90870a 100644 --- a/drivers/gpio/gpio-ep93xx.c +++ b/drivers/gpio/gpio-ep93xx.c @@ -393,16 +393,13 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, struct device *dev, static int ep93xx_gpio_probe(struct platform_device *pdev) { struct ep93xx_gpio *epg; - struct resource *res; int i; - struct device *dev = &pdev->dev; - epg = devm_kzalloc(dev, sizeof(*epg), GFP_KERNEL); + epg = devm_kzalloc(&pdev->dev, sizeof(*epg), GFP_KERNEL); if (!epg) return -ENOMEM; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - epg->base = devm_ioremap_resource(dev, res); + epg->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(epg->base)) return PTR_ERR(epg->base); From patchwork Mon Jun 17 16:49:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 1117148 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45SHHn1r1Jz9sN4 for ; Tue, 18 Jun 2019 02:49:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727670AbfFQQtg (ORCPT ); Mon, 17 Jun 2019 12:49:36 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:51765 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728417AbfFQQtY (ORCPT ); Mon, 17 Jun 2019 12:49:24 -0400 Received: from orion.localdomain ([77.2.173.233]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M3UIe-1hcMr23CWg-000dXq; Mon, 17 Jun 2019 18:49:22 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org Subject: [PATCH 5/7] drivers: gpio: grgpio: use devm_platform_ioremap_resource() Date: Mon, 17 Jun 2019 18:49:18 +0200 Message-Id: <1560790160-3372-5-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560790160-3372-1-git-send-email-info@metux.net> References: <1560790160-3372-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:Hmq0T1rLoSViSCrvNG5bce5XgCMtZroN6pQn0fzfUOYc/m7ESsm bEYHVCDm4BbxLfYpJ+9D9xQuOsYKqZT/UvdI0hdLGFqtXQcq4zqi9ZuNXDU9Iob8x5BKm9l p6Gj3RNCi0BSQkBjDYMHOsgO0WV4zuT8g8YYxYbdnxpUxuVrcsw2is9NJAQB2zHcZfyPjIC V4pIpMznfVJtFxutDz5zQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:6VQqVWWucyw=:nOAg7etMc3df8rPvyEq0L6 /7mb/J43FeGXhvcb549JCTP5nf3B0UEAflBOaUKVxYdXDgKOrq35M0GjBvE3LQr0EVtkHvEzs jYUuvWVORjyjWOEJBUkly8OrUlYY7jbyLCLkVi4CjBPHNlz8hgtXFb8yq6Yce2ePdALoOigP0 MHdETXf5Lu+V76476a2TXdLiA5AkQ38zNfD8t3XTQSiKJfs/A8hzlZLKPPmgyIGJYM940CU/G abyXJpubI8emb9NAezUg1I7ysyhB4dP3FyRsYdCogsiOFTTjSEwgdxm+HN54tMHZ9+TOpU1sz oLLKr+bFQzt6jI8UOrrRJrba+P3KzqNijst+rvv7WNzeBka4BReNoHRF3TEfofqGzn+O3EdDJ CaKVu9QnCQQzOp7cVWaOQZH1EGLy1YpSFQqKeyrtiEjB6giNsV9nggjUm7SlHKjeoAIdoxuOW +KPDqcE6rjWrW945HbNpdbiEJmoWvgzS9O7am8IhlWOoP9XZWkMX/TN/kufL9tUwmqKJ/jPY2 Bu32x0JlKvMciCk5mZlB5JG1O8zwIE3d5a4XA+GT9W0kNpkriDa5FDHZEsUKUr3hx8mjmxDGt dkxZBbk3S2HyyE08kLmz1ONgE4SOYmpG7M6JGVcWkAvBSwwsm4FVGVb3VKNHD6axyL7qHKSc1 BAFnlSp5TaYCUKRuT7QQ7C986u/v+xhWMb8zeBopU5h+TtIz/YY56cOh54F4Vq+7RUK2PNzHe Qcqu19WxpNO1hxPgWwcfiJpEXMTiuC8AknXy6g== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-grgpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c index 7df48e7..0937b60 100644 --- a/drivers/gpio/gpio-grgpio.c +++ b/drivers/gpio/gpio-grgpio.c @@ -329,7 +329,6 @@ static int grgpio_probe(struct platform_device *ofdev) void __iomem *regs; struct gpio_chip *gc; struct grgpio_priv *priv; - struct resource *res; int err; u32 prop; s32 *irqmap; @@ -340,8 +339,7 @@ static int grgpio_probe(struct platform_device *ofdev) if (!priv) return -ENOMEM; - res = platform_get_resource(ofdev, IORESOURCE_MEM, 0); - regs = devm_ioremap_resource(&ofdev->dev, res); + regs = devm_platform_ioremap_resource(ofdev, 0); if (IS_ERR(regs)) return PTR_ERR(regs); From patchwork Mon Jun 17 16:49:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 1117146 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45SHHc05M8z9sNR for ; Tue, 18 Jun 2019 02:49:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728293AbfFQQt1 (ORCPT ); Mon, 17 Jun 2019 12:49:27 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:49855 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728483AbfFQQt0 (ORCPT ); Mon, 17 Jun 2019 12:49:26 -0400 Received: from orion.localdomain ([77.2.173.233]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MJW5G-1hwedA01cG-00JpLw; Mon, 17 Jun 2019 18:49:24 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org Subject: [PATCH 6/7] drivers: gpio: janz-ttl: drop unneccessary temp variable dev Date: Mon, 17 Jun 2019 18:49:19 +0200 Message-Id: <1560790160-3372-6-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560790160-3372-1-git-send-email-info@metux.net> References: <1560790160-3372-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:pNpxM86V6H6J0TcFgvrzdFN95W8PwxpTys4a/PwbPV3+0P/1T+1 4E2SsDiG3q7DXA40mm32RU/zb/C+kYlIL6jY9dbAUT1Oh6c0CE9j3+qMamGrHlfiQLExw+S ij0YX0dpuWJGBQJYb/h2ax4qDkZHr0LtcHCfW3eAqhO6D5PPhGOcGjxoNBlf+P7CAsMnWBp znuO6rqRru7HzQIdsKJWg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:F6WI8Aw4+zI=:UFkM/Nvy868J8oErtbnGRB GYSrsHNTi2hwBlTTeXObBbLc89hmyrgTE5Gd2MQCM31+2jipp2u1Lm/9We0HOdC5Ewi1fJInb imXVon2jhUrXlSgTh/oHbZtFpjTv/PIWhHLZsxqdEsLDrX++LXNJmW/ensUQWeo0+XyVZEvmb Lr1E2rO6ombOu0AqEZwR+QgWQBxp0Vj0D+wF+6xQtr29CcZ8vcl/8rgzYTkWUk0avzRhuxIxJ 6i77ewAtTGCs9fYFFJd1HBP1gBkh9yaFB6e5bTgg0GY4YAvcEX8vKp/hf3OO0IWx/IUaB5N0o wngDUgGJ6xadabeRh6TGzVfrJcWeLoDHDYUNlUhwJIUN81D16/KX8KCuFnAcjcMbJsKu9YdHd eU3loGMvuFMzPMvvZyy+uk5mfAfV2j12gjtqy014c0MXTlu/d8DwY0nB6kBlYuTDKGeMz70CO gTKlK9aGdD/e9emAK/SiYVfEO4N6kpczVrc2XbITsViL9sm9RY3UUOr3ut3n94peqcDSQheiW 40MlIR3tgzAbUBHjKgKnRP9lGmVfrg4D9fZI76LGbR+fNmIGIylz88itzLTOx4zjCTbV64bb7 8AUFgjOIHyQ7wZ9PEdYRBcGw9EuIEGJvRaJGqjQ61VL+9yxmYkH1yxRNwihlqLV9/AEAMq314 HfT7qLvEH330J27CJKn37dDMDBDlduSAFFyBYG8Ca93yfwCZilAXL6iYDx+Aho2KbL0RjdrSx 1Ir3cOKAgKC5SFObih84B0C6EZMZV3y6VwYh4w== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org don't need the temporary variable "dev", directly use &pdev->dev Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-janz-ttl.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-janz-ttl.c b/drivers/gpio/gpio-janz-ttl.c index 6b5b5a8..cdf50e4 100644 --- a/drivers/gpio/gpio-janz-ttl.c +++ b/drivers/gpio/gpio-janz-ttl.c @@ -140,18 +140,17 @@ static void ttl_setup_device(struct ttl_module *mod) static int ttl_probe(struct platform_device *pdev) { struct janz_platform_data *pdata; - struct device *dev = &pdev->dev; struct ttl_module *mod; struct gpio_chip *gpio; int ret; pdata = dev_get_platdata(&pdev->dev); if (!pdata) { - dev_err(dev, "no platform data\n"); + dev_err(&pdev->dev, "no platform data\n"); return -ENXIO; } - mod = devm_kzalloc(dev, sizeof(*mod), GFP_KERNEL); + mod = devm_kzalloc(&pdev->dev, sizeof(*mod), GFP_KERNEL); if (!mod) return -ENOMEM; @@ -177,9 +176,9 @@ static int ttl_probe(struct platform_device *pdev) gpio->base = -1; gpio->ngpio = 20; - ret = devm_gpiochip_add_data(dev, gpio, NULL); + ret = devm_gpiochip_add_data(&pdev->dev, gpio, NULL); if (ret) { - dev_err(dev, "unable to add GPIO chip\n"); + dev_err(&pdev->dev, "unable to add GPIO chip\n"); return ret; } From patchwork Mon Jun 17 16:49:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 1117147 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=metux.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45SHHh5TdPz9sNm for ; Tue, 18 Jun 2019 02:49:36 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728483AbfFQQtb (ORCPT ); Mon, 17 Jun 2019 12:49:31 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:57613 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728487AbfFQQt0 (ORCPT ); Mon, 17 Jun 2019 12:49:26 -0400 Received: from orion.localdomain ([77.2.173.233]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MwxNF-1iZJEN1bcR-00yMlz; Mon, 17 Jun 2019 18:49:24 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org Subject: [PATCH 7/7] drivers: gpio: vr41xx: use devm_platform_ioremap_resource() Date: Mon, 17 Jun 2019 18:49:20 +0200 Message-Id: <1560790160-3372-7-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560790160-3372-1-git-send-email-info@metux.net> References: <1560790160-3372-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:iUF692x61ZLmpEW0cyk7fN8zcW0UYE6NQcxbLTjJriJAElwKTNe R8nuHt6HzR9DEAZVvZ8bupP06/M7gDcUdeCSM8bfmcqQmGRwO5y3oJxgPJJWaD18K/L+zLz xF5esffapY6LrK9w3lS2JPXeAPx+O7VO8aJddt3M4sYKGu0nRKp3MmfEnQd6Vl4/MrZJkz5 R/U/uB22KtRpWnqp9I44w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:0EfjCshqp9A=:ApvvgQiO6IU01FfSZtslzu /WbmaDnBcgnDieQ7FUOdGTn4BY9twHFbWXMoSJkZNIg8bK1sVfINLgb3LYUNPFohw1XgWTJC6 snsGp6Y72hWZ9d+5pFWJdbhU46FVNUwVzlI/kJ2CVvlYgLUwakZIdgztXTevWL11XlJaBDO7l o9szWMXH+DgaC9SACrJDBvnFfQf75nT6aQ0yrecIQUGMZSsRNVCsN7dPzDchPDnHJQf6UKxic IJdWE+8gCX7uom/dlkTJRczyj1dZHHMkQW7v6+VlY3v4ONTHK5n/4UKEVtCtUhLHcYlznHJtc BfS/zWIZyHOg9AxSkPTGc2UAcSM8V2uAlAprYP0HMkZxkO6cf7Wtg0uFIlxuVXk/8bNlmTqPJ b16dS7nHumju55aSUSKDuBeM4x+aIPGper2nuStFVCbj8M2Pd0ZXyE9GPhMzqiKshdDSbFdpF yhUblqaJm7P1P3utwh9934wlrYmlD40De3pwM8iVikfzxk8/A2LlC20WxFoFPAOLFPcbRd3NP TdW1b2RmLbBpp8owrGGmOgRxbUBAKOqniFxg/Pb2h5hBrOLifF213dA7gJdvQ1lWjl5EnrJKQ jsEaJxWe9PlPJKPcay3gSOc9QElOxTyccfwn2lDbRn2uoOBY69EcwICnVEwTx/fenRmcyDabl Xz8M4XJVKikzdg+YYEYymkher2mqlq0IKXTj/U2ZLvKMsFrfwn4G8J+HuDuU9F1C/vL+lNgEo ohVgT3gmaZCnRJODpEz7HuqyK82T2uieuWwDRw== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. this driver deserves a bit more cleanup, to get rid of the global variable giu_base, which makes it single-instance-only. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/gpio/gpio-vr41xx.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpio-vr41xx.c b/drivers/gpio/gpio-vr41xx.c index b13a49c..98cd715 100644 --- a/drivers/gpio/gpio-vr41xx.c +++ b/drivers/gpio/gpio-vr41xx.c @@ -467,10 +467,9 @@ static int vr41xx_gpio_to_irq(struct gpio_chip *chip, unsigned offset) static int giu_probe(struct platform_device *pdev) { - struct resource *res; unsigned int trigger, i, pin; struct irq_chip *chip; - int irq, ret; + int irq; switch (pdev->id) { case GPIO_50PINS_PULLUPDOWN: @@ -489,21 +488,14 @@ static int giu_probe(struct platform_device *pdev) return -ENODEV; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -EBUSY; - - giu_base = ioremap(res->start, resource_size(res)); - if (!giu_base) - return -ENOMEM; + giu_base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(giu_base)) + return PTR_ERR(giu_base); vr41xx_gpio_chip.parent = &pdev->dev; - ret = gpiochip_add_data(&vr41xx_gpio_chip, NULL); - if (!ret) { - iounmap(giu_base); + if (gpiochip_add_data(&vr41xx_gpio_chip, NULL)) return -ENODEV; - } giu_write(GIUINTENL, 0); giu_write(GIUINTENH, 0); @@ -534,7 +526,6 @@ static int giu_probe(struct platform_device *pdev) static int giu_remove(struct platform_device *pdev) { if (giu_base) { - iounmap(giu_base); giu_base = NULL; }