From patchwork Wed Nov 1 00:03:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 832791 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kUkR1+zn"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yRT306rVWz9sNw for ; Wed, 1 Nov 2017 11:03:56 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A4FF1D82; Wed, 1 Nov 2017 00:03:54 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 17498D80 for ; Wed, 1 Nov 2017 00:03:53 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id C6DA3555 for ; Wed, 1 Nov 2017 00:03:52 +0000 (UTC) Received: by mail-pg0-f67.google.com with SMTP id m18so590357pgd.13 for ; Tue, 31 Oct 2017 17:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=aLbuADGINW0ApkJLjwc/rYL4I6kcs+YAQ+W22GISc2Y=; b=kUkR1+zniiSbV/BrFEX0GrZOJzqaquK9nL9CHPnle9jkK7FLvMIC4eLkbe4Oy1qPEh zFW+XHR3NpveJxBtN6YmEydCk27+yyLwOYIlQjqwnILzKccy4bifIwGnFwCEcGaqAgSp 2fU5ah6YYWLKS7WkWKI7VH8glw7ctyzQulwth+SwlAr5/FRsO6HjBQBQnmYYdQKrd6cx a/Hq6APJu8XtcoOEX7RaDcNqPrjR96JG7ilw5dCQHAlsXU3xAM68CDYaD1vqkjPMdWvB lGnmRkIvr4LgJHLuysW7VLlL3nvH5pWZNAqJ0usFB582sNWzaQdN4sIc2e5HoBWDdyMZ 7/XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aLbuADGINW0ApkJLjwc/rYL4I6kcs+YAQ+W22GISc2Y=; b=mNdB2DJl7IqZ8PvpYC8oW4NpP+0fYznLwGvH3biEp09U5LW8ipdKmWRbkm6Aeo67pU dctfTC6GHfSF01jHZZA0zyVzcX8LR50j1J68wsqZY3FqJrKbDhgfq4JsK43WsZmEb7f5 Zh6+xy2c/VKaySj2IGnuJCADwxSaPXRpohfrMtS24RRfr2L6tYTC/P9qeuZcyMn9zh6l /CDqeUQACFKtAJcqDiB4/V4PxIJNIhGhUQAXJx42P84nZw6hDoVcjVPIZjvfABcGnId8 6fbZAXft2zrtQCVV0d3YYSrANa8tyX9uwVTexOW4yt0qqm8DM8lu+yOM63m+NsE3d1BN HxSQ== X-Gm-Message-State: AMCzsaU7A62TM4W6tdk52zt/Hsddh3TRkccqEBiYvHhKNInQAhQ7WoTW b4UfNGrsehs225aehonZbnGl8SsU X-Google-Smtp-Source: ABhQp+Q0Hbk6GKBWIg3V1V0ncOkmbks2ddNpwwJYAp98k/cVMRUvTdp/hHi6STTQ6Pxmx3TzwcKnDg== X-Received: by 10.98.80.21 with SMTP id e21mr4036854pfb.208.1509494632225; Tue, 31 Oct 2017 17:03:52 -0700 (PDT) Received: from localhost.localdomain ([24.5.191.4]) by smtp.gmail.com with ESMTPSA id p21sm5081164pfk.185.2017.10.31.17.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 31 Oct 2017 17:03:51 -0700 (PDT) From: William Tu To: ovs-dev@openvswitch.org Date: Tue, 31 Oct 2017 17:03:41 -0700 Message-Id: <1509494621-26976-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCHv2] acinclude: Fix SKB_GSO_UDP check. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The HAVE_SKB_GSO_UDP checks whether skbuff.h defines SKB_GSO_UDP. However, it falsely returns yes because grep matches SKB_GSO_UDP_TUNNEL. Thus, add space character '[:space:]' before and after it. Fixes: ad283644f0e4 ("acinclude: Check for SKB_GSO_UDP") Signed-off-by: William Tu Cc: Greg Rose --- v1->v2 remove using "grep -w" since -w is not POSIX --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 89f88ca8de75..c653a75a356b 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -768,7 +768,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ OVS_GREP_IFELSE([$KSRC/include/net/netfilter/nf_conntrack_helper.h], [nf_conntrack_helper_put], [OVS_DEFINE(HAVE_NF_CONNTRACK_HELPER_PUT)]) - OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h],[SKB_GSO_UDP], + OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h],[[[[:space:]]]SKB_GSO_UDP[[[:space:]]]], [OVS_DEFINE([HAVE_SKB_GSO_UDP])]) OVS_GREP_IFELSE([$KSRC/include/net/dst.h],[DST_NOCACHE], [OVS_DEFINE([HAVE_DST_NOCACHE])])