From patchwork Tue May 28 00:00:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 1105994 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Y96kuHQg"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45CYrB41vbz9s4V for ; Tue, 28 May 2019 10:00:08 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 085CDC2209C; Mon, 27 May 2019 23:59:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C419FC21C4A; Mon, 27 May 2019 23:59:55 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id BEF3BC21C4A; Mon, 27 May 2019 23:59:54 +0000 (UTC) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by lists.denx.de (Postfix) with ESMTPS id 24EE7C21C3F for ; Mon, 27 May 2019 23:59:54 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id n27so9803003pgm.4 for ; Mon, 27 May 2019 16:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kXd+7DBF0zIiL9mNaTx9YarJNh5SzFJYzFYYTrxixIk=; b=Y96kuHQgtBelZXB7SvSDf71oIvG6t2A/jappQ+xdHYkl667/85BXM6vQsQfZ1Sjhui ipiQiikuNeL6sfS4IOvL98MiAbK3NYjdkC2svxumyj3mIo69rE+DU43tV9s4+EF/CbzP /Wt49L6a96b8TWWNJVWMr1y9o8OYbPPIaOdAspzKns27dDOuXmLFwoWlHkTD0HpPHiJn BBST0UjSTwHD2DhVde3mPthxJJ0/yvdnQ1Rxs0aQdpb74EkuO+zxaTw0HVrYMMwbG8Th ycbpr6zE0WT+p2Cl7K5x5dM6anibaEjBoUBYi5j5aENWyipCrDs6EktpQ5RgMQ7uphDV LgOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kXd+7DBF0zIiL9mNaTx9YarJNh5SzFJYzFYYTrxixIk=; b=nzw7t/ZRFC7o5o0WCAy6cJDS3EmkNicXkyeXt+X0oKggM9zbytGLHsd9FKOHiWPdFE E+aC6RrU5kCZJ9OtKr21cxO7yMwUghdzm+7oZr0RhJpdIQyvWfTXRb+oGTGw+3tl38Y4 xDgZyQxNcyuIz9jNJX86qpOOvUjzXentfVsAevZyUygUqey3ZWfMVgD8fyxfLS4C+BQK 0axH2wbwzVelvdDFHFJx6BM8LnqIHxUObJvLTIYnUUWm6ny+wWolQeeJFKV+WQ10bQrv sy6u9apMQAnzVXAG5mYh628iWiKffFq905ZJbNDpUbGD1Nhls9p9D8wAXBClSpVrKjqC hX2g== X-Gm-Message-State: APjAAAX1DrPFjRfa+1vaH4GtkyE6jYYBNLYW/xTSGJwN8u/s3A4gUZqP 0CvyQkfczRyUyRCnHaoLO6kF9g== X-Google-Smtp-Source: APXvYqw4t42qZPc0w1r1n/gY7Urw9cTvrNKhTB2GbJe1bQZsZZ4ylcIDY17fB2LPBGncdKud+oSBsw== X-Received: by 2002:a65:620a:: with SMTP id d10mr4312749pgv.42.1559001592405; Mon, 27 May 2019 16:59:52 -0700 (PDT) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id v39sm841045pjb.3.2019.05.27.16.59.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 May 2019 16:59:51 -0700 (PDT) From: AKASHI Takahiro To: xypron.glpk@gmx.de, agraf@csgraf.de Date: Tue, 28 May 2019 09:00:35 +0900 Message-Id: <20190528000035.20425-1-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v3] cmd: env: print a message when setting UEFI variable failed X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Error message will alert a user that setting/deleting a variable failed. Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich Schuchardt --- Changes in v3 (May 28, 2019) * change messages as Heinrich suggested Changes in v2 (May 24, 2019) * change a message to "Out of memory" * add more error messages --- cmd/nvedit_efi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c index 2805e8182b41..ff8eaa1aad2d 100644 --- a/cmd/nvedit_efi.c +++ b/cmd/nvedit_efi.c @@ -373,6 +373,8 @@ int do_env_set_efi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) for ( ; argc > 0; argc--, argv++) if (append_value(&value, &size, argv[0]) < 0) { + printf("## Failed to process an argument, %s\n", + argv[0]); ret = CMD_RET_FAILURE; goto out; } @@ -381,6 +383,7 @@ int do_env_set_efi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) len = utf8_utf16_strnlen(var_name, strlen(var_name)); var_name16 = malloc((len + 1) * 2); if (!var_name16) { + printf("## Out of memory\n"); ret = CMD_RET_FAILURE; goto out; } @@ -392,7 +395,12 @@ int do_env_set_efi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, size, value)); - ret = (ret == EFI_SUCCESS ? CMD_RET_SUCCESS : CMD_RET_FAILURE); + if (ret == EFI_SUCCESS) { + ret = CMD_RET_SUCCESS; + } else { + printf("## Failed to set EFI variable\n"); + ret = CMD_RET_FAILURE; + } out: free(value); free(var_name16);