From patchwork Mon May 20 11:32:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 1101946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-501181-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="bFUEo8ce"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 456xbT5dm6z9sBK for ; Mon, 20 May 2019 21:33:09 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=GVCq2Y4r97O9uHexopBC7+JovAftDYQ4vMUFIh/jErBU7n2M2ZStg AirN4UVjFfkD3nSSUnAoF70ZJdoOxfc78gtqLO4lR/w7rW+TUN3a8Y9VO8lDwUZ8 QV28QTAf/Hucf5lnwM8f+z2aOuwo/EWDqh3m5RDUuq3X5Qeh95DNNg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=WbVxgS8Op81Y9R2XANNJ91nOmB8=; b=bFUEo8ceGbMRe1kIf1wO PeQBI2DSPJ6ICZ5Nq3O8xm6PfUZ3jq5igzwwW2vX8RZsMeScRhWyH0UXpxWjYFfg dxJxDqYPsfsB2+Sh+56kjVpk0TO/vttxq4H0W4EvZyNmfPCBtjvk+19yQwH2OOUJ yXHp6uz9rzmIMQZktNwL4cc= Received: (qmail 128487 invoked by alias); 20 May 2019 11:33:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 128478 invoked by uid 89); 20 May 2019 11:33:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT autolearn=ham version=3.3.1 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 May 2019 11:33:01 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id B48DF68B for ; Mon, 20 May 2019 13:32:57 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yN9fq8-gZSjM for ; Mon, 20 May 2019 13:32:55 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 9B5DF687 for ; Mon, 20 May 2019 13:32:55 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id x4KBWqXs007580; Mon, 20 May 2019 13:32:52 +0200 (MEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Subject: Reject -mx32 on Solaris/x86 Date: Mon, 20 May 2019 13:32:52 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Inspired by one of Iain's patches for PR target/82920, this patch rejects -mx32 on Solaris/x86, too: x32 won't be implemented on Solaris and the failure if one tries to use it isn't very helpful otherwise: $ gcc -mx32 -o hello hello.c In file included from /vol/gcc-9/lib/gcc/i386-pc-solaris2.11/9.1.0/include-fixed/sys/feature_tests.h:32, from /vol/gcc-9/lib/gcc/i386-pc-solaris2.11/9.1.0/include-fixed/stdio.h:24, from hello.c:1: /usr/include/sys/isa_defs.h:461:2: error: #error "Both _ILP32 and _LP64 are defined" 461 | #error "Both _ILP32 and _LP64 are defined" | ^~~~~ Bootstrapped without regressions on i386-pc-solaris2.11, installed on mainline. Rainer # HG changeset patch # Parent d206c777312bc2a8211d734e485031f191dce352 Reject -mx32 on Solaris/x86 diff --git a/gcc/config/i386/sol2.h b/gcc/config/i386/sol2.h --- a/gcc/config/i386/sol2.h +++ b/gcc/config/i386/sol2.h @@ -55,7 +55,8 @@ along with GCC; see the file COPYING3. #define CPP_SPEC "%(cpp_subtarget)" #undef CC1_SPEC -#define CC1_SPEC "%(cc1_cpu) " ASAN_CC1_SPEC +#define CC1_SPEC "%(cc1_cpu) " ASAN_CC1_SPEC \ + " %{mx32:%e-mx32 is not supported on Solaris}" /* GNU as understands --32 and --64, but the native Solaris assembler requires -xarch=generic or -xarch=generic64 instead. */