From patchwork Tue May 14 20:25:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 1099700 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z+wIYTnI"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 453TjQ5nt1z9s3Z for ; Wed, 15 May 2019 06:26:18 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 98FF822C1A; Tue, 14 May 2019 20:26:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 40jRe2rLn6DY; Tue, 14 May 2019 20:26:13 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id CC5583019D; Tue, 14 May 2019 20:26:13 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 9D9441BF3FF for ; Tue, 14 May 2019 20:26:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9982C87CDE for ; Tue, 14 May 2019 20:26:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BEq9hC-1uuoy for ; Tue, 14 May 2019 20:26:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by hemlock.osuosl.org (Postfix) with ESMTPS id D358287CDA for ; Tue, 14 May 2019 20:26:11 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id k8so441188lja.8 for ; Tue, 14 May 2019 13:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1eQLnimF8lL7hmg1f3/4KPaKwY0pcqdXuTuwnIAlwTU=; b=Z+wIYTnI78RXrXDA+SEHHX5/tZCfVD2QQoi441IuFZ2wT2nwqPFeD3sKw+Qvhm7wmF DXbElFlPebMWNUPgVD4vRev5jZCKlUs6L2hvZahm1PtIJf1da+ul+lbm8poqH6wYrnEW HwIY4gN0IB0ykEiwS/Ek2krVZ6NI+VfsZblSIW2Q7I3Ln7kCtmGgbr+4D/y+opKYe3Hu SU1eoDoSfFxpfkDEmniOO6GMruDp4x/3M/yuesQ53+MlsnSokFQuGcdULLb5mxwF5c/L Zsqpizy5tegiZVcFwXMYJDTYSra1SMFntpxZmp5dh0sOD0jtBuoVBNWNlDwaonbLQ48z rVIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1eQLnimF8lL7hmg1f3/4KPaKwY0pcqdXuTuwnIAlwTU=; b=QJdU0qGIe563XOARv+wuGr2/gygRTs8cByYlL+Jc2ZEdSmTKZXrj0wZaD5hL8FG2WE /KZOWpaBVNlBcNyMdlr12hpjJZgqoOr79J571f9J6wCO8xgI1hOyOx2TnoN9skEcK8m9 9l6yIO2JDfF3eifsrJTFrCt74/Mp/B2gxmlRLovVYfCab/o2NT4mIyNhmImi64v8APRR PfmElLgd8BR8y+pPua5WrMVyywGSvp5Syk7seTQ+tDMTQSjGhzSi/q6AWai3ZsKxsZtX dVLueVpy2A+Fmk9fTrVUgBIcmrmS2jeT0kJ0KXr35+lmK20jdf0810bh9H9cHCkAnS0C BWAA== X-Gm-Message-State: APjAAAUiJ1JvBJwd+nkPmiyXF37hyqwhOIhDIVJK6/OHtfAmU5UJNoxf 2CwtyMQoQB5+90QnFQv2vrCt+c3S X-Google-Smtp-Source: APXvYqzqtuI4y513j5u7nmo/gQyKbumRNUtAI6vsH7EGY9+4hpFSDZhUH+Vo1valJHZiuxrefISZ0Q== X-Received: by 2002:a2e:84ce:: with SMTP id q14mr18392712ljh.80.1557865568826; Tue, 14 May 2019 13:26:08 -0700 (PDT) Received: from localhost.localdomain ([93.75.250.209]) by smtp.gmail.com with ESMTPSA id u8sm3970679lfi.83.2019.05.14.13.26.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 13:26:07 -0700 (PDT) From: Vadim Kochan To: buildroot@buildroot.org Date: Tue, 14 May 2019 23:25:47 +0300 Message-Id: <20190514202547.18076-1-vadim4j@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/lynx: fix build with libidn X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vadim Kochan , Mario Lang Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" In case of BR2_STATIC_LIBS=y the linking with libidn fails because linker can't resolve libiconv symbols needed by libidn. Fix it by required LIBS for libidn generated by pkg-conf. The issue can be reproduced with the following defconfig: BR2_x86_i686=y BR2_STATIC_LIBS=y BR2_PACKAGE_LIBICONV=y BR2_PACKAGE_LIBIDN=y BR2_PACKAGE_LYNX=y Fixes: http://autobuild.buildroot.net/results/23a421e15c32b17ff2f69f183a2e8620ecb93316/ Signed-off-by: Vadim Kochan --- package/lynx/lynx.mk | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/package/lynx/lynx.mk b/package/lynx/lynx.mk index 3ac5b4cabf..b6cc1b2b91 100644 --- a/package/lynx/lynx.mk +++ b/package/lynx/lynx.mk @@ -23,7 +23,7 @@ endif ifeq ($(BR2_PACKAGE_OPENSSL),y) LYNX_DEPENDENCIES += host-pkgconf openssl LYNX_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr -LYNX_CONF_ENV = LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl` +LYNX_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs openssl` else ifeq ($(BR2_PACKAGE_GNUTLS),y) LYNX_DEPENDENCIES += gnutls LYNX_CONF_OPTS += --with-gnutls @@ -36,4 +36,11 @@ else LYNX_CONF_OPTS += --without-zlib endif +ifeq ($(BR2_PACKAGE_LIBIDN),y) +LYNX_DEPENDENCIES += libidn +LYNX_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libidn` +endif + +LYNX_CONF_ENV = LIBS="$(LYNX_LIBS)" + $(eval $(autotools-package))