From patchwork Mon Apr 15 13:36:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1085639 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="tyT2kWjz"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44jV133YW3z9s55 for ; Mon, 15 Apr 2019 23:37:25 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 16F9EEE8; Mon, 15 Apr 2019 13:37:06 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CA98EED3 for ; Mon, 15 Apr 2019 13:37:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1D53C2C3 for ; Mon, 15 Apr 2019 13:37:04 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190415133702euoutp029f7649886a701ebf5f9e738a84641b54~VqVN8jpcF2483124831euoutp02Y for ; Mon, 15 Apr 2019 13:37:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190415133702euoutp029f7649886a701ebf5f9e738a84641b54~VqVN8jpcF2483124831euoutp02Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1555335422; bh=7X0qkciHfJRSBDgV3z95Qi6vVbVk4bYqapir/SgVgYw=; h=From:To:Cc:Subject:Date:References:From; b=tyT2kWjznqP5Z+gWt2tqwbldviBq4abuJQnPc1H/l2aAoiaCcE01YFvcbdsayaAv5 RLaQf5XHR9ALtwYlduIgvQjPIlhSjAVSy7ClTRODG6AFwo2rmG2hnRF2vQxIG+yZaT q7drJHqnCYbcsW6R4+7qGBIfWhYHAc/+peN6BOkE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190415133701eucas1p1360e4df604d0a5c2169df59e1059ce13~VqVNREmJo2343623436eucas1p1K; Mon, 15 Apr 2019 13:37:01 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 12.7B.04298.DF884BC5; Mon, 15 Apr 2019 14:37:01 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190415133700eucas1p153fb27427787e44b0ceeda092090ac74~VqVMZXs_S2351823518eucas1p1_; Mon, 15 Apr 2019 13:37:00 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190415133700eusmtrp191f7a27562b2b38bd81ae20b6a7ab732~VqVMJ6Fbu1905119051eusmtrp1G; Mon, 15 Apr 2019 13:37:00 +0000 (GMT) X-AuditID: cbfec7f2-f2dff700000010ca-87-5cb488fd4d49 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 09.A7.04140.CF884BC5; Mon, 15 Apr 2019 14:37:00 +0100 (BST) Received: from localhost.localdomain (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190415133659eusmtip1b330c0ca3d8ca86042b4591b0ca42677~VqVLu-7uJ2064220642eusmtip1h; Mon, 15 Apr 2019 13:36:59 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ben Pfaff Date: Mon, 15 Apr 2019 16:36:54 +0300 Message-Id: <20190415133654.5744-1-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsWy7djPc7p/O7bEGOz9K2rx680DdotXkxsY La60/2S3mPvpOaMDi8ezm/8ZPZ5f62HxeL/vKptH35ZVjAEsUVw2Kak5mWWpRfp2CVwZbx/a Fsxiq3hy6jxzA2MjaxcjJ4eEgIlEw8tLTF2MXBxCAisYJa5tnsQK4XxhlNjX2MEM4XxmlGi5 uJoRpqXj+AaoquWMEsuu/WGEcL4ySpzae5sFpIpNQEfi1OojYB0iQB3Lpn5jA7GZBfwlFk27 BxYXFrCS+Ht2GpjNIqAqMXPzJrCjeIHi5xfvZILYJi+xesMBsDMkBLawSWy7/4gdIuEi8fj1 OmYIW1ji1fEtUHEZidOTe1gg7HqJ+y0vGSGaOxglph/6BzXVXmLL63NADRxAF2lKrN+lDxF2 lNi04TQTSFhCgE/ixltBiJv5JCZtm84MEeaV6GgTgqhWkfh9cDnUBVISN999hrrAQ2Jx634w W0ggVqKl7QPbBEa5WQi7FjAyrmIUTy0tzk1PLTbMSy3XK07MLS7NS9dLzs/dxAiM8tP/jn/a wfj1UtIhRgEORiUe3guVm2OEWBPLiitzDzFKcDArifA6pmyJEeJNSaysSi3Kjy8qzUktPsQo zcGiJM5bzfAgWkggPbEkNTs1tSC1CCbLxMEp1cDIdMtivZexQd5ClRXb2hck9m7+8/Ro5wfn rtPd52WnHPXYULXB5Qr3yj9v2D1E2ZN5TI/Vfmlk/z5l1WdNp72uZpcdH0xwfmV1VnPl43fW 9TdDbXwTuLfbbrTcPNvgj9os1aITMy/4ObWpz15p/XGxavddt7YDcoxzim3kE0x8pl4Qc76r /mWeEktxRqKhFnNRcSIAreydl+4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPLMWRmVeSWpSXmKPExsVy+t/xu7p/OrbEGBw8K2bx680DdotXkxsY La60/2S3mPvpOaMDi8ezm/8ZPZ5f62HxeL/vKptH35ZVjAEsUXo2RfmlJakKGfnFJbZK0YYW RnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZbx/aFsxiq3hy6jxzA2MjaxcjJ4eE gIlEx/ENYLaQwFJGiUctbBBxKYkfvy5A1QhL/LnWBRTnAqr5zCix5/FZsCI2AR2JU6uPMHYx cnCICJhJbPlnCRJmFvCX2Dn5KTOILSxgJfH37DRGEJtFQFVi5uZNYDN5geLnF+9kgpgvL7F6 wwHmCYw8CxgZVjGKpJYW56bnFhvpFSfmFpfmpesl5+duYgQG1rZjP7fsYOx6F3yIUYCDUYmH 90Ll5hgh1sSy4srcQ4wSHMxKIryOKVtihHhTEiurUovy44tKc1KLDzGaAi2fyCwlmpwPDPq8 knhDU0NzC0tDc2NzYzMLJXHe8waVUUIC6YklqdmpqQWpRTB9TBycUg2M25LcG1cJ/zgYsZOp cVPpzSnM8rdZxB9UL5tbPiPZnflDpRuX7TUmtekbChfUSl58KS2rv/xdxAvRx4V7Tzn8klv1 Q/PJooM/ps5wT1WP3Kp2asXFdqPVE5dO3C0VLp/j7nfiryNTPY9KnPtP3fWn52gXFezanH69 4KF7Kdsyh7tXVWV5jkXuU2Ipzkg01GIuKk4EAEC4SNVCAgAA X-CMS-MailID: 20190415133700eucas1p153fb27427787e44b0ceeda092090ac74 X-Msg-Generator: CA X-RootMTR: 20190415133700eucas1p153fb27427787e44b0ceeda092090ac74 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190415133700eucas1p153fb27427787e44b0ceeda092090ac74 References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH] checkpatch: Fix handling of line endings. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Unlike manual splitting, 'splitlines' correctly handles different line endings. Without this change script fails to check files with '\r\n' endings treating the whole patch as a header. Signed-off-by: Ilya Maximets --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 369911960..441eaa807 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -725,7 +725,7 @@ def ovs_checkpatch_parse(text, filename, author=None, committer=None): reset_counters() - for line in text.split('\n'): + for line in text.splitlines(): if current_file != previous_file: previous_file = current_file