From patchwork Tue Apr 2 13:51:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Awais Belal X-Patchwork-Id: 1074473 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::43e; helo=mail-wr1-x43e.google.com; envelope-from=swupdate+bncbdtohouhxydrb7orrxsqkgqe6rejc3a@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="BYBEwtVp"; dkim-atps=neutral Received: from mail-wr1-x43e.google.com (mail-wr1-x43e.google.com [IPv6:2a00:1450:4864:20::43e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44YVxv0LV9z9sLt for ; Wed, 3 Apr 2019 00:52:01 +1100 (AEDT) Received: by mail-wr1-x43e.google.com with SMTP id u18sf10785749wrp.19 for ; Tue, 02 Apr 2019 06:52:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1554213117; cv=pass; d=google.com; s=arc-20160816; b=W4nwDL2uRon8wI2p2vs6niOwJH956V2Wj53Bf1g1gKds9LOtO8iJg7Ef4gZMMA/RxU fg0q05TIEiBliAex3aBmYODS1wWB+2F/0aFgg8awwYJBlepaThE6I4qKVSQoyPTzW+hZ 8k7hcWxj3ITx1EB4fXeZNjYLyjq32CSrctZKIksoP/Fk6gnt7qr2v84YF5VMCcaF5aMr 8jKVoSLPgedUldmOzD0sMWLrp7h1sD+OehzcWEgOx8JbBFyfhOB49noudSVUdnb7xG/o uD0VjyqEX5ycmnDc0z7z+7IJKD07dXWP4kvdOIsbyPfX9oDcXRqVcwv/9TJxx7ctehjj t/Rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:to:from:sender:dkim-signature; bh=C5ZdMGYPedBdMEAkhVpkV8xQhEZxK4RnjyYqd3fbZOc=; b=zapa9f3pjdFyL/np+IPVOAfwy/Cm2s7lkwjGKVW18zVop58SwpQuBpMvnABHTxZruq Mz56Dsuz/XJdWnHUOnwMzFY5MDYHM9YsdX2pMnoV/cFzC8XsT/KFFjUk1Kg/K+3jJcf7 NhV1tve+87rAf+O+P7HPuDf+nrwdtHW3T87kJpUtWqNbc78VR3LqSeyxxQ9l2QhfLT0B EkBznnM/IyRp4Y7Bc0FUZIYL9VfNmkljZ+PB/d5TvaSV6TGVfaK6B8oDZCdjwNFDfQ+u p6iek7JilO3Td6yf7JZEYKglkGR9LJuOm4/FwnRgxKFU+ubUS/43KGMoTfYiqy5EesoX ezIw== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of awais_belal@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Awais_Belal@mentor.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=C5ZdMGYPedBdMEAkhVpkV8xQhEZxK4RnjyYqd3fbZOc=; b=BYBEwtVpIY4ytt8/cA8zhtPLAhJXrqHoXh4qh1Qt2CQtqI9Avj0quBluIeW97iQ0NL VbGMV2DFsjbYuy1CK4dVfcJQS9UCMBcbf2b1hL6Fv/9WpyhZtJxCT6IQZF5KEzcXrm6f LubCpNRe/s6s38laljbiDyFpfr1llBoQZuE/I238VPoSN4Exz5OuYzzlaGGWjQkIc+dU aQp0LAdfBbW6jiWC/sgUWQKDdDNY1J61h7VOFx7hqKaMNEO8EaMMpW2LOQ7D2AzHDZin 73hWB+PUFiCwH3gU8kzOpyzYfj+bfDFu1NHg+Abl+rwtTDBXBTDBN02HlUEvGdHWuMVB 0SQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=C5ZdMGYPedBdMEAkhVpkV8xQhEZxK4RnjyYqd3fbZOc=; b=ZIs2HMutreptksrEecFJveX73jPxgnFryVDWZ8E/R/yLSWp7L6K3NmgnoJyE+6Qe8W fQ7QcmzRnKjJ2ZIbILOWRUvaJgyUZ+bLrfkwvMgY08kGr64t2WSDw81ZtTxWT6KGCtMi ifMVGwpL8xh52rX4fYlmrg1Ezxi9Og7bBMICYqOhpREJCsvodnuByZr4VQ7DzKX7mSQp dQ5MD1Vf+6g++0p+Rs9fg6E6sj3YOQ+bnyfWzdhGrPGZP/mjDv2tdXi168AFf7CDpwpm CGin6umppA4xquZIMxNLl5inAf0tLF8ADMByoEztXabl3HvhFEBYYgUnQMqVuMLjzEzF vmAg== Sender: swupdate@googlegroups.com X-Gm-Message-State: APjAAAWXzmbu8n3eQYGbG1h0qObbUN7keBPWZAbk6xCjSiFCrQYbvgAJ Ipeq7z7lsOCHBOmmA5GCbaw= X-Google-Smtp-Source: APXvYqyix0zjAwycgSmjIah4bgMcGF0tawQLiGNZmgfvcWyhD4/el8WJdFu32Pk2si4Azv3bMHshoA== X-Received: by 2002:a1c:e0d6:: with SMTP id x205mr3906781wmg.28.1554213117397; Tue, 02 Apr 2019 06:51:57 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a1c:b406:: with SMTP id d6ls351217wmf.2.canary-gmail; Tue, 02 Apr 2019 06:51:56 -0700 (PDT) X-Received: by 2002:a1c:1f10:: with SMTP id f16mr1514058wmf.17.1554213116897; Tue, 02 Apr 2019 06:51:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554213116; cv=none; d=google.com; s=arc-20160816; b=pMin7NlWYolAPBIRzU8k8iIyjbWIbJ7gw3YYYSfX97jG7GMGA4VFC0dgXL3h6E6JK4 sbvDX0kPisCQjb/bq/FPQJTyJESMC7GBxyFbg7rlmDiBs1SfZFaKhDYSihvYnuI/IrDi r+A73jMz4rsQijW/6hPCfWn758lh16wqDz3hp1XmnZtR6dqlQPRsm2McZF/8ApOPZuYc MUc1Yz2+QrHK51C9mJTn0bdKbRhVqqQlaHzFBy9oPQnCBl0jxICqBVb6hDFt+ZFXSvD8 1OjWzEj9ftToCLfbnLUd+SUbMc59M7ZHS3GAlqI/HoGYhmVSqgvcE+bOOJuzjRvgnpdU RAfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:subject:to:from; bh=p625S8rj18EufNoLHgeUXsmgqqxWc6N9rSZQoEXxuqc=; b=kjPkKLckMsYQTm75WpklXHxAI69J9XguFNDimoA0xupH5GvNjuy7SC+5JqH/m4Mall WHP89UOg9uI0APD+QCgrmxC+2OtO3AG+ZiiBSKzoR+5XhD8REgbRzGpXLKWJElJQNWzf JJ/2h+EIRToykmb0vrtWgC13S9ldCcrIhpdz54T+du4g78MssFR63MENL8edzOXg7u4V IF38+NyylQom4Vty7rftgQe1KYDL7JOInQBwQ7+5LLpmGMrBccr3wH3rjFxvt9t7Yu/O E5ndfa3YzoiIcrJ/vqn1XaRFL4o1P2J9Jg6hkxfiIUrSgM5ml6w6/ja5/UBUFm5J+vwl bcDw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of awais_belal@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Awais_Belal@mentor.com Received: from relay1.mentorg.com (relay1.mentorg.com. [192.94.38.131]) by gmr-mx.google.com with ESMTPS id t14si220599wmj.4.2019.04.02.06.51.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 06:51:56 -0700 (PDT) Received-SPF: pass (google.com: domain of awais_belal@mentor.com designates 192.94.38.131 as permitted sender) client-ip=192.94.38.131; Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hBJpT-0005yw-Gv from Awais_Belal@mentor.com for swupdate@googlegroups.com; Tue, 02 Apr 2019 06:51:55 -0700 Received: from P7520.pkl.mentorg.com (137.202.0.90) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 2 Apr 2019 14:51:51 +0100 From: Awais Belal To: Subject: [swupdate] [PATCH] client: simply return if async start fails Date: Tue, 2 Apr 2019 18:51:40 +0500 Message-ID: <1554213100-14864-1-git-send-email-awais_belal@mentor.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Original-Sender: awais_belal@mentor.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of awais_belal@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Awais_Belal@mentor.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The client should return after cleaning up if async start fails for any reason otherwise the caller will block because the client app will keep on waiting for the mutex which will never be triggered. Signed-off-by: Awais Belal --- tools/client.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/client.c b/tools/client.c index 6dd378c..a324be7 100644 --- a/tools/client.c +++ b/tools/client.c @@ -113,8 +113,12 @@ static int send_file(const char* filename) { rc = swupdate_async_start(readimage, printstatus, end, dryrun); - if (rc) + if (rc) { printf("swupdate_async_start returns %d\n", rc); + pthread_mutex_unlock(&mymutex); + close(fd); + return 1; + } /* Now block */ pthread_mutex_lock(&mymutex);