From patchwork Wed Apr 29 08:37:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Reutner-Fischer X-Patchwork-Id: 465935 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id A6409140332 for ; Wed, 29 Apr 2015 18:37:24 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=sXF/5tDd; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E8430A2780; Wed, 29 Apr 2015 08:37:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TuvR0uFFyP5R; Wed, 29 Apr 2015 08:37:20 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 005DFA267C; Wed, 29 Apr 2015 08:37:19 +0000 (UTC) X-Original-To: uclibc@lists.busybox.net Delivered-To: uclibc@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 4487F1C21D3 for ; Wed, 29 Apr 2015 08:37:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D126190DC1 for ; Wed, 29 Apr 2015 08:37:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id prKrQbiBC2eJ for ; Wed, 29 Apr 2015 08:37:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-la0-f50.google.com (mail-la0-f50.google.com [209.85.215.50]) by whitealder.osuosl.org (Postfix) with ESMTPS id 39CA190DBB for ; Wed, 29 Apr 2015 08:37:16 +0000 (UTC) Received: by labbd9 with SMTP id bd9so14653426lab.2 for ; Wed, 29 Apr 2015 01:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=6+xJgXVFORvxD0sfuqR3wXevNmwWNXOcDBqmB1DBCec=; b=sXF/5tDdUJhspiiD2oNtUP5LcnW4agEZmCCDB8+6XvDOVmGFgooCYgJsJrLi4C4fqt oeL4u9DbGKEZE06Wx1afkdj0brF/8M/avMXS+ZQ7DQ+xTNuuN5V8PHeR57TNpP1IMk/C qgjG8C6Hu+kmd2/2eipWs6NnnYFOIQeOMMvQimTN6A5qdLokB34eZS3oruxxIQwKJi5+ PRrcOFIlWLzTsXfbn+EF8BNipvGPhxJvdLF9incmHqxUdruYAHgsw3HwpuCay9Vb45Xc dI/1++e99Qn0gD6F5GUejTEtC4znnI6Y2Ocstu2yMt7N6rYuR7SLVu2c9jxa3wW/Toj7 zr+g== MIME-Version: 1.0 X-Received: by 10.153.5.8 with SMTP id ci8mr18099214lad.62.1430296634266; Wed, 29 Apr 2015 01:37:14 -0700 (PDT) Received: by 10.152.90.230 with HTTP; Wed, 29 Apr 2015 01:37:14 -0700 (PDT) In-Reply-To: References: <20150427092110.GF8309@waldemar-brodkorb.de> <64AC6559-D358-40F8-8543-1C2D6DEEE01E@gmail.com> Date: Wed, 29 Apr 2015 10:37:14 +0200 Message-ID: Subject: Re: [Buildroot] uClibc build verbosity control From: Bernhard Reutner-Fischer To: Vineet Gupta Cc: "buildroot@busybox.net" , Alexey Brodkin , uclibc-mailing list X-BeenThere: uclibc@uclibc.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion and development of uClibc \(the embedded C library\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: uclibc-bounces@uclibc.org Sender: "uClibc" On 28 April 2015 at 08:38, Vineet Gupta wrote: > On Tuesday 28 April 2015 01:46 AM, Bernhard Reutner-Fischer wrote: > > On April 27, 2015 11:21:10 AM GMT+02:00, Waldemar Brodkorb wrote: > > >>Hi Vineet, >>Vineet Gupta wrote, >> > > >>> Hi, >>> >>> uClibc verbosity control V=xx is different from other mainstream > > >>projects: namely Busybox and Linux kernel. These are kbuild-based, fwiw. > > >>> To print full cmdlines (when debugging obscure toolchain issues) we > > >>need to pass V=2 whereas kernel/busybox take V=1. > > >>> >>> Can this be changed (I can provide a patch) assuming this doesn't > > >>break existing scripts upsetting some people. > > >>> >>> My issue is specifically when using likes of Buildroot, there's no > > >>obvious way to get the cmdlines of uClibc and/or other projects (unless >>there's some obvious way I'm missing). > > > Just add V=2 to make flags used for uclibc? > > Still requires manually hacking some Makefile etc, since V=xx is tyoically given at cmdline once for entire build. but anyway. > > > >> >>Good idea. Send a patch. I am pro. > > > I found the terse output with just defines rather neat. > If there is consensus that the current V=1 has no benefit then we can drop it in favour of just silent 0 and fully verbose 1. > > > No, the idea is to keep both V=1 and V=2, but make them like other projects. > e.g. in kernel build, V=2 prints the single liners, while V=1 prints the verbose cmdline, > While in uClibc it's the other way around. Same with Busybox AFAIKR. > > Simple patch below addresses that, please consider applying. Patch did not include help-text adjustment nor locale generation verbosity. Fixed thus, please try current master. thanks, diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk index ce9b2b4..402966c 100644 --- a/package/uclibc/uclibc.mk +++ b/package/uclibc/uclibc.mk @@ -359,6 +359,13 @@ UCLIBC_MAKE_FLAGS = \ UCLIBC_EXTRA_CFLAGS="$(UCLIBC_EXTRA_CFLAGS) $(TARGET_ABI)" \ HOSTCC="$(HOSTCC)" +ifeq ($(KBUILD_VERBOSE),0) + UCLIBC_MAKE_FLAGS += "V=0" # default anyway +endif +ifeq ($(KBUILD_VERBOSE),1) + UCLIBC_MAKE_FLAGS += "V=2" +endif + define UCLIBC_KCONFIG_FIXUP_CMDS $(call KCONFIG_SET_OPT,CROSS_COMPILER_PREFIX,"$(TARGET_CROSS)",$(@D)/.config) $(call KCONFIG_ENABLE_OPT,TARGET_$(UCLIBC_TARGET_ARCH),$(@D)/.config)