| Message ID | 20250604081621.18145-1-marcus.haehnel@kernkonzept.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [uclibc-ng-devel] inet/netdb: fix getnameinfo signature | expand |
Hi Marcus, patch is pushed, thanks Waldemar Marcus Haehnel wrote, > According to POSIX the getnameinfo flags parameter is int and not > unsigned. Adapt accordingly. Glibc has also fixed this in commit > e4ecafe004b3d4270b3a9dace8f970047400ed38 in 2001. > > Signed-off-by: Marcus Haehnel <marcus.haehnel@kernkonzept.com> > --- > include/netdb.h | 2 +- > libc/inet/resolv.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/netdb.h b/include/netdb.h > index a85797956..26c999e59 100644 > --- a/include/netdb.h > +++ b/include/netdb.h > @@ -689,7 +689,7 @@ extern const char *gai_strerror (int __ecode) __THROW; > extern int getnameinfo (const struct sockaddr *__restrict __sa, > socklen_t __salen, char *__restrict __host, > socklen_t __hostlen, char *__restrict __serv, > - socklen_t __servlen, unsigned int __flags); > + socklen_t __servlen, int __flags); > libc_hidden_proto(getnameinfo) > #endif /* POSIX */ > > diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c > index 130a9a505..44685e6b8 100644 > --- a/libc/inet/resolv.c > +++ b/libc/inet/resolv.c > @@ -1892,7 +1892,7 @@ int getnameinfo(const struct sockaddr *sa, > socklen_t hostlen, > char *serv, > socklen_t servlen, > - unsigned flags) > + int flags) > { > int serrno = errno; > bool ok = 0; > -- > 2.47.1 > > _______________________________________________ > devel mailing list -- devel@uclibc-ng.org > To unsubscribe send an email to devel-leave@uclibc-ng.org >
diff --git a/include/netdb.h b/include/netdb.h index a85797956..26c999e59 100644 --- a/include/netdb.h +++ b/include/netdb.h @@ -689,7 +689,7 @@ extern const char *gai_strerror (int __ecode) __THROW; extern int getnameinfo (const struct sockaddr *__restrict __sa, socklen_t __salen, char *__restrict __host, socklen_t __hostlen, char *__restrict __serv, - socklen_t __servlen, unsigned int __flags); + socklen_t __servlen, int __flags); libc_hidden_proto(getnameinfo) #endif /* POSIX */ diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c index 130a9a505..44685e6b8 100644 --- a/libc/inet/resolv.c +++ b/libc/inet/resolv.c @@ -1892,7 +1892,7 @@ int getnameinfo(const struct sockaddr *sa, socklen_t hostlen, char *serv, socklen_t servlen, - unsigned flags) + int flags) { int serrno = errno; bool ok = 0;
According to POSIX the getnameinfo flags parameter is int and not unsigned. Adapt accordingly. Glibc has also fixed this in commit e4ecafe004b3d4270b3a9dace8f970047400ed38 in 2001. Signed-off-by: Marcus Haehnel <marcus.haehnel@kernkonzept.com> --- include/netdb.h | 2 +- libc/inet/resolv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)