| Message ID | 20250207124608.29008-1-marcus.haehnel@kernkonzept.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [uclibc-ng-devel] inet/resolv.c: set h_errnop if /etc/hosts cannot be opened | expand |
Hi Marcus, is the patch against current master? It does not apply with git am. Can you recheck? best regards Waldemar Marcus Haehnel wrote, > From: Jan Klötzke <jan.kloetzke@kernkonzept.com> > > If gethostent_r fails, the h_errnop error code should be set. > > Signed-off-by: Marcus Haehnel <marcus.haehnel@kernkonzept.com> > --- > libc/inet/resolv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c > index d7a659a8c..130a9a505 100644 > --- a/libc/inet/resolv.c > +++ b/libc/inet/resolv.c > @@ -2699,7 +2699,7 @@ int gethostent_r(struct hostent *result_buf, char *buf, size_t buflen, > hostp = __open_etc_hosts(); > if (hostp == NULL) { > *result = NULL; > - ret = TRY_AGAIN; > + *h_errnop = ret = TRY_AGAIN; > goto DONE; > } > } > -- > 2.47.1 > > _______________________________________________ > devel mailing list -- devel@uclibc-ng.org > To unsubscribe send an email to devel-leave@uclibc-ng.org
Hi Waldemar, I just checked again and this is really against the current master. Rebasing does not change the diff and there have not been any changes to this file in the last 11 months. - Marcus On Mon, 2025-02-10 at 09:42 +0100, Waldemar Brodkorb wrote: > Hi Marcus, > > is the patch against current master? > It does not apply with git am. > > Can you recheck? > > best regards > Waldemar > > Marcus Haehnel wrote, > > > From: Jan Klötzke <jan.kloetzke@kernkonzept.com> > > > > If gethostent_r fails, the h_errnop error code should be set. > > > > Signed-off-by: Marcus Haehnel <marcus.haehnel@kernkonzept.com> > > --- > > libc/inet/resolv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c > > index d7a659a8c..130a9a505 100644 > > --- a/libc/inet/resolv.c > > +++ b/libc/inet/resolv.c > > @@ -2699,7 +2699,7 @@ int gethostent_r(struct hostent *result_buf, char *buf, size_t buflen, > > hostp = __open_etc_hosts(); > > if (hostp == NULL) { > > *result = NULL; > > - ret = TRY_AGAIN; > > + *h_errnop = ret = TRY_AGAIN; > > goto DONE; > > } > > } > > -- > > 2.47.1 > > > > _______________________________________________ > > devel mailing list -- devel@uclibc-ng.org > > To unsubscribe send an email to devel-leave@uclibc-ng.org > _______________________________________________ > devel mailing list -- devel@uclibc-ng.org > To unsubscribe send an email to devel-leave@uclibc-ng.org
Hi Marcus, Marcus Hähnel wrote, I reconstructed the patch. I believe it has something todo with the german umlaut in mr. klötzke's name. Either git send-mail, my mta, your mta or my mutt is breaking something. Anyway, next time try to sent as an attachment when umlauts are involved. Committed and pushed, thanks Waldemar > Hi Waldemar, > > I just checked again and this is really against the current master. > Rebasing does not change the diff and there have not been any changes to this file in the last 11 months. > > - Marcus > > On Mon, 2025-02-10 at 09:42 +0100, Waldemar Brodkorb wrote: > > Hi Marcus, > > > > is the patch against current master? > > It does not apply with git am. > > > > Can you recheck? > > > > best regards > > Waldemar > > > > Marcus Haehnel wrote, > > > > > From: Jan Klötzke <jan.kloetzke@kernkonzept.com> > > > > > > If gethostent_r fails, the h_errnop error code should be set. > > > > > > Signed-off-by: Marcus Haehnel <marcus.haehnel@kernkonzept.com> > > > --- > > > libc/inet/resolv.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c > > > index d7a659a8c..130a9a505 100644 > > > --- a/libc/inet/resolv.c > > > +++ b/libc/inet/resolv.c > > > @@ -2699,7 +2699,7 @@ int gethostent_r(struct hostent *result_buf, char *buf, size_t buflen, > > > hostp = __open_etc_hosts(); > > > if (hostp == NULL) { > > > *result = NULL; > > > - ret = TRY_AGAIN; > > > + *h_errnop = ret = TRY_AGAIN; > > > goto DONE; > > > } > > > } > > > -- > > > 2.47.1 > > > > > > _______________________________________________ > > > devel mailing list -- devel@uclibc-ng.org > > > To unsubscribe send an email to devel-leave@uclibc-ng.org > > _______________________________________________ > > devel mailing list -- devel@uclibc-ng.org > > To unsubscribe send an email to devel-leave@uclibc-ng.org > > -- > +++++++++++++++++++ > > Sign up now for our webinar on February 27, 5 pm CET, and learn first-hand about the L4Re Micro Hypervisor on Arm Cortex-R > processors: https://www.kernkonzept.com/webinar > > +++++++++++++++++++ > > Kernkonzept GmbH > Sitz: Dresden > HRB 31129 > Geschäftsführer: Dr.-Ing. Michael Hohmuth > > _______________________________________________ > devel mailing list -- devel@uclibc-ng.org > To unsubscribe send an email to devel-leave@uclibc-ng.org
diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c index d7a659a8c..130a9a505 100644 --- a/libc/inet/resolv.c +++ b/libc/inet/resolv.c @@ -2699,7 +2699,7 @@ int gethostent_r(struct hostent *result_buf, char *buf, size_t buflen, hostp = __open_etc_hosts(); if (hostp == NULL) { *result = NULL; - ret = TRY_AGAIN; + *h_errnop = ret = TRY_AGAIN; goto DONE; } }