diff mbox series

[SRU,P,v2,3/6] UBUNTU: SAUCE: gpio: aggregator: Return an error if there are no GPIOs in gpio_aggregator_parse()

Message ID f175a5f058169845f95969612485473c0aa530fa.1744694723.git.koichiro.den@canonical.com
State New
Headers show
Series Introduce configfs-based interface for gpio-aggregator (LP: #2103496) | expand

Commit Message

Koichiro Den April 15, 2025, 6:13 a.m. UTC 
From: Dan Carpenter <dan.carpenter@linaro.org>

BugLink: https://bugs.launchpad.net/bugs/2103496

The error handling in gpio_aggregator_parse() was re-written.  It now
returns success if there are no GPIOs.  Restore the previous behavior
and return -EINVAL instead.

Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Koichiro Den <koichiro.den@canonical.com>
Link: https://lore.kernel.org/r/9dcd5fda7a3819e896d9eee4156e7c46c9a64595.1744452787.git.dan.carpenter@linaro.org
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
(cherry picked from commit db1baf69e563fc222a75c0add5c76f437c717ac0 gpio/for-next)
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
---
 drivers/gpio/gpio-aggregator.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c
index b31dfcfeb074..da6cf09cea8e 100644
--- a/drivers/gpio/gpio-aggregator.c
+++ b/drivers/gpio/gpio-aggregator.c
@@ -1115,6 +1115,7 @@  static int aggr_parse(struct gpio_aggregator *aggr)
 
 	if (!n) {
 		pr_err("No GPIOs specified\n");
+		error = -EINVAL;
 		goto err;
 	}