mbox

SRU LP 1398596 [Revert] arm64: optimized copy_to_user and copy_from_user assembly code

Message ID CAKp6GAtAbeTnvAF3u0A9zznnMRLh=hcggaA_kbh=kvCqLr45oA@mail.gmail.com
State New
Headers show

Pull-request

git://kernel.ubuntu.com/cmagina/trusty-xgene.git lp1398596

Message

Craig Magina Dec. 3, 2014, 7:33 p.m. UTC
This reverts commit d7d4ccba121e82e702e187d507bc3534e1c51c6a.

A kernel crash was root caused to the copy_to_user arm64 optimizations
and upstream has requested the patch be reverted from the Ubuntu
kernel. [1]

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1398596

[1] http://www.spinics.net/lists/arm-kernel/msg381811.html

The following changes since commit f37b1e1d9898e7c9ce80ed2a73c7beca3ca5040f:

  UBUNTU: Ubuntu-3.13.0-41.70 (2014-11-25 12:08:32 +0000)

are available in the git repository at:

  git://kernel.ubuntu.com/cmagina/trusty-xgene.git lp1398596

for you to fetch changes up to a51ae3b13b6dddc612431a912a77a6336d568039:

  Revert "UBUNTU: SAUCE: (no-up) arm64: optimized copy_to_user and
copy_from_user assembly code" (2014-12-03 14:28:26 -0500)

Thanks,

Comments

Chris J Arges Dec. 3, 2014, 7:58 p.m. UTC | #1
On Wed, Dec 03, 2014 at 02:33:41PM -0500, Craig Magina wrote:
> This reverts commit d7d4ccba121e82e702e187d507bc3534e1c51c6a.
>

As upstream is also doing this, it makes sense to do the same.

Thanks,
 
> A kernel crash was root caused to the copy_to_user arm64 optimizations
> and upstream has requested the patch be reverted from the Ubuntu
> kernel. [1]
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1398596
> 
> [1] http://www.spinics.net/lists/arm-kernel/msg381811.html
> 
> The following changes since commit f37b1e1d9898e7c9ce80ed2a73c7beca3ca5040f:
> 
>   UBUNTU: Ubuntu-3.13.0-41.70 (2014-11-25 12:08:32 +0000)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/cmagina/trusty-xgene.git lp1398596
> 
> for you to fetch changes up to a51ae3b13b6dddc612431a912a77a6336d568039:
> 
>   Revert "UBUNTU: SAUCE: (no-up) arm64: optimized copy_to_user and
> copy_from_user assembly code" (2014-12-03 14:28:26 -0500)
> 
> Thanks,
> -- 
> Craig Magina
> Hyperscale Team
> Canonical
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Stefan Bader Dec. 4, 2014, 10:30 a.m. UTC | #2
Sounds reasonable as it was identified as regression. It might be helpful to
point out that this applied to Trusty, Utopic, and potentially Vivid in the
email body or subject.
Andy Whitcroft Dec. 4, 2014, 11:47 a.m. UTC | #3
Applied to Trusty, Utopic and Vivid.

-apw