Message ID | 88D661ADF6AFBF42B2AB88D8E7682B0901FBDC04@EXMBX-SZMAIL006.tencent.com |
---|---|
State | New |
Headers | show |
Series | cgroup: remove cgroup directory leading kernel crash in kill_css | expand |
On Thu, Feb 08, 2018 at 08:08:12AM +0000, haibinzhang(张海斌) wrote: > Hi, > > We got feedback from customer that cvm(cloud virtual machine) crashed when using kubelet updating container-service in ubuntu xenial. Logs show as follow. > We find a patch (commit 33c35aa4817864e056fd772230b0c6b552e36ea2) in linux mainline, which can indeed fix this bug. But ubuntu-xenial.git has not merged it yet. > > Do you guys have a plan for merging? The commit looks reasonable, though it's only tagged for 4.5+ and xenial is only 4.4 (assuming you aren't on an hwe kernel) which likely explains why we didn't get it in xenial. In any case, for SRU you need a bug in launchpad. If you don't have a bug already please file one, then point us at your bug. Thanks, Seth
Hi Seth, Ah, that got sent to me directly for some reason: > Launchpad bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1748342 I'm happy to prepare the SRU but I was going to have a discussion on the bug about who would test the proposed kernel first. Regards, Daniel On Sat, Feb 10, 2018 at 1:22 AM, Seth Forshee <seth.forshee@canonical.com> wrote: > On Thu, Feb 08, 2018 at 08:08:12AM +0000, haibinzhang(张海斌) wrote: >> Hi, >> >> We got feedback from customer that cvm(cloud virtual machine) crashed when using kubelet updating container-service in ubuntu xenial. Logs show as follow. >> We find a patch (commit 33c35aa4817864e056fd772230b0c6b552e36ea2) in linux mainline, which can indeed fix this bug. But ubuntu-xenial.git has not merged it yet. >> >> Do you guys have a plan for merging? > > The commit looks reasonable, though it's only tagged for 4.5+ and xenial > is only 4.4 (assuming you aren't on an hwe kernel) which likely explains > why we didn't get it in xenial. In any case, for SRU you need a bug in > launchpad. If you don't have a bug already please file one, then point > us at your bug. > > Thanks, > Seth > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index c3c9a0e1b3c9..8d4e85eae42c 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -4265,6 +4265,11 @@ static void kill_css(struct cgroup_subsys_state *css) { lockdep_assert_held(&cgroup_mutex); + if (css->flags & CSS_DYING) + return; + + css->flags |= CSS_DYING; + /* * This must happen before css is disassociated with its cgroup. * See seq_css() for details.