From patchwork Sun May 30 09:53:44 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 53994 X-Patchwork-Delegate: apw@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 3A617B7D1F for ; Sun, 30 May 2010 19:53:56 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OIfDF-0007AI-GH; Sun, 30 May 2010 10:53:45 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OIfDE-0007AD-Fb for kernel-team@lists.ubuntu.com; Sun, 30 May 2010 10:53:44 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1OIfDE-0001Z1-DY for ; Sun, 30 May 2010 10:53:44 +0100 Received: from cpc2-aztw21-0-0-cust264.aztw.cable.virginmedia.com ([77.100.97.9] helo=[192.168.0.130]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1OIfDE-0002nn-7m for kernel-team@lists.ubuntu.com; Sun, 30 May 2010 10:53:44 +0100 Message-ID: <4C0235A8.40406@canonical.com> Date: Sun, 30 May 2010 10:53:44 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4 MIME-Version: 1.0 To: kernel-team Subject: [PATCH 1/1] UBUNTU: 'fdr editconfig' modification. Easily skip over unwanted menuconfigs. X-Enigmail-Version: 1.0.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com All, It is now easier to edit 'per-flavour' configuration files. The old system forced the developer to enter a menuconfig system for each flavour until eventually landing in the required one. After following this process numerous times it can easily become tedious. Now the developer is asked whether they want to enter each menuconfig in turn, rapidly speeding up the process. The following changes since commit f0819aaf4948e34a44d9d685615ddee74271cd70: Chase Douglas (1): UBUNTU: enforce CONFIG_TMPFS_POSIX_ACL=y are available in the git repository at: git://kernel.ubuntu.com/lag/ubuntu-lucid.git editconfig Lee Jones (1): UBUNTU: 'fdr editconfig' modification. Easily skip over unwanted menuconfigs. debian/scripts/misc/kernelconfig | 75 +++++++++++++++++++++----------------- 1 files changed, 42 insertions(+), 33 deletions(-) + ;; esac done @@ -87,20 +84,32 @@ for arch in $archs; do # Call oldconfig or menuconfig case "$mode" in oldconfig) - # Weed out incorrect config parameters - echo "* Run silentoldconfig on $arch/$config ..." - make O=`pwd`/build ARCH=$kernarch silentoldconfig ;; + # Weed out incorrect config parameters + echo "* Run silentoldconfig on $arch/$config ..." + make O=`pwd`/build ARCH=$kernarch silentoldconfig ;; defaultconfig) - # Weed out incorrect config parameters - echo "* Run oldconfig on $arch/$config ..." - make O=`pwd`/build ARCH=$kernarch oldconfig ;; + # Weed out incorrect config parameters + echo "* Run oldconfig on $arch/$config ..." + make O=`pwd`/build ARCH=$kernarch oldconfig ;; editconfig) - # Interactively edit config parameters - echo " * Run menuconfig on $arch/$config... Press a key." - read - make O=`pwd`/build ARCH=$kernarch menuconfig ;; + # Interactively edit config parameters + while : ; do + echo -n "Do you want to edit config: $arch/$config? [Y/n] " + read choice + + case "$choice" in + y* | Y* | "" ) + make O=`pwd`/build ARCH=$kernarch menuconfig + break ;; + n* | N* ) + break ;; + *) + echo "Entry not valid" + esac + done + ;; *) # Bad! - exit 1 ;; + exit 1 ;; esac cat build/.config > $archconfdir/$config cat build/.config > "$tmpdir/CONFIGS/$arch-$config" Kind regards, Lee diff --git a/debian/scripts/misc/kernelconfig b/debian/scripts/misc/kernelconfig index 71c0f5e..7884bdc 100755 (executable) --- a/debian/scripts/misc/kernelconfig +++ b/debian/scripts/misc/kernelconfig @@ -13,12 +13,12 @@ fi mode=${1:?"Usage: $0 [oldconfig|editconfig]"} case "$mode" in - oldconfig) ;; # All is good + oldconfig) ;; # All is good defaultconfig) ;; # All is good - editconfig) ;; # All is good - genconfig) ;; # All is good - *) echo "$0 called with invalid mode" 1>&2 - exit 1 ;; + editconfig) ;; # All is good + genconfig) ;; # All is good + *) echo "$0 called with invalid mode" 1>&2 + exit 1 ;; esac kerneldir="`pwd`" confdir="$kerneldir/${DEBIAN}/config" @@ -48,12 +48,9 @@ for arch in $archs; do lpia) kernarch="x86" ;; sparc) kernarch="sparc64" ;; armel) kernarch="arm" ;; - *) kernarch="$arch" ;; + *) kernarch="$arch" ;; esac - echo "" - echo "***************************************" - echo "* Processing $arch ($kernarch) ... " archconfdir=$confdir/$arch flavourconfigs=$(cd $archconfdir && ls config.flavour.*) @@ -64,19 +61,19 @@ for arch in $archs; do for config in $flavourconfigs; do fullconf="$tmpdir/$arch-$config-full" case $config in - *) - : >"$fullconf" - if [ -f $common_conf ]; then - cat $common_conf >> "$fullconf" - fi - if [ -f $archconfdir/config.common.$arch ]; then - cat $archconfdir/config.common.$arch >> "$fullconf" - fi - cat "$archconfdir/$config" >>"$fullconf" - if [ -f $confdir/OVERRIDES ]; then - cat $confdir/OVERRIDES >> "$fullconf" - fi - ;; + *) + : >"$fullconf" + if [ -f $common_conf ]; then + cat $common_conf >> "$fullconf" + fi + if [ -f $archconfdir/config.common.$arch ]; then + cat $archconfdir/config.common.$arch >> "$fullconf" + fi + cat "$archconfdir/$config" >>"$fullconf" + if [ -f $confdir/OVERRIDES ]; then + cat $confdir/OVERRIDES >> "$fullconf" + fi