From patchwork Thu Oct 1 14:33:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 34726 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id BBF50B7BBF for ; Fri, 2 Oct 2009 00:33:58 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.60) (envelope-from ) id 1MtMj7-0000Id-5w; Thu, 01 Oct 2009 15:33:49 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.60) (envelope-from ) id 1MtMj1-0000Fl-Nq for kernel-team@lists.ubuntu.com; Thu, 01 Oct 2009 15:33:43 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1MtMj1-0001EK-MX for ; Thu, 01 Oct 2009 15:33:43 +0100 Received: from p5b2e7e32.dip.t-dialin.net ([91.46.126.50] helo=[192.168.2.105]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MtMj1-000337-I4 for kernel-team@lists.ubuntu.com; Thu, 01 Oct 2009 15:33:43 +0100 Message-ID: <4AC4BDC8.6060900@canonical.com> Date: Thu, 01 Oct 2009 16:33:44 +0200 From: Stefan Bader User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: Ubuntu Kernel Team Subject: [Karmic] SRU: acerhdf: Limit modalias matching to supported boards X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.8 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com SRU Justification: Impact: When the acerhk module is loaded on non Aspire One systems it will issue a warning about finding a bad/unknown BIOS version. It will not load and there is no bad effect, beside users getting scared. Fix: Limit the modalias to only boardnames starting with AOA Testcase: Booting on Aspire One still loads the module, other laptops don't see the warning anymore. From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001 From: Stefan Bader Date: Mon, 28 Sep 2009 17:11:29 +0000 Subject: [PATCH] UBUNTU: SAUCE: acerhdf: Limit modalias matching to supported boards BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958 Upstream status: acked, but not accepted, yet The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T). This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA. Probably the same change should be made for the two other entries. Signed-off-by: Stefan Bader Acked-by: Borislav Petkov --- drivers/platform/x86/acerhdf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index aa298d6..763f233 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers/platform/x86/acerhdf.c @@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void) MODULE_LICENSE("GPL"); MODULE_AUTHOR("Peter Feuerer"); MODULE_DESCRIPTION("Aspire One temperature and fan driver"); -MODULE_ALIAS("dmi:*:*Acer*:*:"); +MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:"); MODULE_ALIAS("dmi:*:*Gateway*:*:"); MODULE_ALIAS("dmi:*:*Packard Bell*:*:"); -- 1.5.4.5