From patchwork Wed Aug 26 09:53:19 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 2292591 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4hVKjV1Shkz1xvQ for ; Wed, 26 Aug 2026 19:53:49 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1wzAK6-0001uN-PT; Wed, 26 Aug 2026 09:53:34 +0000 Received: from mail-pl1-f179.google.com ([209.85.214.179]) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1wzAK5-0001tq-Is for kernel-team@lists.ubuntu.com; Wed, 26 Aug 2026 09:53:33 +0000 Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ce98cb8165so7774705ad.1 for ; Wed, 26 Aug 2026 02:53:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787738012; x=1788342812; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1USBT09ESxvMV3AtzCd3zfhg62+rQydfyvo2n/gGkxo=; b=PDFx73BHmXOFl/z+JQH4Px0tz421lDrRSuJknPZOjVE0JeMDcpxDTPeeeTyUC1/u2f 2j1pDbIblqzI3Upfn3TGUDm96PikSEaBulYpmI7aIIMojJsRw1XAhPh0nMajhteXLXvg s5FZGSfu1gtsX31KDJbqiDm4aIRDEh7Ux2fXzqpHW7eH7y9lOxM5bIemNbo5K8BA+0Wo XSQIBCpGK4ewZvsGVTTuywpyjnHJ52ptgxuP4beFTaPswKAgt8Cb5zqM7kWdcVzKnPLg YiMzTY1a23YWBXUkVPnHicLuf2EFJXRK8lq8E6nI8/a0EE9guXiKPV2DZfZeVGu7Qoot Sdog== X-Gm-Message-State: AFuF++kcx1VbcDUQqUZRA9hx+OGk9odKhvG8QyD7EbfnVQ+55hWHTLyi gLTEuPaMVCPX77hL60G5Jj7K1xoqdY5oGBCdQtPCZEimr7YeJK1gOaa1chZ5A5v0 X-Gm-Gg: AR+sD10fnLKZ/+EVn6NGHMy20J40wqUwLmFuFTXCCP2lnGOlLu/WJC6WslC3Yk8CXVA ikF9hM81PnpDkUwFpIn3rH3rm4nupFuuCZffY0KF7kpQUrExmQnKah2PAiWyyC2qVs9fvV8HHfg uMIGB764oT3LUxW1BpIIt79XjIwkF6MaFzxLKR5N840bLEB4S0qWt1Z6k7XdhRw84pW5IYE23q0 K/S2w6yafqemwPtBQptgCtQrEVO3hycT77/8JvvrNNECOgIXXmyrpk888O1kqMYbiGK7/YJKmiC KTJ1qRXyKR7YFEGHskR9oEOriRaGOJZblLhDkGxPiN3PNxUgqgk0OoSJQB/LcvAUGAoxKlVALV9 kPHosEckaI0FdKLXdWU96gEJi3Nmglkfi28KsV7hwxu2/fU6kevw+lBkU2iWeAAgWOCyZTETXW1 mVQ2bblqBaxwTDWEcbesMe8T+z59J+XHNabsgHxQgxDBRXmGhQVS4UZZhNd6rIqTqngdPUTF85d rsRjb57abd3fzQ= X-Received: by 2002:a17:903:19e6:b0:2d7:179b:4dfc with SMTP id d9443c01a7336-2d7179b5316mr21452465ad.4.1787738011785; Wed, 26 Aug 2026 02:53:31 -0700 (PDT) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d704b9eca6sm5672075ad.38.2026.08.26.02.53.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 02:53:31 -0700 (PDT) To: kernel-team@lists.ubuntu.com Subject: [SRU][R][PATCH v2 2/3] platform/x86: dell-dw5826e: fix ACPI _DSM function index and bitmask usage Date: Wed, 26 Aug 2026 17:53:19 +0800 Message-ID: <20260826095320.2522946-3-acelan.kao@canonical.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260826095320.2522946-1-acelan.kao@canonical.com> References: <20260826095320.2522946-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.214.179; envelope-from=acelan@gmail.com; helo=mail-pl1-f179.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: AceLan Kao via kernel-team From: AceLan Kao Reply-To: AceLan Kao Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Surendra Singh Chouhan BugLink: https://bugs.launchpad.net/bugs/2163214 PALC_DSM_FN_TRIGGER_PLDR was defined as BIT(1) (value 2). acpi_evaluate_dsm() expects a 0-based function index integer (0, 1, 2, ...), whereas acpi_check_dsm() expects a bitmask of supported function indices (BIT(1), BIT(2), ...). Because PALC_DSM_FN_TRIGGER_PLDR was defined as BIT(1), acpi_evaluate_dsm() was evaluating Function Index 2 instead of Function Index 1, while acpi_check_dsm() was checking for Function Index 1 support. Fix this by setting PALC_DSM_FN_TRIGGER_PLDR to 1 (the function index) and passing BIT(PALC_DSM_FN_TRIGGER_PLDR) to acpi_check_dsm(). Fixes: 1ab843135a77 ("platform/x86: dell-dw5826e: Add reset driver for DW5826e") Signed-off-by: Surendra Singh Chouhan Link: https://patch.msgid.link/20260724125533.74751-1-kr494167@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen (cherry picked from commit 39490ec6063d9dc3d995b7b48fc5106cd361a547) Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/platform/x86/dell/dell-dw5826e-reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell/dell-dw5826e-reset.c b/drivers/platform/x86/dell/dell-dw5826e-reset.c index 1ca7c3421bb55..64e6e9b1d7a03 100644 --- a/drivers/platform/x86/dell/dell-dw5826e-reset.c +++ b/drivers/platform/x86/dell/dell-dw5826e-reset.c @@ -13,7 +13,7 @@ #include #include -#define PALC_DSM_FN_TRIGGER_PLDR BIT(1) +#define PALC_DSM_FN_TRIGGER_PLDR 1 static guid_t palc_dsm_guid = GUID_INIT(0x5a1a4bba, 0x8006, 0x487e, 0xbe, 0x0a, 0xac, 0xf5, 0xd8, 0xfd, 0xfe, 0x59); @@ -66,7 +66,7 @@ static int palc_probe(struct platform_device *pdev) if (!handle) return -ENODEV; - if (!acpi_check_dsm(handle, &palc_dsm_guid, 1, PALC_DSM_FN_TRIGGER_PLDR)) + if (!acpi_check_dsm(handle, &palc_dsm_guid, 1, BIT(PALC_DSM_FN_TRIGGER_PLDR))) return -ENODEV; return 0;