diff mbox series

UBUNTU: [Packaging] perf: enable debuginfod support

Message ID 20241107092659.6229-1-hector.cao@canonical.com
State New
Headers show
Series UBUNTU: [Packaging] perf: enable debuginfod support | expand

Commit Message

Hector Cao Nov. 7, 2024, 9:26 a.m. UTC
From: Hector Cao <hector.cao@canonical.com>

For symbols resolution, the perf tool can use debuginfod server as source
of debuginfo files. This support can be requested through the argument
`--debuginfod` of `perf record` command. For example, to use Ubuntu debuginfod
server:

perf record --debuginfod='https://debuginfod.ubuntu.com' -p <pid>

This support requires the perf tool to be built with libdebuginfod
library. However, this library is not a build dependency of the kernel
currently.
This patch adds libdebuginfod-dev as build dependency of the kernel
so that the debuginfod support is enabled for `perf`.

Signed-off-by: Hector Cao <hector.cao@canonical.com>
---
 debian.master/control.stub.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Agathe Porte Nov. 7, 2024, 9:34 a.m. UTC | #1
Hi,

2024-11-07 10:28 CET, Hector CAO:
> For symbols resolution, the perf tool can use debuginfod server as source
> of debuginfo files. This support can be requested through the argument
> `--debuginfod` of `perf record` command.
>
> ...

I guess this is for the unstable kernel? as I see no bug for SRU.

Thanks.

Agathe.
Hector Cao Nov. 7, 2024, 9:37 a.m. UTC | #2
Hello, yes, this patch targets the unstable kernel

Thanks

Le jeu. 7 nov. 2024, 10:34, Agathe Porte <agathe.porte@canonical.com> a
écrit :

> Hi,
>
> 2024-11-07 10:28 CET, Hector CAO:
> > For symbols resolution, the perf tool can use debuginfod server as source
> > of debuginfo files. This support can be requested through the argument
> > `--debuginfod` of `perf record` command.
> >
> > ...
>
> I guess this is for the unstable kernel? as I see no bug for SRU.
>
> Thanks.
>
> Agathe.
>
Juerg Haefliger Jan. 16, 2025, 12:24 p.m. UTC | #3
On Thu,  7 Nov 2024 10:26:59 +0100
Hector CAO <hector.cao@canonical.com> wrote:

> From: Hector Cao <hector.cao@canonical.com>
> 
> For symbols resolution, the perf tool can use debuginfod server as source
> of debuginfo files. This support can be requested through the argument
> `--debuginfod` of `perf record` command. For example, to use Ubuntu debuginfod
> server:
> 
> perf record --debuginfod='https://debuginfod.ubuntu.com' -p <pid>
> 
> This support requires the perf tool to be built with libdebuginfod
> library. However, this library is not a build dependency of the kernel
> currently.
> This patch adds libdebuginfod-dev as build dependency of the kernel
> so that the debuginfod support is enabled for `perf`.
> 
> Signed-off-by: Hector Cao <hector.cao@canonical.com>
> ---
>  debian.master/control.stub.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
> index 744dce7bb70e..5eea311e6649 100644
> --- a/debian.master/control.stub.in
> +++ b/debian.master/control.stub.in
> @@ -34,6 +34,7 @@ Build-Depends:
>   libstdc++-dev,
>   libtool <!stage1>,
>   libtraceevent-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
> + libdebuginfod-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,

Please keep the alphabetical sort order.


>   libtracefs-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
>   libudev-dev <!stage1>,
>   libunwind8-dev [amd64 arm64 armhf ppc64el] <!stage1>,


Also, the subject line needs to specify the target kernel/series. Since this
is unstable (and plucky), it should be:

[Unstable/P][Patch] UBUNTU: [Packaging] perf: enable debuginfod support

...Juerg
Timo Aaltonen Jan. 28, 2025, 6:20 a.m. UTC | #4
Hector CAO kirjoitti 7.11.2024 klo 11.26:
> From: Hector Cao <hector.cao@canonical.com>
> 
> For symbols resolution, the perf tool can use debuginfod server as source
> of debuginfo files. This support can be requested through the argument
> `--debuginfod` of `perf record` command. For example, to use Ubuntu debuginfod
> server:
> 
> perf record --debuginfod='https://debuginfod.ubuntu.com' -p <pid>
> 
> This support requires the perf tool to be built with libdebuginfod
> library. However, this library is not a build dependency of the kernel
> currently.
> This patch adds libdebuginfod-dev as build dependency of the kernel
> so that the debuginfod support is enabled for `perf`.
> 
> Signed-off-by: Hector Cao <hector.cao@canonical.com>
> ---
>   debian.master/control.stub.in | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
> index 744dce7bb70e..5eea311e6649 100644
> --- a/debian.master/control.stub.in
> +++ b/debian.master/control.stub.in
> @@ -34,6 +34,7 @@ Build-Depends:
>    libstdc++-dev,
>    libtool <!stage1>,
>    libtraceevent-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
> + libdebuginfod-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
>    libtracefs-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
>    libudev-dev <!stage1>,
>    libunwind8-dev [amd64 arm64 armhf ppc64el] <!stage1>,

applied to unstable, thanks

fixed the sort order while at it
diff mbox series

Patch

diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
index 744dce7bb70e..5eea311e6649 100644
--- a/debian.master/control.stub.in
+++ b/debian.master/control.stub.in
@@ -34,6 +34,7 @@  Build-Depends:
  libstdc++-dev,
  libtool <!stage1>,
  libtraceevent-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
+ libdebuginfod-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
  libtracefs-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
  libudev-dev <!stage1>,
  libunwind8-dev [amd64 arm64 armhf ppc64el] <!stage1>,