From patchwork Fri Apr 19 05:24:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1925392 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VLNQ13w1bz23hf for ; Fri, 19 Apr 2024 15:25:12 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rxgk6-0003K6-St; Fri, 19 Apr 2024 05:24:58 +0000 Received: from mail-oi1-f176.google.com ([209.85.167.176]) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rxgk3-0003Jf-Pb for kernel-team@lists.ubuntu.com; Fri, 19 Apr 2024 05:24:55 +0000 Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3c70b652154so1051715b6e.2 for ; Thu, 18 Apr 2024 22:24:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713504293; x=1714109093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zDwF7JupfMBnbaQUl+ewHjjsUupCDkfxrhQY070hW+o=; b=j/L5W4gujoqdDqcqLL22LcQ73ZtrRKpP3M+zHs0Z1E0FRcbIRATndAMc0eG3LZmBxq Swky/KQcG1LYYRVNu1qNHQLh6SsjgvTxolVa/HH9U4/SXUpfsba+vHngin9crK6ZDRJt 8HTOwTbj7wp8gD275s91bNFO71q5vp5DmA+edBg6LyX9ejLcY2vg68eBnQMINNOC05CH YT7ZjzFc6a7sBRyYwpLy/cMo6BUKhSCoFzJM+36iT+S3ZHs2JG9DYov6vwr0YAvUI1ud t2qCQK/WGXRglvfrYrtBZvJULMEKepbbLhIzeYZngS33dFF6+spBp/fSrkYyfJVr/3V8 6gYA== X-Gm-Message-State: AOJu0YybRUY6WLNvswIWD8PwT1szvF0jfhi2TYTDmXg47V8rtX1BomeB EJwuNzQfvNkssIu/mKKwB1RRpVDRiKZPFTCUpW2TEPHQ8i5NeC8Z+9QSFw== X-Google-Smtp-Source: AGHT+IH56FkDDxf401KtBVP0XgVFOtuhvO7rF7m/Wq7HAzFG3Neqo9hjQQJBO27iZqU0OaKnznF7Ag== X-Received: by 2002:a05:6808:2189:b0:3c7:4443:e22b with SMTP id be9-20020a056808218900b003c74443e22bmr1208644oib.37.1713504293599; Thu, 18 Apr 2024 22:24:53 -0700 (PDT) Received: from localhost.localdomain (125-229-129-140.hinet-ip.hinet.net. [125.229.129.140]) by smtp.gmail.com with ESMTPSA id v7-20020aa78087000000b006f0b820022dsm857083pff.75.2024.04.18.22.24.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 22:24:53 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 2/5][SRU][Noble/Unstable] Revert "mei: vsc: Call wake_up() in the threaded IRQ handler" Date: Fri, 19 Apr 2024 13:24:21 +0800 Message-ID: <20240419052424.278801-3-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240419052424.278801-1-vicamo.yang@canonical.com> References: <20240419052424.278801-1-vicamo.yang@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.167.176; envelope-from=vicamo@gmail.com; helo=mail-oi1-f176.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Sakari Ailus BugLink: https://bugs.launchpad.net/bugs/2061747 This reverts commit 058a38acba15fd8e7b262ec6e17c4204cb15f984. It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in an interrupt handler as the interrupt handler itself would be called in a process context if PREEMPT_RT is enabled. So revert the patch. Cc: stable@vger.kernel.org # for 6.8 Signed-off-by: Sakari Ailus Acked-by: Tomas Winkler Link: https://lore.kernel.org/r/20240403051341.3534650-1-wentong.wu@intel.com Signed-off-by: Greg Kroah-Hartman (cherry picked from commit e3dc66d998d2b0c2734db9ca1d6c94c97349529a linux-next) Signed-off-by: You-Sheng Yang --- drivers/misc/mei/vsc-tp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 682c62c635b6..03486bebae09 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -419,6 +419,8 @@ static irqreturn_t vsc_tp_isr(int irq, void *data) atomic_inc(&tp->assert_cnt); + wake_up(&tp->xfer_wait); + return IRQ_WAKE_THREAD; } @@ -426,8 +428,6 @@ static irqreturn_t vsc_tp_thread_isr(int irq, void *data) { struct vsc_tp *tp = data; - wake_up(&tp->xfer_wait); - if (tp->event_notify) tp->event_notify(tp->event_notify_context);