From patchwork Tue Mar 5 13:42:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roxana Nicolescu X-Patchwork-Id: 1908235 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TpxbH220Wz23cw for ; Wed, 6 Mar 2024 00:43:06 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rhV4C-00014d-Vf; Tue, 05 Mar 2024 13:42:49 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rhV3q-00013q-S3 for kernel-team@lists.ubuntu.com; Tue, 05 Mar 2024 13:42:31 +0000 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 8ABD23F627 for ; Tue, 5 Mar 2024 13:42:26 +0000 (UTC) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-29b4867fc07so2078753a91.2 for ; Tue, 05 Mar 2024 05:42:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709646145; x=1710250945; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iYu40kEJFCdyEPos/9MisV1AWj8gM2V3jtmqCOQIiC4=; b=IYGqe0n+RbO4WUpMwG0U9iOtDMDsYkiNjPeOClGgPoxWHAdtcm2jnJ4FaRc68+XdYE krLGL9j/j7x/5/nkpSl2PUCrZlR7bRDBX0HXBGMhe8i8/M6+9c6Z/AX04mvSzRCi1sNf gj6ajAidgL7IWF+S65nJVZL4MdPvYy/DqxlOwJjhUSlOwHJMRJpbNCdXeG2s9sEgfr87 T5CBOupl4+IE5fTK3XEw9L4XFRk5hRW4dB7Rl6qi8pp/LORPeFuH7B73QrGWzpi54eQg +PNIISC2Bxzt7YhSDdvGr+c44LE9ZRLGJBI4tnlkb9Hky82KXi8WQlfwXiXxoRQl/06W VrRA== X-Gm-Message-State: AOJu0YwuqkeBdQ/PWO7igh5gktBlD8T7ZlYJTZZC9xCJjpFVQJXVA8Fd h6ThrjODOovboyyQMuztVyA8kfYxPwz+LoOK++WwwTT0Hg/rfU8alGKRGrA/E/RAM1j0UBPaKfe Qp8XBF1FEKqmyTdJMC+4B7ndXVUwicUDCxq7AJJDyikiL1TO54Lcmgxvy4wybwpMNAwZtaklDaj o/NR+tPGGIA1FeB4A= X-Received: by 2002:a17:90b:4d8d:b0:29a:83da:efd1 with SMTP id oj13-20020a17090b4d8d00b0029a83daefd1mr9151424pjb.6.1709646144990; Tue, 05 Mar 2024 05:42:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZ7CU0wHXvWpmtKBhsClx3pIdJuEkW7GK/C53zMINg81BFvkWFEjRaakccJ7bUH5Ax6b4zPQ== X-Received: by 2002:a17:90b:4d8d:b0:29a:83da:efd1 with SMTP id oj13-20020a17090b4d8d00b0029a83daefd1mr9151415pjb.6.1709646144691; Tue, 05 Mar 2024 05:42:24 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c490]) by smtp.gmail.com with ESMTPSA id u13-20020a17090abb0d00b0029b2eccd158sm6490182pjr.48.2024.03.05.05.42.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 05:42:24 -0800 (PST) From: Roxana Nicolescu To: kernel-team@lists.ubuntu.com Subject: [SRU][F, B, X][PATCH] UBUNTU: [Packaging] Bring back install- prerequisite for checks- Date: Tue, 5 Mar 2024 14:42:15 +0100 Message-Id: <20240305134215.75386-1-roxana.nicolescu@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2055686 Previous commit "UBUNTU: [Packaging] Remove in-tree abi checks" removed module-check, abi-check, retpoline-check prerequisites for checks- target. All these were dependent on the install- rule. By removing these checks, install rule is now forgotten. This caused issues during udeps build step because modules are nowhere to be found and depmod failed: " ... depmod: ERROR: could not open directory /build/focal/debian/d-i-amd64/lib/modules/5.4.0-173-generic: No such file or directory depmod: FATAL: could not search modules: No such file or directory make[1]: *** [debian/rules.d/5-udebs.mk:16: do-binary-udebs] Error 1 make: *** [debian/rules.d/5-udebs.mk:4: binary-udebs] Error 2 " Note: This should be a temporary fix. In newer versions > focal, this is not required because install is a prerequisite for the build rule (lp#1930713). This will be considered to be backported to focal, bionic and xenial after a thorough investigation. Signed-off-by: Roxana Nicolescu Acked-by: Andy Whitcroft Acked-by: Stefan Bader --- debian/rules.d/4-checks.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules.d/4-checks.mk b/debian/rules.d/4-checks.mk index 07bba37139431..bea1060e63f23 100644 --- a/debian/rules.d/4-checks.mk +++ b/debian/rules.d/4-checks.mk @@ -1,4 +1,4 @@ -checks-%: +checks-%: install-% @echo Debug: $@ # Check the config against the known options list.