| Message ID | 20231030120904.15200-1-panov1552@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,J,L,M] UBUNTU: SAUCE: LSM: Fix typo in ima_filter_rule_match struct argument | expand |
On 30.10.23 13:09, Alexey Panov wrote: > BugLink: https://bugs.launchpad.net/bugs/2041842 > > This patch fixes typo in ima_filter_rule_match function declaration > Fixes: eb1821949348 ("UBUNTU: SAUCE: LSM: Use lsmblob in security_audit_rule_match") > Signed-off-by: Alexey Panov <panov1552@gmail.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- This is only present in Jammy. For Lunar and Mantic the code was already revised. It only affects the build if CONFIG_IMA_LSM_RULES is not enabled (not the case in any official kernel). So it is not critical but still worthwhile to fix up. -Stefan > security/integrity/ima/ima.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > index 783a3b2fc826..c1d10bbd7c8a 100644 > --- a/security/integrity/ima/ima.h > +++ b/security/integrity/ima/ima.h > @@ -437,7 +437,7 @@ static inline void ima_filter_rule_free(void *lsmrule) > { > } > > -static inline int ima_filter_rule_match(strcut lsmblob *blob, u32 field, u32 op, > +static inline int ima_filter_rule_match(struct lsmblob *blob, u32 field, u32 op, > void *lsmrule) > { > return -EINVAL;
On 30/10/2023 13:09, Alexey Panov wrote: > BugLink: https://bugs.launchpad.net/bugs/2041842 > > This patch fixes typo in ima_filter_rule_match function declaration > Fixes: eb1821949348 ("UBUNTU: SAUCE: LSM: Use lsmblob in security_audit_rule_match") > Signed-off-by: Alexey Panov <panov1552@gmail.com> > --- > security/integrity/ima/ima.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > index 783a3b2fc826..c1d10bbd7c8a 100644 > --- a/security/integrity/ima/ima.h > +++ b/security/integrity/ima/ima.h > @@ -437,7 +437,7 @@ static inline void ima_filter_rule_free(void *lsmrule) > { > } > > -static inline int ima_filter_rule_match(strcut lsmblob *blob, u32 field, u32 op, > +static inline int ima_filter_rule_match(struct lsmblob *blob, u32 field, u32 op, > void *lsmrule) > { > return -EINVAL; Same comment as Stefan. Acked-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
On 30.10.23 13:09, Alexey Panov wrote: > BugLink: https://bugs.launchpad.net/bugs/2041842 > > This patch fixes typo in ima_filter_rule_match function declaration > Fixes: eb1821949348 ("UBUNTU: SAUCE: LSM: Use lsmblob in security_audit_rule_match") > Signed-off-by: Alexey Panov <panov1552@gmail.com> > --- > security/integrity/ima/ima.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > index 783a3b2fc826..c1d10bbd7c8a 100644 > --- a/security/integrity/ima/ima.h > +++ b/security/integrity/ima/ima.h > @@ -437,7 +437,7 @@ static inline void ima_filter_rule_free(void *lsmrule) > { > } > > -static inline int ima_filter_rule_match(strcut lsmblob *blob, u32 field, u32 op, > +static inline int ima_filter_rule_match(struct lsmblob *blob, u32 field, u32 op, > void *lsmrule) > { > return -EINVAL; Applied to jammy:linux/master-next. Thanks. -Stefan
diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h index 783a3b2fc826..c1d10bbd7c8a 100644 --- a/security/integrity/ima/ima.h +++ b/security/integrity/ima/ima.h @@ -437,7 +437,7 @@ static inline void ima_filter_rule_free(void *lsmrule) { } -static inline int ima_filter_rule_match(strcut lsmblob *blob, u32 field, u32 op, +static inline int ima_filter_rule_match(struct lsmblob *blob, u32 field, u32 op, void *lsmrule) { return -EINVAL;
BugLink: https://bugs.launchpad.net/bugs/2041842 This patch fixes typo in ima_filter_rule_match function declaration Fixes: eb1821949348 ("UBUNTU: SAUCE: LSM: Use lsmblob in security_audit_rule_match") Signed-off-by: Alexey Panov <panov1552@gmail.com> --- security/integrity/ima/ima.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)