| Message ID | 20230523073149.372248-1-andrea.righi@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,J] UBUNTU: [Packaging] fix typo when calling the old config-check | expand |
On 23/05/23 09:31AM, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/2020413 > > During the backport of the new annotations model patch set we have > introduced a typo in the execution of the old config-check perl script. > > Fix the typo: @perl -> perl. > > This bug can be hit only if we are still using the old > configs+annotations model and we opt to not migrate to the new model. > > Signed-off-by: Andrea Righi <andrea.righi@canonical.com> > --- > debian/rules.d/4-checks.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/rules.d/4-checks.mk b/debian/rules.d/4-checks.mk > index 52e790d5d72f..5606745afef7 100644 > --- a/debian/rules.d/4-checks.mk > +++ b/debian/rules.d/4-checks.mk > @@ -30,7 +30,7 @@ checks-%: module-check-% module-signature-check-% abi-check-% retpoline-check-% > config-prepare-check-%: $(stampdir)/stamp-prepare-tree-% > @echo Debug: $@ > if [ -e $(commonconfdir)/config.common.ubuntu ]; then \ > - @perl -f $(DROOT)/scripts/config-check \ > + perl -f $(DROOT)/scripts/config-check \ > $(builddir)/build-$*/.config "$(arch)" "$*" "$(commonconfdir)" \ > "$(skipconfig)" "$(do_enforce_all)" \ > else \ > -- > 2.39.2 Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
On 5/23/23 1:31 AM, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/2020413 > > During the backport of the new annotations model patch set we have > introduced a typo in the execution of the old config-check perl script. > > Fix the typo: @perl -> perl. > > This bug can be hit only if we are still using the old > configs+annotations model and we opt to not migrate to the new model. > > Signed-off-by: Andrea Righi <andrea.righi@canonical.com> > --- > debian/rules.d/4-checks.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/rules.d/4-checks.mk b/debian/rules.d/4-checks.mk > index 52e790d5d72f..5606745afef7 100644 > --- a/debian/rules.d/4-checks.mk > +++ b/debian/rules.d/4-checks.mk > @@ -30,7 +30,7 @@ checks-%: module-check-% module-signature-check-% abi-check-% retpoline-check-% > config-prepare-check-%: $(stampdir)/stamp-prepare-tree-% > @echo Debug: $@ > if [ -e $(commonconfdir)/config.common.ubuntu ]; then \ > - @perl -f $(DROOT)/scripts/config-check \ > + perl -f $(DROOT)/scripts/config-check \ > $(builddir)/build-$*/.config "$(arch)" "$*" "$(commonconfdir)" \ > "$(skipconfig)" "$(do_enforce_all)" \ > else \ Acked-by: Tim Gardner <tim.gardner@canonical.com>
On 23/05/2023 09:31, Andrea Righi wrote: > BugLink: https://bugs.launchpad.net/bugs/2020413 > > During the backport of the new annotations model patch set we have > introduced a typo in the execution of the old config-check perl script. > > Fix the typo: @perl -> perl. > > This bug can be hit only if we are still using the old > configs+annotations model and we opt to not migrate to the new model. > > Signed-off-by: Andrea Righi <andrea.righi@canonical.com> > --- > debian/rules.d/4-checks.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/rules.d/4-checks.mk b/debian/rules.d/4-checks.mk > index 52e790d5d72f..5606745afef7 100644 > --- a/debian/rules.d/4-checks.mk > +++ b/debian/rules.d/4-checks.mk > @@ -30,7 +30,7 @@ checks-%: module-check-% module-signature-check-% abi-check-% retpoline-check-% > config-prepare-check-%: $(stampdir)/stamp-prepare-tree-% > @echo Debug: $@ > if [ -e $(commonconfdir)/config.common.ubuntu ]; then \ > - @perl -f $(DROOT)/scripts/config-check \ > + perl -f $(DROOT)/scripts/config-check \ > $(builddir)/build-$*/.config "$(arch)" "$*" "$(commonconfdir)" \ > "$(skipconfig)" "$(do_enforce_all)" \ > else \ > Applied to linux:master-next. Thanks!
diff --git a/debian/rules.d/4-checks.mk b/debian/rules.d/4-checks.mk index 52e790d5d72f..5606745afef7 100644 --- a/debian/rules.d/4-checks.mk +++ b/debian/rules.d/4-checks.mk @@ -30,7 +30,7 @@ checks-%: module-check-% module-signature-check-% abi-check-% retpoline-check-% config-prepare-check-%: $(stampdir)/stamp-prepare-tree-% @echo Debug: $@ if [ -e $(commonconfdir)/config.common.ubuntu ]; then \ - @perl -f $(DROOT)/scripts/config-check \ + perl -f $(DROOT)/scripts/config-check \ $(builddir)/build-$*/.config "$(arch)" "$*" "$(commonconfdir)" \ "$(skipconfig)" "$(do_enforce_all)" \ else \
BugLink: https://bugs.launchpad.net/bugs/2020413 During the backport of the new annotations model patch set we have introduced a typo in the execution of the old config-check perl script. Fix the typo: @perl -> perl. This bug can be hit only if we are still using the old configs+annotations model and we opt to not migrate to the new model. Signed-off-by: Andrea Righi <andrea.righi@canonical.com> --- debian/rules.d/4-checks.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)