diff mbox series

[lunar:linux] UBUNTU: [Config] Mark CONFIG_SCSI_VIRTIO built-in

Message ID 20230313181322.188844-1-dimitri.ledkov@canonical.com
State New
Headers show
Series [lunar:linux] UBUNTU: [Config] Mark CONFIG_SCSI_VIRTIO built-in | expand

Commit Message

Dimitri John Ledkov March 13, 2023, 6:13 p.m. UTC
This enables initrd-less boot on generic kernel, enabling any Ubuntu
installation to be lifted from any hardware and converted into a VM
which will, even with corrupted initrd and missing modules, be able to
boot by default. This is an extremly useful property to have on all
ubuntu kernels. Separately, this also removes the need for linux-kvm
kernel flavour, as all the changes it has are now incorporated into
generic flavour & cloud-images.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
---
 debian.master/config/annotations | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrea Righi March 13, 2023, 8:40 p.m. UTC | #1
On Mon, Mar 13, 2023 at 06:13:22PM +0000, Dimitri John Ledkov wrote:
> This enables initrd-less boot on generic kernel, enabling any Ubuntu
> installation to be lifted from any hardware and converted into a VM
> which will, even with corrupted initrd and missing modules, be able to
> boot by default. This is an extremly useful property to have on all
> ubuntu kernels. Separately, this also removes the need for linux-kvm
> kernel flavour, as all the changes it has are now incorporated into
> generic flavour & cloud-images.
> 
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>

I really like this change. Few comments.

Don't we have any specific tracker for this?

> ---
>  debian.master/config/annotations | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 03218fde35..02a08f4503 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -528,7 +528,7 @@ CONFIG_SCSI_IPR_DUMP                            note<'LP: #1343109'>
>  CONFIG_SCSI_IPR_TRACE                           policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y'}>
>  CONFIG_SCSI_IPR_TRACE                           note<'LP: #1343109'>
>  
> -CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm', 's390x': 'm'}>
> +CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
>  CONFIG_SCSI_VIRTIO                              note<'tech preview of new feature'>

^ Maybe it's worth updating also the comment here, something like:

CONFIG_SCSI_VIRTIO                              note<'required to provide initrd-less boot on VMs'>

>  
>  CONFIG_SECURITY_SAFESETID                       policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>

Thanks,
-Andrea
diff mbox series

Patch

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 03218fde35..02a08f4503 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -528,7 +528,7 @@  CONFIG_SCSI_IPR_DUMP                            note<'LP: #1343109'>
 CONFIG_SCSI_IPR_TRACE                           policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y'}>
 CONFIG_SCSI_IPR_TRACE                           note<'LP: #1343109'>
 
-CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm', 'riscv64': 'm', 's390x': 'm'}>
+CONFIG_SCSI_VIRTIO                              policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>
 CONFIG_SCSI_VIRTIO                              note<'tech preview of new feature'>
 
 CONFIG_SECURITY_SAFESETID                       policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'ppc64el': 'y', 'riscv64': 'y', 's390x': 'y'}>