From patchwork Wed Feb 8 07:50:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1739327 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=PFXADPE6; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PBXGy3VSBz23hX for ; Wed, 8 Feb 2023 18:50:33 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1pPfDj-0005n4-Rh; Wed, 08 Feb 2023 07:50:23 +0000 Received: from mail-pj1-f51.google.com ([209.85.216.51]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1pPfDh-0005mY-EC for kernel-team@lists.ubuntu.com; Wed, 08 Feb 2023 07:50:21 +0000 Received: by mail-pj1-f51.google.com with SMTP id on9-20020a17090b1d0900b002300a96b358so1461493pjb.1 for ; Tue, 07 Feb 2023 23:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=sATAk4Dj0OqI0DlLugIz4F93excBo+n37P58vrCnKD4=; b=PFXADPE6PT1T8hwrcX75GNl9++JVvRPfBixsIA3kzJBsTI3NGPQycXd6Q7PTAG7Ok+ j9ojK2UPUDtiMc+eTfc1maOmEgKKC8d6U37R/Ydhu4kr2kFS0I6keRHxTiG0Zd4+Lwwj +x9zOt82/P1rF6xPGPuOPZykzW07fP8QKcIhgXY+gNltZBQ+YX1RVwUfcNewioC2RDwe GlDL7ywc4Y20zoP5n5CdFoQw/nbAeBfJCu69yxJc1r5nyTyWRO5QaecufY+9PY/HndpS 5jU2vzEBj316Db0kSH2XTVA6vtYc+8OUOXbI/qiZ2sbCekKGdsTm5RFlCnuyusf9Do6q IFCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sATAk4Dj0OqI0DlLugIz4F93excBo+n37P58vrCnKD4=; b=iMNdCpX6hlJVoqngCRBOtFezCezecFuCmi1ijXMy3+I4mgBMT1+dqiyr3kgdyK/gYF CKfKn8u/lvmMXhTnYnMidsvK/y7ZRvgOCJl78/JUqlPfnD3SMdRWYWLB5cQzKOgFrLua lDf91JiZ9wOeLjDdifIgAneHop4gopOTMGYRZAWWGy2YfzzQs8QjnzLfhvWwTrLs3LRT dI10sj8Y2g+6BKEdwTsNG14E8o0mDj9wQAwy4t1Zmtc0tQrScsBZpZH03HkyyjuGTMhY HW5Ea1k+xWKKXd+LB5evECT9vndDjckq20ZMHTZvLvX3ndLAk3fW1/UghWN1afQABJA6 dkOA== X-Gm-Message-State: AO0yUKX93FoYBR5OvpYzsarXHck80ovKpjS3fqBoc/jikk+HgjOtP03q r5+GX70tmwzOL/kjmQxFOFiEpLQAZ8pcHw== X-Google-Smtp-Source: AK7set95yAFx/Yg5AURElBdBCFaPRmQoaCAFSrv9U69ATZzjZER1yNohoOGks6iw9Old5sQ1AY5y/A== X-Received: by 2002:a17:90a:195e:b0:22c:169b:ec4c with SMTP id 30-20020a17090a195e00b0022c169bec4cmr7818318pjh.26.1675842619405; Tue, 07 Feb 2023 23:50:19 -0800 (PST) Received: from localhost (118-163-61-247.hinet-ip.hinet.net. [118.163.61.247]) by smtp.gmail.com with ESMTPSA id gx20-20020a17090b125400b0022be5d70acdsm850617pjb.20.2023.02.07.23.50.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 23:50:18 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][K] PCI: vmd: Disable MSI remapping after suspend Date: Wed, 8 Feb 2023 15:50:13 +0800 Message-Id: <20230208075013.196919-3-acelan.kao@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230208075013.196919-1-acelan.kao@canonical.com> References: <20230208075013.196919-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.51; envelope-from=acelan@gmail.com; helo=mail-pj1-f51.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Nirmal Patel BugLink: https://launchpad.net/bugs/1996048 MSI remapping is disabled by VMD driver for Intel's Icelake and newer systems in order to improve performance by setting VMCONFIG_MSI_REMAP. By design VMCONFIG_MSI_REMAP register is cleared by firmware during boot. The same register gets cleared when system is put in S3 power state. VMD driver needs to set this register again in order to avoid interrupt issues with devices behind VMD if MSI remapping was disabled before. Link: https://lore.kernel.org/r/20221109142652.450998-1-nirmal.patel@linux.intel.com Fixes: ee81ee84f873 ("PCI: vmd: Disable MSI-X remapping when possible") Signed-off-by: Nirmal Patel Signed-off-by: Lorenzo Pieralisi Reviewed-by: Francisco Munoz (cherry picked from commit d899aa668498c07ff217b666ae9712990306e682) Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/pci/controller/vmd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 94a14a3d7e55..de561f170d26 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -981,6 +981,11 @@ static int vmd_resume(struct device *dev) struct vmd_dev *vmd = pci_get_drvdata(pdev); int err, i; + if (vmd->irq_domain) + vmd_set_msi_remapping(vmd, true); + else + vmd_set_msi_remapping(vmd, false); + for (i = 0; i < vmd->msix_count; i++) { err = devm_request_irq(dev, vmd->irqs[i].virq, vmd_irq, IRQF_NO_THREAD,