| Message ID | 20230207094817.48784-1-stefan.bader@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,F] UBUNTU: SAUCE: Fix ftrace/Meta-selftests bashism check | expand |
On 07-02-2023 10:48, Stefan Bader wrote: > BugLink: https://bugs.launchpad.net/bugs/2006453 > > Upstream commit a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for > test_event_enable" introduces a test which is considered a bashism and > as a result causes the Meta-selftests subtest to fail. Fix up the "==" > to be "=" in order to avoid this. > > Fixes: a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for test_event_enable" > Signed-off-by: Stefan Bader <stefan.bader@canonical.com> > --- > .../selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > index f261eeccfaf6..020fbdaa3fba 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > @@ -46,7 +46,7 @@ test_event_enabled() { > > while [ $check_times -ne 0 ]; do > e=`cat $EVENT_ENABLE` > - if [ "$e" == $val ]; then > + if [ "$e" = $val ]; then > return 0 > fi > sleep $SLEEP_TIME Nice catch. Acked-by: Roxana Nicolescu <roxana.nicolescu@canonical.com
On 2/7/23 2:48 AM, Stefan Bader wrote: > BugLink: https://bugs.launchpad.net/bugs/2006453 > > Upstream commit a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for > test_event_enable" introduces a test which is considered a bashism and > as a result causes the Meta-selftests subtest to fail. Fix up the "==" > to be "=" in order to avoid this. > > Fixes: a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for test_event_enable" > Signed-off-by: Stefan Bader <stefan.bader@canonical.com> > --- > .../selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > index f261eeccfaf6..020fbdaa3fba 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > @@ -46,7 +46,7 @@ test_event_enabled() { > > while [ $check_times -ne 0 ]; do > e=`cat $EVENT_ENABLE` > - if [ "$e" == $val ]; then > + if [ "$e" = $val ]; then > return 0 > fi > sleep $SLEEP_TIME Acked-by: Tim Gardner <tim.gardner@canonical.com>
On 07.02.23 10:48, Stefan Bader wrote: > BugLink: https://bugs.launchpad.net/bugs/2006453 > > Upstream commit a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for > test_event_enable" introduces a test which is considered a bashism and > as a result causes the Meta-selftests subtest to fail. Fix up the "==" > to be "=" in order to avoid this. > > Fixes: a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for test_event_enable" > Signed-off-by: Stefan Bader <stefan.bader@canonical.com> > --- > .../selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > index f261eeccfaf6..020fbdaa3fba 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > @@ -46,7 +46,7 @@ test_event_enabled() { > > while [ $check_times -ne 0 ]; do > e=`cat $EVENT_ENABLE` > - if [ "$e" == $val ]; then > + if [ "$e" = $val ]; then > return 0 > fi > sleep $SLEEP_TIME Applied to focal:linux/master-next. Thanks. -Stefan
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc index f261eeccfaf6..020fbdaa3fba 100644 --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc @@ -46,7 +46,7 @@ test_event_enabled() { while [ $check_times -ne 0 ]; do e=`cat $EVENT_ENABLE` - if [ "$e" == $val ]; then + if [ "$e" = $val ]; then return 0 fi sleep $SLEEP_TIME
BugLink: https://bugs.launchpad.net/bugs/2006453 Upstream commit a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for test_event_enable" introduces a test which is considered a bashism and as a result causes the Meta-selftests subtest to fail. Fix up the "==" to be "=" in order to avoid this. Fixes: a1d6cd88c897 "selftests/ftrace: event_triggers: wait longer for test_event_enable" Signed-off-by: Stefan Bader <stefan.bader@canonical.com> --- .../selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)