diff mbox series

[SRU,Unstable/L/K] Ubuntu: remove leftover reference to ubuntu/hio driver

Message ID 20221214064458.381230-1-juerg.haefliger@canonical.com
State New
Headers show
Series [SRU,Unstable/L/K] Ubuntu: remove leftover reference to ubuntu/hio driver | expand

Commit Message

Juerg Haefliger Dec. 14, 2022, 6:44 a.m. UTC 
From: Thomas Lamprecht <t.lamprecht@proxmox.com>

BugLink: https://bugs.launchpad.net/bugs/1999556

A single reference to the hio driver was forgotten when it was removed
recently. While this reference is not a problem for the build itself, it
breaks the __clean target from 'scripts/Makefile.clean' here, as make
cannot enter the "ubuntu/hio" folder for cleaning due to ENOENT.

Fixes: 4ea6dd9afa0a0d ("UBUNTU: Remove ubuntu/hio driver")
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 ubuntu/Makefile | 4 ----
 1 file changed, 4 deletions(-)

Comments

Andrea Righi Dec. 14, 2022, 6:57 a.m. UTC | #1 
On Wed, Dec 14, 2022 at 07:44:58AM +0100, Juerg Haefliger wrote:
> From: Thomas Lamprecht <t.lamprecht@proxmox.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1999556
> 
> A single reference to the hio driver was forgotten when it was removed
> recently. While this reference is not a problem for the build itself, it
> breaks the __clean target from 'scripts/Makefile.clean' here, as make
> cannot enter the "ubuntu/hio" folder for cleaning due to ENOENT.
> 
> Fixes: 4ea6dd9afa0a0d ("UBUNTU: Remove ubuntu/hio driver")
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Acked-by: Tim Gardner <tim.gardner@canonical.com>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---

Makes sense to me. However, in lunar (since it's still devel) I think we
should just drop the SAUCE patches that are adding and removing
ubuntu/hio and force push, so we don't have to carry this stuff anymore.

For now, applied to lunar/linux.

Thanks,
-Andrea

>  ubuntu/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/ubuntu/Makefile b/ubuntu/Makefile
> index 27fa95ba242a..3bfc4494c069 100644
> --- a/ubuntu/Makefile
> +++ b/ubuntu/Makefile
> @@ -15,10 +15,6 @@
>  ##
>  ##
>  ##
> -obj-$(CONFIG_HIO)             += hio/
> -##
> -##
> -##
>  obj-$(CONFIG_UBUNTU_HOST)      += ubuntu-host/
>  ##
>  ##
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Luke Nowakowski-Krijger Jan. 27, 2023, 7:39 p.m. UTC | #2 
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>

On Tue, Dec 13, 2022 at 10:45 PM Juerg Haefliger <
juerg.haefliger@canonical.com> wrote:

> From: Thomas Lamprecht <t.lamprecht@proxmox.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1999556
>
> A single reference to the hio driver was forgotten when it was removed
> recently. While this reference is not a problem for the build itself, it
> breaks the __clean target from 'scripts/Makefile.clean' here, as make
> cannot enter the "ubuntu/hio" folder for cleaning due to ENOENT.
>
> Fixes: 4ea6dd9afa0a0d ("UBUNTU: Remove ubuntu/hio driver")
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Acked-by: Tim Gardner <tim.gardner@canonical.com>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  ubuntu/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/ubuntu/Makefile b/ubuntu/Makefile
> index 27fa95ba242a..3bfc4494c069 100644
> --- a/ubuntu/Makefile
> +++ b/ubuntu/Makefile
> @@ -15,10 +15,6 @@
>  ##
>  ##
>  ##
> -obj-$(CONFIG_HIO)             += hio/
> -##
> -##
> -##
>  obj-$(CONFIG_UBUNTU_HOST)      += ubuntu-host/
>  ##
>  ##
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Luke Nowakowski-Krijger Jan. 27, 2023, 9:22 p.m. UTC | #3 
Applied to kinetic:linux master-next

Thanks,
- Luke

On Tue, Dec 13, 2022 at 10:45 PM Juerg Haefliger <
juerg.haefliger@canonical.com> wrote:

> From: Thomas Lamprecht <t.lamprecht@proxmox.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1999556
>
> A single reference to the hio driver was forgotten when it was removed
> recently. While this reference is not a problem for the build itself, it
> breaks the __clean target from 'scripts/Makefile.clean' here, as make
> cannot enter the "ubuntu/hio" folder for cleaning due to ENOENT.
>
> Fixes: 4ea6dd9afa0a0d ("UBUNTU: Remove ubuntu/hio driver")
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Acked-by: Tim Gardner <tim.gardner@canonical.com>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  ubuntu/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/ubuntu/Makefile b/ubuntu/Makefile
> index 27fa95ba242a..3bfc4494c069 100644
> --- a/ubuntu/Makefile
> +++ b/ubuntu/Makefile
> @@ -15,10 +15,6 @@
>  ##
>  ##
>  ##
> -obj-$(CONFIG_HIO)             += hio/
> -##
> -##
> -##
>  obj-$(CONFIG_UBUNTU_HOST)      += ubuntu-host/
>  ##
>  ##
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
diff mbox series

Patch

diff --git a/ubuntu/Makefile b/ubuntu/Makefile
index 27fa95ba242a..3bfc4494c069 100644
--- a/ubuntu/Makefile
+++ b/ubuntu/Makefile
@@ -15,10 +15,6 @@ 
 ##
 ##
 ##
-obj-$(CONFIG_HIO)             += hio/
-##
-##
-##
 obj-$(CONFIG_UBUNTU_HOST)      += ubuntu-host/
 ##
 ##