diff mbox series

[SRU,K/J/HWE-5.17/F/OEM-5.14/B/X/T,1/1] r8152: Rate limit overflow messages

Message ID 20221116202103.72275-2-john.cabaj@canonical.com
State New
Headers show
Series [SRU,K/J/HWE-5.17/F/OEM-5.14/B/X/T,1/1] r8152: Rate limit overflow messages | expand

Commit Message

John Cabaj Nov. 16, 2022, 8:21 p.m. UTC
From: Andrew Gaul <gaul@gaul.org>

CVE-2022-3594

My system shows almost 10 million of these messages over a 24-hour
period which pollutes my logs.

Signed-off-by: Andrew Gaul <gaul@google.com>
Link: https://lore.kernel.org/r/20221002034128.2026653-1-gaul@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit 93e2be344a7db169b7119de21ac1bf253b8c6907)
Signed-off-by: John Cabaj <john.cabaj@canonical.com>
---
 drivers/net/usb/r8152.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thadeu Lima de Souza Cascardo Nov. 16, 2022, 8:26 p.m. UTC | #1
On Wed, Nov 16, 2022 at 02:21:03PM -0600, John Cabaj wrote:
> From: Andrew Gaul <gaul@gaul.org>
> 
> CVE-2022-3594
> 
> My system shows almost 10 million of these messages over a 24-hour
> period which pollutes my logs.
> 
> Signed-off-by: Andrew Gaul <gaul@google.com>
> Link: https://lore.kernel.org/r/20221002034128.2026653-1-gaul@google.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> (cherry picked from commit 93e2be344a7db169b7119de21ac1bf253b8c6907)
> Signed-off-by: John Cabaj <john.cabaj@canonical.com>


Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

> ---
>  drivers/net/usb/r8152.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 7e821bed91ce..c7169243aa6e 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -1871,7 +1871,9 @@ static void intr_callback(struct urb *urb)
>  			   "Stop submitting intr, status %d\n", status);
>  		return;
>  	case -EOVERFLOW:
> -		netif_info(tp, intr, tp->netdev, "intr status -EOVERFLOW\n");
> +		if (net_ratelimit())
> +			netif_info(tp, intr, tp->netdev,
> +				   "intr status -EOVERFLOW\n");
>  		goto resubmit;
>  	/* -EPIPE:  should clear the halt */
>  	default:
> -- 
> 2.34.1
diff mbox series

Patch

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 7e821bed91ce..c7169243aa6e 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1871,7 +1871,9 @@  static void intr_callback(struct urb *urb)
 			   "Stop submitting intr, status %d\n", status);
 		return;
 	case -EOVERFLOW:
-		netif_info(tp, intr, tp->netdev, "intr status -EOVERFLOW\n");
+		if (net_ratelimit())
+			netif_info(tp, intr, tp->netdev,
+				   "intr status -EOVERFLOW\n");
 		goto resubmit;
 	/* -EPIPE:  should clear the halt */
 	default: