From patchwork Mon Sep 19 18:07:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 1679613 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Nq7kjjfF; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MWXjF6jtdz1yq6 for ; Tue, 20 Sep 2022 04:08:17 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1oaLBi-0001Go-Ld; Mon, 19 Sep 2022 18:08:10 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1oaLBg-0001E7-Bc for kernel-team@lists.ubuntu.com; Mon, 19 Sep 2022 18:08:08 +0000 Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1D4423F471 for ; Mon, 19 Sep 2022 18:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1663610888; bh=PdclcPRNpUYSxk7VtxrF6tHNuKOhtw6caC3uI++fFsE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Nq7kjjfFagLoUjF8+Xk/97F2iVjFJXCKivBhUjFPQinhC1mZXg6WKB1itqd1dD+Ty MXeuSI7w46m8l4GfOQ7KHiLXvEabMhfDn6ya2MjPj2WCwyZIeGILBfwfM5E7uu4KHB lot87K6b4uy2V0sNnky4Q9chysOWitHZ+koN6r7R+vGpf2O6CxL7DSSWwNSaoKrfkA 1+wZUAlOgkYFqh4lCNFZyjCFFy191kElUfQZQbujEyoQPMhuq56OIBlHqjwssxaVGh I5MhTE2yyG3LkEGJjUfHAv52JVIAM8yhHQCERRDtamHsAqHHVxvb2VQZWCvIIkt5Q0 eMEa6AZz0hDrg== Received: by mail-pf1-f197.google.com with SMTP id u131-20020a627989000000b0054d3cf50780so157367pfc.22 for ; Mon, 19 Sep 2022 11:08:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=PdclcPRNpUYSxk7VtxrF6tHNuKOhtw6caC3uI++fFsE=; b=Trj2g2H4QEwxwxZDX+7aAkr0QOiBR//1NcnQSBfdDLnaGQ/wt5FX0hH0Ebwws/ql1C S6mxebl1TP7k+dkmOFTX8uGk1FWFmpkDRoF6KE+B+Iiy4NphPVKzNTlhkqzlueAFWJn2 iGXKHBDs3yaCecxTnN8nZSEvN0bcmE4JO4hxa4xJ1ay6uGeqVoaDS+CYAvh/RyNLZu4s gvI4DtipEeOYfpGUf5L1LUDy/yEo9JqkFw+TrfFhCsB7WTzWedUIB+hcnB3CJVfC3uAM EaIJQt8NtZaZHZ6vM2WCrJTKu44IvbyqGq81k6002AXCLEy2Xnj/mV8cV6Su2btvsUbp h0+A== X-Gm-Message-State: ACrzQf1rzQ+S/wTVXFY74st2noq5nIVSWmrMDv45kSPt081yfstPwt5p FlIKdjnk6qFyqZeMp+EggPs1Yf9ZOGnqW6D/6R1+Q85cru+7oj5S/2itv9tQc+p6GiSYlyuY9lA 2v9s4yYIQt6jS+XKCWrBD+yH6Op/EG3s474KAdXsOfQ== X-Received: by 2002:a05:6a00:238c:b0:544:c42d:8a67 with SMTP id f12-20020a056a00238c00b00544c42d8a67mr19539628pfc.21.1663610886295; Mon, 19 Sep 2022 11:08:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4cBuEaoZ3om9iN7Nq64S5SvTuep5+PNNWdynK6q6QHRM6YDejzy5akTIEC+jSHQEr/IvuOQg== X-Received: by 2002:a05:6a00:238c:b0:544:c42d:8a67 with SMTP id f12-20020a056a00238c00b00544c42d8a67mr19539610pfc.21.1663610885986; Mon, 19 Sep 2022 11:08:05 -0700 (PDT) Received: from localhost.localdomain ([69.163.84.166]) by smtp.gmail.com with ESMTPSA id b3-20020a655783000000b0042bd73400b6sm1498390pgr.87.2022.09.19.11.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 11:08:04 -0700 (PDT) From: Tim Gardner To: kernel-team@lists.ubuntu.com Subject: [PATCH 04/13] PCI/MSI: Make pci_msi_domain_write_msg() static Date: Mon, 19 Sep 2022 12:07:41 -0600 Message-Id: <20220919180750.5432-5-tim.gardner@canonical.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220919180750.5432-1-tim.gardner@canonical.com> References: <20220919180750.5432-1-tim.gardner@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Thomas Gleixner BugLink: https://bugs.launchpad.net/bugs/1990184 There is no point to have this function public as it is set by the PCI core anyway when a PCI/MSI irqdomain is created. Signed-off-by: Thomas Gleixner Tested-by: Juergen Gross Reviewed-by: Jason Gunthorpe Acked-by: Bjorn Helgaas # PCI Link: https://lore.kernel.org/r/20211206210224.157070464@linutronix.de (cherry picked from commit 9e8688c5f2990dadcf83728cd00a7e8497fc6aa9) Signed-off-by: Tim Gardner --- drivers/irqchip/irq-gic-v2m.c | 1 - drivers/irqchip/irq-gic-v3-its-pci-msi.c | 1 - drivers/irqchip/irq-gic-v3-mbi.c | 1 - drivers/pci/msi.c | 2 +- include/linux/msi.h | 1 - 5 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c index 9349fc68b81a..62cc78e0da78 100644 --- a/drivers/irqchip/irq-gic-v2m.c +++ b/drivers/irqchip/irq-gic-v2m.c @@ -88,7 +88,6 @@ static struct irq_chip gicv2m_msi_irq_chip = { .irq_mask = gicv2m_mask_msi_irq, .irq_unmask = gicv2m_unmask_msi_irq, .irq_eoi = irq_chip_eoi_parent, - .irq_write_msi_msg = pci_msi_domain_write_msg, }; static struct msi_domain_info gicv2m_msi_domain_info = { diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c index ad2810c017ed..93f77a8196da 100644 --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c @@ -28,7 +28,6 @@ static struct irq_chip its_msi_irq_chip = { .irq_unmask = its_unmask_msi_irq, .irq_mask = its_mask_msi_irq, .irq_eoi = irq_chip_eoi_parent, - .irq_write_msi_msg = pci_msi_domain_write_msg, }; static int its_pci_msi_vec_count(struct pci_dev *pdev, void *data) diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c index b84c9c2eccdc..a2163d32f17d 100644 --- a/drivers/irqchip/irq-gic-v3-mbi.c +++ b/drivers/irqchip/irq-gic-v3-mbi.c @@ -171,7 +171,6 @@ static struct irq_chip mbi_msi_irq_chip = { .irq_unmask = mbi_unmask_msi_irq, .irq_eoi = irq_chip_eoi_parent, .irq_compose_msi_msg = mbi_compose_msi_msg, - .irq_write_msi_msg = pci_msi_domain_write_msg, }; static struct msi_domain_info mbi_msi_domain_info = { diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 96132d68be1e..c9a7877285f5 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -1280,7 +1280,7 @@ EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdata); * @irq_data: Pointer to interrupt data of the MSI interrupt * @msg: Pointer to the message */ -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) +static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) { struct msi_desc *desc = irq_data_get_msi_desc(irq_data); diff --git a/include/linux/msi.h b/include/linux/msi.h index 5c627750f269..d7b143a79cb4 100644 --- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -455,7 +455,6 @@ void *platform_msi_get_host_data(struct irq_domain *domain); #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */ #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg); struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode, struct msi_domain_info *info, struct irq_domain *parent);