diff mbox series

[J] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

Message ID 20220217103844.21467-1-krzysztof.kozlowski@canonical.com
State New
Headers show
Series [J] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT | expand

Commit Message

Krzysztof Kozlowski Feb. 17, 2022, 10:38 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1959610

The PREEMPT_RT patchset does not use do_softirq() function thus trying
to filter for do_softirq fails for such kernel:

  echo do_softirq
  ftracetest: 81: echo: echo: I/O error

Choose some other visible function for the test.  The function does not
have to be actually executed during the test, because it is only testing
filter API interface.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
(cherry picked from commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 linux-next)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner Feb. 17, 2022, 1:06 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 2/17/22 3:38 AM, Krzysztof Kozlowski wrote:
> BugLink: https://bugs.launchpad.net/bugs/1959610
> 
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
> 
>    echo do_softirq
>    ftracetest: 81: echo: echo: I/O error
> 
> Choose some other visible function for the test.  The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> (cherry picked from commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 linux-next)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc      | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index e96e279e0533..25432b8cd5bd 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -19,7 +19,7 @@ fail() { # mesg
>   
>   FILTER=set_ftrace_filter
>   FUNC1="schedule"
> -FUNC2="do_softirq"
> +FUNC2="scheduler_tick"
>   
>   ALL_FUNCS="#### all functions enabled ####"
>
Joseph Salisbury Feb. 17, 2022, 2:09 p.m. UTC | #2
On 2/17/22 05:38, Krzysztof Kozlowski wrote:
> BugLink: https://bugs.launchpad.net/bugs/1959610
>
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
>
>    echo do_softirq
>    ftracetest: 81: echo: echo: I/O error
>
> Choose some other visible function for the test.  The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> (cherry picked from commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 linux-next)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc      | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index e96e279e0533..25432b8cd5bd 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -19,7 +19,7 @@ fail() { # mesg
>   
>   FILTER=set_ftrace_filter
>   FUNC1="schedule"
> -FUNC2="do_softirq"
> +FUNC2="scheduler_tick"
>   
>   ALL_FUNCS="#### all functions enabled ####"
>   
Acked-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Krzysztof Kozlowski Feb. 23, 2022, 8:17 a.m. UTC | #3
On 17/02/2022 11:38, Krzysztof Kozlowski wrote:
> BugLink: https://bugs.launchpad.net/bugs/1959610
> 
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
> 
>   echo do_softirq
>   ftracetest: 81: echo: echo: I/O error
> 
> Choose some other visible function for the test.  The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> (cherry picked from commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 linux-next)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied: Jammy


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
index e96e279e0533..25432b8cd5bd 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
@@ -19,7 +19,7 @@  fail() { # mesg
 
 FILTER=set_ftrace_filter
 FUNC1="schedule"
-FUNC2="do_softirq"
+FUNC2="scheduler_tick"
 
 ALL_FUNCS="#### all functions enabled ####"