From patchwork Mon Oct 4 18:16:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juerg Haefliger X-Patchwork-Id: 1536318 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=UhqLf6fL; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HNTT62fL0z9t10 for ; Tue, 5 Oct 2021 05:17:12 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mXSWK-0007Yo-K3; Mon, 04 Oct 2021 18:17:00 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mXSWG-0007Xj-60 for kernel-team@lists.ubuntu.com; Mon, 04 Oct 2021 18:16:56 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 0EADC3F32F for ; Mon, 4 Oct 2021 18:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1633371416; bh=FtdqvsfaAk2fWTQWtkW08LOzlC/62PZQVurVHvK75kg=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UhqLf6fL/rRRUctKQFaAR3dk3jbkf0yTfdioGmaHR/Q/cnGS1bCsXvh3aEh4C0Ekk 8orFPWz4wJE4sXPiOgQ1H5QOGJFlwUxvOh1EWlLOxDN91B8uY/JLJI+oubkexRdH1X jnS6zMPi+J3OlMyXUBe2po+8KWd9R7YqzCnJVGZrZJfOBUbavLP1+HTG4jytyYxd+4 ugKOHIhL3RURmaDziQh9ct0IsqM96tFxq9EEvH9gFyP/2WyrY6NUtl4zzMlscWAPj6 gtVd0id4cWinFprevwyRFghmtR42+B/sHSZ8DYZLb3TA56LZcscl+Y5EA5E8mcKcOl RgaE60rzQf64Q== Received: by mail-ed1-f69.google.com with SMTP id r11-20020aa7cfcb000000b003d4fbd652b9so18007444edy.14 for ; Mon, 04 Oct 2021 11:16:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FtdqvsfaAk2fWTQWtkW08LOzlC/62PZQVurVHvK75kg=; b=XBgl3WNU9QYAzoD3cDOWa05g27iCr5lZip/fHbhPVvPdk8FuqTP+rTPw3zIZ6ekgU1 Nlv1dZBhxFVxgPYpopsTahTTD9aVcnz4/NLZL6JksxadWWdPsWuiSYIhlNz8SEjyfKnp C/syBdT2J+rSnlhWjdFGVQCypDfIbVxAfi81hLVQAvqOcr7Aq7C/eYEQrN760DMMZ3HH m1t4IS4qGH+gseJDz/0UTWrq/oe3aOpskR5bt/cfIFnOUxJL4B/3aXsyYwEtX4Uo5/Xb G1rQODNKVp9NA0JVHOXiLdEL+R1f4qHMd/4FZ0N6abpfT7jklFzrUQ8p16vWFlMNwwna EyBQ== X-Gm-Message-State: AOAM531NwEMB2CGqMYlvFYMzPHD1tvjjpZkFozqVi9IYAOqAyEM8Jo9r 3pVsmvytctzLYyfL6YYNuKkJLJr60SECr866Yhwj2iruIlFHT8W3y3u6RbA7ZU9EBIWatxHnInk 8Cnh1YsrNjqq5alAfmPRPeyxxIUxK7+MROTrCqv0d2g== X-Received: by 2002:aa7:d802:: with SMTP id v2mr16436543edq.271.1633371415792; Mon, 04 Oct 2021 11:16:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl8jBWh1lVxuIMinJUuJq9mxeoQEcUEvGnjT0BeyeXIz/npa8GV3hWVyY8tSKdQlRQL2YlEg== X-Received: by 2002:aa7:d802:: with SMTP id v2mr16436515edq.271.1633371415584; Mon, 04 Oct 2021 11:16:55 -0700 (PDT) Received: from gollum.fritz.box ([194.191.244.86]) by smtp.gmail.com with ESMTPSA id h9sm6862428ejx.78.2021.10.04.11.16.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 11:16:55 -0700 (PDT) From: Juerg Haefliger X-Google-Original-From: Juerg Haefliger To: kernel-team@lists.ubuntu.com Subject: [SRU][H/raspi][PATCH 2/7] drm/vc4: hdmi: Remove unnecessary pm_runtime_put Date: Mon, 4 Oct 2021 20:16:48 +0200 Message-Id: <20211004181653.8298-3-juergh@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211004181653.8298-1-juergh@canonical.com> References: <20211004181653.8298-1-juergh@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Maxime Ripard BugLink: https://bugs.launchpad.net/bugs/1944397 Unlike pm_runtime_get_sync(), pm_runtime_resume_and_get() doesn't take a reference on failure, so we don't need to call pm_runtime_put() on failure. Signed-off-by: Maxime Ripard (cherry picked from commit 42111230f631c76840be67376bebcc6b06e3baca linux-rpi) Signed-off-by: Juerg Haefliger --- drivers/gpu/drm/vc4/vc4_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index ccc1ef339e4c..780d06732925 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -915,7 +915,6 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder, ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev); if (ret < 0) { DRM_ERROR("Failed to retain power domain: %d\n", ret); - pm_runtime_put(&vc4_hdmi->pdev->dev); return; }