diff mbox series

[3/4] cifs: Avoid error pointer dereference

Message ID 20210527144915.17079-4-tim.gardner@canonical.com
State New
Headers show
Series cifs: On cifs_reconnect, resolve the hostname again | expand

Commit Message

Tim Gardner May 27, 2021, 2:49 p.m. UTC 
From: Samuel Cabrero <scabrero@suse.de>

BugLink: https://bugs.launchpad.net/bugs/1929831

The patch 7d6535b72042: "cifs: Simplify reconnect code when dfs
upcall is enabled" leads to the following static checker warning:

	fs/cifs/connect.c:160 reconn_set_next_dfs_target()
	error: 'server->hostname' dereferencing possible ERR_PTR()

Avoid dereferencing the error pointer by early returning on error
condition.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
(cherry picked from commit 0bf1bafb17df03fbd0e8b9a086c39e6f24af7193)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 fs/cifs/connect.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index e096751a73873..505c88221b28f 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -459,6 +459,7 @@  static void reconn_set_next_dfs_target(struct TCP_Server_Info *server,
 		cifs_dbg(FYI,
 			 "%s: failed to extract hostname from target: %ld\n",
 			 __func__, PTR_ERR(server->hostname));
+		return;
 	}
 
 	rc = reconn_set_ipaddr_from_hostname(server);