| Message ID | 20210525155630.11122-1-michael.reed@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,Focal] Add support for E810 NIC to Ice Driver in Focal | expand |
On 25/05/2021 11:56, Michael Reed wrote: > From: Michael Reed <Michael.Reed@canonical.com> > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912511 > > The Intel Ice driver in 5.4 does not contain the PCIIDs necessary to allow the driver to see the > E810 network cards. Without this, users running Focal GA will be unable to deploy Ubuntu via > MAAS, or use these cards at all post-install when installing from an ISO. This patch is already > in the 5.7 kernel and above. Hi Michael, Thanks for your patch. Few things should be fixed: 1. This should be a cherry-pick of 195fb97766da1b41b4d49bccc37e13603bcb49cc If cherry-pick needs adjustments, then write "(backported from Xxxx)" instead of regular cherry-pick message. 2. Your Signed-off-by should be added with cherry-pick. 3. Add the BugLink to the commit message of cherry-picked patch (like you did here). 4. The patch should be sent with a cover letter - see "Patch Series" on https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat Best regards, Krzysztof
diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h index f8d5c661d0ba..55b777ec8f9f 100644 --- a/drivers/net/ethernet/intel/ice/ice_devids.h +++ b/drivers/net/ethernet/intel/ice/ice_devids.h @@ -11,5 +11,7 @@ #define ICE_DEV_ID_E810C_QSFP 0x1592 /* Intel(R) Ethernet Controller E810-C for SFP */ #define ICE_DEV_ID_E810C_SFP 0x1593 +/* Intel(R) Ethernet Controller E810-XXV for SFP */ +#define ICE_DEV_ID_E810_XXV_SFP 0x159B #endif /* _ICE_DEVIDS_H_ */ diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index d0ccb7ad447b..bfab9bc34d4b 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -3179,6 +3179,7 @@ static const struct pci_device_id ice_pci_tbl[] = { { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_BACKPLANE), 0 }, { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_QSFP), 0 }, { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_SFP), 0 }, + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_SFP), 0 }, /* required last entry */ { 0, } };
From: Michael Reed <Michael.Reed@canonical.com> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912511 The Intel Ice driver in 5.4 does not contain the PCIIDs necessary to allow the driver to see the E810 network cards. Without this, users running Focal GA will be unable to deploy Ubuntu via MAAS, or use these cards at all post-install when installing from an ISO. This patch is already in the 5.7 kernel and above. --- drivers/net/ethernet/intel/ice/ice_devids.h | 2 ++ drivers/net/ethernet/intel/ice/ice_main.c | 1 + 2 files changed, 3 insertions(+)