diff mbox series

[2/3,SRU,OEM-5.10/U] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"

Message ID 20210516181432.173039-3-chris.chiu@canonical.com
State New
Headers show
Series Fix Realtek USB hubs failure after resume in Dell WD19SC/DC/TB | expand

Commit Message

Chris Chiu May 16, 2021, 6:14 p.m. UTC
From: Chris Chiu <chris.chiu@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1928242

This reverts the upstream commit ca91fd8c7643 ("USB: Add reset-resume
quirk for WD19's Realtek Hub"). The previous patch in the series now
handles the problematic hubs by checking the port status and handling
it accordingly when PORT_SUSPEND timeout occurs. We don't need to use
reset-resume all the time.

Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
---
 drivers/usb/core/quirks.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Krzysztof Kozlowski May 17, 2021, 12:39 p.m. UTC | #1
On 16/05/2021 14:14, chris.chiu@canonical.com wrote:
> From: Chris Chiu <chris.chiu@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1928242
> 
> This reverts the upstream commit ca91fd8c7643 ("USB: Add reset-resume
> quirk for WD19's Realtek Hub"). The previous patch in the series now
> handles the problematic hubs by checking the port status and handling
> it accordingly when PORT_SUSPEND timeout occurs. We don't need to use
> reset-resume all the time.
> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> ---
>  drivers/usb/core/quirks.c | 1 -
>  1 file changed, 1 deletion(-)


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 21e7522655ac..6114cf83bb44 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -406,7 +406,6 @@  static const struct usb_device_id usb_quirk_list[] = {
 
 	/* Realtek hub in Dell WD19 (Type-C) */
 	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
-	{ USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME },
 
 	/* Generic RTL8153 based ethernet adapters */
 	{ USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },