From patchwork Thu May 6 04:04:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Ruffell X-Patchwork-Id: 1474780 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FbKk12kB6z9sV5; Thu, 6 May 2021 14:05:29 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1leVGO-0005PD-Fg; Thu, 06 May 2021 04:05:24 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1leVGD-0005FI-Nf for kernel-team@lists.ubuntu.com; Thu, 06 May 2021 04:05:13 +0000 Received: from mail-pj1-f69.google.com ([209.85.216.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1leVGC-0005RR-Px for kernel-team@lists.ubuntu.com; Thu, 06 May 2021 04:05:12 +0000 Received: by mail-pj1-f69.google.com with SMTP id u13-20020a17090a3fcdb0290155c6507e67so2213244pjm.6 for ; Wed, 05 May 2021 21:05:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yRLv2k72csbb+cxx6dFGJgBYMCF5EBDh0mBmJgmNVwI=; b=iF/bvBZEkbiLtaUDJbic6MgYI5Tg7D2tPdiL99uRmSRpWUx+r5/lELKqIxNmVPAfpA vlNQ8Vi2DMo/QRBt29tk/WDa7/aslJseLAct4Gi8ZltV5TMixh8LvUTh0isEs+oq/T/s E89E/7sY3Oi/O/VHHUtrPl2ubp4MELUAt9tN3Xf6wAaYHgty+4ktjQncwFNHJELl2pYu 4gOKeMye8Ha4TT/CEXR/96bxv2cYkeiT+U4tj6FnaOsMYQhJ627JYc26QRpAtwoQ9CSf boJsNNOdeP5fjtFczXbNSjYRCfuPBfYQZnM/RlEEzUc6r7KbQ2ZDvNWT7lgkpzSxVECS dkdg== X-Gm-Message-State: AOAM530bglNUYYnEeSTmByZTlSin53hIjFk7mXUr5/hesfzDrq60U9FT KZzLhkBCpILaqgtFAoGBkYIz7Vam7IFHxeQSk7rn8C3kSKmW3q6VFuP3fCb6qrSJ1MtdGWbEqsr We8x21TKrQMSySI9yyYli9bjlq8JAvLO/Xrt8DeFpHQ== X-Received: by 2002:aa7:82c3:0:b029:276:1d63:cd0e with SMTP id f3-20020aa782c30000b02902761d63cd0emr2336759pfn.13.1620273911536; Wed, 05 May 2021 21:05:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqhdYlyK+UBBS1XgLfQLzexFS/8mquT/Wkg8NErf8WZPZ3Wq1hJseuAF2CoaBlsi+tG3Le8g== X-Received: by 2002:aa7:82c3:0:b029:276:1d63:cd0e with SMTP id f3-20020aa782c30000b02902761d63cd0emr2336741pfn.13.1620273911295; Wed, 05 May 2021 21:05:11 -0700 (PDT) Received: from desktop.. (122-58-78-211-adsl.sparkbb.co.nz. [122.58.78.211]) by smtp.gmail.com with ESMTPSA id ge4sm675315pjb.4.2021.05.05.21.05.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 21:05:10 -0700 (PDT) From: Matthew Ruffell To: kernel-team@lists.ubuntu.com Subject: [SRU][F][G][H][PATCH 6/6] dm raid: remove unnecessary discard limits for raid0 and raid10 Date: Thu, 6 May 2021 16:04:42 +1200 Message-Id: <20210506040442.10877-12-matthew.ruffell@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210506040442.10877-1-matthew.ruffell@canonical.com> References: <20210506040442.10877-1-matthew.ruffell@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Mike Snitzer BugLink: https://bugs.launchpad.net/bugs/1896578 Commit 29efc390b946 ("md/md0: optimize raid0 discard handling") and commit d30588b2731f ("md/raid10: improve raid10 discard request") remove MD raid0's and raid10's inability to properly handle large discards. So eliminate associated constraints from dm-raid's support. Depends-on: 29efc390b946 ("md/md0: optimize raid0 discard handling") Depends-on: d30588b2731f ("md/raid10: improve raid10 discard request") Reported-by: Matthew Ruffell Signed-off-by: Mike Snitzer (cherry picked from commit ca4a4e9a55beeb138bb06e3867f5e486da896d44) Signed-off-by: Matthew Ruffell --- drivers/md/dm-raid.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index cab12b2251ba..294f34d2d61b 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3727,15 +3727,6 @@ static void raid_io_hints(struct dm_target *ti, struct queue_limits *limits) blk_limits_io_min(limits, chunk_size_bytes); blk_limits_io_opt(limits, chunk_size_bytes * mddev_data_stripes(rs)); - - /* - * RAID0 and RAID10 personalities require bio splitting, - * RAID1/4/5/6 don't and process large discard bios properly. - */ - if (rs_is_raid0(rs) || rs_is_raid10(rs)) { - limits->discard_granularity = chunk_size_bytes; - limits->max_discard_sectors = rs->md.chunk_sectors; - } } static void raid_postsuspend(struct dm_target *ti)