From patchwork Mon Apr 12 08:28:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1465056 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=hgIyf2/r; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJhhL6X7Rz9sVm; Mon, 12 Apr 2021 18:28:18 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lVrva-0008RR-OJ; Mon, 12 Apr 2021 08:28:14 +0000 Received: from mail-pg1-f176.google.com ([209.85.215.176]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVrvX-0008Pz-7C for kernel-team@lists.ubuntu.com; Mon, 12 Apr 2021 08:28:11 +0000 Received: by mail-pg1-f176.google.com with SMTP id w10so8804890pgh.5 for ; Mon, 12 Apr 2021 01:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NH+pC+zXeQs6YF8838HZfbTK/hapzdUNewCkq3Y+PzM=; b=hgIyf2/ry1WBd6aEQjQjVBqrmyQ1o55tzC5tYujAl9qLjmx9cYeVvUrevo9M8ZMTgF IabaOJW6VL4pYKYviFzPtcla2i00ka5c1bvDjqxDNnRl+UtFKCy/Ak3i3RgHSNLY4yRY PgwlwbbYaqxJNTDJ2uKZinzccBTOKyNOgwNahfQk/BtXoHJ26CwhFvZog+LOaHoND+Ip gWwIEqtv3PSAXWpRxMRCeIo//Cyrucvq5hYiZ6KfiPFWdIdm4oV5hDgwrrsEFi8IwEtX E7bLsZEz8uBWvseSYcoP/yCucdIGJDFRxzPVCtYFCIroLmkShQCD98l7Szx9x0NyWyt+ mxZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NH+pC+zXeQs6YF8838HZfbTK/hapzdUNewCkq3Y+PzM=; b=N/awxuADQCKc63TvjF1EWnF6sgCFJu1PSRu88YrfA21rI9ichsuh4bPfRkiLiSS0zk 81axbF2pHqzE56dc+C2c+1qzWOwhXrOdB5P5q7EduzbN2NubpH5kGElwTKj/4lW86J0y KMsXSfVOpM7Bckq9j83npMAyY8+h+2B4plzLTSL29ccWjmNHj84XNYyJmhSp/FHVDncf YYZY2zL6Bd03oHZlJMRzkEYkPfXDOOokKclm6TGDtrgGActLTyHRww1fJxj4VhXnBfWi KYW74x3g9X7uL+e9E7oTdpfI8d9U459zlg2GHYQWqGNcB7xUkB7+fdRD5zG+wu/3BMy2 i9HA== X-Gm-Message-State: AOAM533Gevu2FA833A3ARwIJz2qn7libfQghQ9EhmE1h61Btfd6DJWKG oaTv5OolsVV7RSc4pcSx3Uxu6sEseyw= X-Google-Smtp-Source: ABdhPJzuFizo37T7VPSN71o6NoKtFN4GSA8ZhOvlYXF/k7EyXNL2QoyFXnLejaa4403F073hU0BMJQ== X-Received: by 2002:a63:c348:: with SMTP id e8mr25583048pgd.36.1618216087995; Mon, 12 Apr 2021 01:28:07 -0700 (PDT) Received: from localhost (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id 23sm10596619pgo.53.2021.04.12.01.28.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 01:28:07 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][OEM-5.10] UBUNTU: SAUCE: drm/i915/dp add a quirk for backlight issue Date: Mon, 12 Apr 2021 16:28:02 +0800 Message-Id: <20210412082802.162849-2-acelan.kao@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412082802.162849-1-acelan.kao@canonical.com> References: <20210412082802.162849-1-acelan.kao@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.215.176; envelope-from=acelan@gmail.com; helo=mail-pg1-f176.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "Chia-Lin Kao (AceLan)" BugLink: https://bugs.launchpad.net/bugs/1923000 It looks like below commit in oem-5.10 introduces the backlight regression ade9f1d9f14ef drm/i915/dp: Program source OUI on eDP panels But it's not the culprit as mainline kernel doesn't have this issue. So, adding a quirk on this commit to make it only affect on a certain Dell platform to avoid the issue temporarily. Will figure out the problem and submit a formal fix later. Signed-off-by: Chia-Lin Kao (AceLan) --- drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index e0dbf285b7b6a..78440d4224732 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -24,7 +24,7 @@ * Keith Packard * */ - +#include #include #include #include @@ -154,6 +154,16 @@ static void vlv_steal_power_sequencer(struct drm_i915_private *dev_priv, enum pipe pipe); static void intel_dp_unset_edid(struct intel_dp *intel_dp); +static const struct dmi_system_id dpcd_backlight_quirk[] = { + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Precision 7560"), + }, + }, + {}, +}; + /* update sink rates from dpcd */ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp) { @@ -3554,7 +3564,8 @@ void intel_dp_set_power(struct intel_dp *intel_dp, u8 mode) /* Write the source OUI as early as possible */ if (intel_dp_is_edp(intel_dp)) - intel_edp_init_source_oui(intel_dp, false); + if (dmi_check_system(dpcd_backlight_quirk)) + intel_edp_init_source_oui(intel_dp, false); /* * When turning on, we need to retry for 1ms to give the sink