diff mbox series

[H/U] drm/i915/rkl: Remove require_force_probe protection

Message ID 20210412073209.1418659-1-tjaalton@ubuntu.com
State New
Headers show
Series [H/U] drm/i915/rkl: Remove require_force_probe protection | expand

Commit Message

Timo Aaltonen April 12, 2021, 7:32 a.m. UTC
From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

BugLink: https://bugs.launchpad.net/bugs/1905466

Removing force probe protection from RKL platform. Did
not observe warnings, errors, flickering or any visual
defects while doing ordinary tasks like browsing and
editing documents in a two monitor setup.

Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201130124855.319226-1-tejaskumarx.surendrakumar.upadhyay@intel.com
(cherry picked from commit e22fa6f0a9760297295c621fdcd4e29cf32fcfbd git://anongit.freedesktop.org/drm-intel drm-intel-next)
Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Paolo Pisati April 12, 2021, 9:13 a.m. UTC | #1
On Mon, Apr 12, 2021 at 10:32:09AM +0300, Timo Aaltonen wrote:
> From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1905466

Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
Guilherme Piccoli April 12, 2021, 1:38 p.m. UTC | #2
On Mon, Apr 12, 2021 at 4:32 AM Timo Aaltonen <tjaalton@ubuntu.com> wrote:
>
> From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1905466
>
> Removing force probe protection from RKL platform. Did
> not observe warnings, errors, flickering or any visual
> defects while doing ordinary tasks like browsing and
> editing documents in a two monitor setup.
>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20201130124855.319226-1-tejaskumarx.surendrakumar.upadhyay@intel.com
> (cherry picked from commit e22fa6f0a9760297295c621fdcd4e29cf32fcfbd git://anongit.freedesktop.org/drm-intel drm-intel-next)
> Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index e8fd8c24120a..1748b14fc46b 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -897,7 +897,6 @@ static const struct intel_device_info rkl_info = {
>         .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
>         .cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
>                 BIT(TRANSCODER_C),
> -       .require_force_probe = 1,
>         .display.has_hti = 1,
>         .display.has_psr_hw_tracking = 0,
>         .platform_engine_mask =

Thanks Timo, LGTM:

Acked-by: Guilherme G. Piccoli <gpiccoli@canonical.com>
Andrea Righi April 14, 2021, 8:05 a.m. UTC | #3
Applied to hirsute/5.11.

Thanks,
-Andrea

On Mon, Apr 12, 2021 at 10:32:09AM +0300, Timo Aaltonen wrote:
> From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1905466
> 
> Removing force probe protection from RKL platform. Did
> not observe warnings, errors, flickering or any visual
> defects while doing ordinary tasks like browsing and
> editing documents in a two monitor setup.
> 
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20201130124855.319226-1-tejaskumarx.surendrakumar.upadhyay@intel.com
> (cherry picked from commit e22fa6f0a9760297295c621fdcd4e29cf32fcfbd git://anongit.freedesktop.org/drm-intel drm-intel-next)
> Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index e8fd8c24120a..1748b14fc46b 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -897,7 +897,6 @@ static const struct intel_device_info rkl_info = {
>  	.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
>  	.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
>  		BIT(TRANSCODER_C),
> -	.require_force_probe = 1,
>  	.display.has_hti = 1,
>  	.display.has_psr_hw_tracking = 0,
>  	.platform_engine_mask =
> -- 
> 2.30.2
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index e8fd8c24120a..1748b14fc46b 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -897,7 +897,6 @@  static const struct intel_device_info rkl_info = {
 	.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
 	.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
 		BIT(TRANSCODER_C),
-	.require_force_probe = 1,
 	.display.has_hti = 1,
 	.display.has_psr_hw_tracking = 0,
 	.platform_engine_mask =