From patchwork Sun Apr 11 11:45:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1464789 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=DraY6PvA; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJ96j2RHcz9sWK; Sun, 11 Apr 2021 21:45:49 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lVYXC-0004G9-2A; Sun, 11 Apr 2021 11:45:46 +0000 Received: from mail-eopbgr700055.outbound.protection.outlook.com ([40.107.70.55] helo=NAM04-SN1-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVYX7-0004EJ-Sq for kernel-team@lists.ubuntu.com; Sun, 11 Apr 2021 11:45:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bw0tPaSuxCdT7uVBfXVTJZrIGGjFxTcDSrXo9ipIsa0/r2jDJjdbKpuW9Pf1YoDeQa5G/4TdLrS0fwMIoJawC8QHKUsLLw5euMyqluBAOeLqL5KLTbU9Slyyhzxu5tVFv5HBtwqHb8nRz8v9yNK2P8rL/jgz251qlfEiBzXDQ+f02QaC7KEa9wZV/lhQQ8jklZROvNTBPSZcIjnEmK61O4oUsLJuZERkXIYMjjlMwjxVd0sXv68bERo8D7Q8CUXVEH5Or+iEhDL44jVUoNe5GQGugz/77fZOSOjhlgXV5dzfXXwB4wF7DIDDgvnIyuWcwJMOlgCjsv6xURD1qMCLlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/2H8kob0/pZIN8EwkDMVPV98uq8m13Z71+MYXAeme8g=; b=F8mNwdd17H/gRlUuOT7TA5L45IvN+If7wKLQB9W/NsHO9+Zupz2YHPl1topQEoa2yQd8TSoXvbjJ/5XZqL054sqo6ZIOO8NUL4jcFzWrPqbG5jYKjDEGXBbUolWdlBYBRecyzdzflNCvzPw+qMb2qOzMSB2b4XD1NNWB+fQjd+RAilYOLVkgMV0j9Fy9tSuUYrN8JZJExI1JMJFDSo+ePlodRY+7XBb/BV8TlxllUWIknifxdtsO/AgDBqGCE5ad/BM1Dq0dtPi7ic9cm3oA8ctXO/+8VjNhqAZs+Xj5cY43eCFLEe9CfAC29e1g4CK9vsR6PU2+QVge/UD6EduGgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.32) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/2H8kob0/pZIN8EwkDMVPV98uq8m13Z71+MYXAeme8g=; b=DraY6PvAdvraXldpqpUI0DXM9Kd0UsUKpykqY1Ur4hZ8vG1zyA9ay0wH82NY3fhrDcAjmcXEeRsNpCYunzD4XVPQ20ucWFvfu7uK5Vmx6cyfN7j1O+jr+MPgDYtB91BxydDvv497BdPgkNjgk4btgQyXGJLwGxsKjiVwvrkNNErdwJfHAPpGImayr2OLxycXcC0loUf5vVo62Lvuycg5PzevH/XNE4lluKqv8eRYWcBo8Hm74jeHKobofS7PNqcLcHokqEWkOmvRpC8KdJeH8AsddPrcDUpMw1m6eGgBv7B1/xeTYVQpDsWbSRTWerSvxnrrTOV/SG3t3K7vIrfs4g== Received: from DM6PR14CA0069.namprd14.prod.outlook.com (2603:10b6:5:18f::46) by DM6PR12MB3644.namprd12.prod.outlook.com (2603:10b6:5:118::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Sun, 11 Apr 2021 11:45:38 +0000 Received: from DM6NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:5:18f:cafe::19) by DM6PR14CA0069.outlook.office365.com (2603:10b6:5:18f::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Sun, 11 Apr 2021 11:45:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.32) smtp.mailfrom=nvidia.com; canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.32 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.32; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.32) by DM6NAM11FT068.mail.protection.outlook.com (10.13.173.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4020.17 via Frontend Transport; Sun, 11 Apr 2021 11:45:38 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 11 Apr 2021 04:45:37 -0700 Received: from dev-r-vrt-138.mtr.labs.mlnx (172.20.145.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 11 Apr 2021 04:45:36 -0700 From: Roi Dayan To: Subject: [SRU][F:linux-bluefield][PATCH 2/2] netfilter: flowtable: Set offload timeout when adding flow Date: Sun, 11 Apr 2021 14:45:23 +0300 Message-ID: <20210411114523.2003441-3-roid@nvidia.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210411114523.2003441-1-roid@nvidia.com> References: <20210411114523.2003441-1-roid@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e1f8e96-c089-4da1-65a2-08d8fcdf538f X-MS-TrafficTypeDiagnostic: DM6PR12MB3644: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:949; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ILt+OjWvBRMJICEvHFL1YBajmZmisK4KYfQRtM4Xv9DVR1RNXIP5QxvIXh5NXb/x6uYiZBX5IzSuZYy9sSD1GRg6tIuxW384YSjmV2fVbomBvd+NzcJ++sfB1NE+xqhOfHZ5+Mc1yGFot2VjLznL0MUx/1+bkXRBWhOQ7EzF2/0Mw2Gdo+LpBDoYoO5UJhpLjDqZOoBLITXvPQipnFQf34svE5iruuJ/DTD1x3nuNC6k9rpoiaMSii5eNsJLuRNSp8HSR8vCqBcmieuYYmLNLw40s07CEkO9VR7VDTmdUqHv3dEFLlIXjOCthQFJUtBmQZC/IKprtA7oBpyNoeBf+1+0FgWGNqbwx44Czh2c97BMzpvAMzLklIf98pJmw2bdp6T1BcqXCmaqhQOxfy7ATUv/lO1Ib7OrfAbE7YDg9uRux1YvOhuvdaqD0t+DUwgyqCeyBf8qxcIkWDpXjJw+G16i2jOXvsge3kT4o5PFEJck0dteSKsHzN4SO1nK7+AmqQKZInu+2mWc7UtPhrjA9URZYAWXPqrLc9wRfHT5ZkO9EuDsassK+56HGHPI3SYLtrVA3oI7ylqz2YvWTAJP2RgL0lO6Tgq2Bds13IR3UqjPxMY5Ehr7klNC6/6bkCfA3s/xRU+aepZAuvc6oGLgvhJsrgVA1R+PUSAB//zB6u2l5OLTiYqGsCbrXsnCUfkpBFaGzFNSmFj/JMmUfTjVT3TZyn3jnzdwW1ZbyMZix7E= X-Forefront-Antispam-Report: CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(396003)(39860400002)(346002)(136003)(36840700001)(46966006)(70206006)(70586007)(6666004)(7636003)(356005)(316002)(82740400003)(47076005)(6916009)(4326008)(83380400001)(36756003)(86362001)(5660300002)(8936002)(336012)(966005)(426003)(2616005)(8676002)(1076003)(2906002)(478600001)(186003)(54906003)(26005)(82310400003)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2021 11:45:38.1678 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e1f8e96-c089-4da1-65a2-08d8fcdf538f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3644 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sokolovsky , Daniel Jurgens Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Roi Dayan BugLink: https://bugs.launchpad.net/bugs/1922672 On heavily loaded systems the GC can take time to go over all existing conns and reset their timeout. At that time other calls like from nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as expired. To fix this when we set the offload bit we should also reset the timeout instead of counting on GC to finish first iteration over all conns before the initial timeout. Fixes: 90964016e5d3 ("netfilter: nf_conntrack: add IPS_OFFLOAD status bit") Signed-off-by: Roi Dayan Signed-off-by: Pablo Neira Ayuso (cherry picked from commit 4203b19c27967d9eff6928f6a733f81892ffc592) Signed-off-by: Roi Dayan --- net/netfilter/nf_flow_table_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nf_flow_table_core.c b/net/netfilter/nf_flow_table_core.c index dcdc37d3a748..5144e317caab 100644 --- a/net/netfilter/nf_flow_table_core.c +++ b/net/netfilter/nf_flow_table_core.c @@ -244,6 +244,8 @@ int flow_offload_add(struct nf_flowtable *flow_table, struct flow_offload *flow) return err; } + nf_ct_offload_timeout(flow->ct); + if (nf_flowtable_hw_offload(flow_table)) { __set_bit(NF_FLOW_HW, &flow->flags); nf_flow_offload_add(flow_table, flow);