diff mbox series

[v2,1/1] UBUNTU: SAUCE: drm/dp: Another HP DreamColor panel brigntness fix

Message ID 20210112105446.1172888-2-kai.heng.feng@canonical.com
State New
Headers show
Series Use DCPD to control HP DreamColor panel | expand

Commit Message

Kai-Heng Feng Jan. 12, 2021, 10:54 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1911001

Another HP DreamColor panel, which is used by new HP ZBook Fury, needs
to use DPCD to control brightness.

Once the proper fix [1] is merged, this can be dropped.

[1] https://patchwork.freedesktop.org/series/81702/

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/gpu/drm/drm_dp_helper.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Bader Jan. 19, 2021, 9:53 a.m. UTC | #1
On 12.01.21 11:54, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1911001
> 
> Another HP DreamColor panel, which is used by new HP ZBook Fury, needs
> to use DPCD to control brightness.
> 
> Once the proper fix [1] is merged, this can be dropped.
> 
> [1] https://patchwork.freedesktop.org/series/81702/
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index c55c14453ecb..efd50e87ec99 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1881,6 +1881,7 @@ static const struct edid_quirk edid_quirk_list[] = {
>  	 * controls anyway...). Until we have a better way of detecting these,
>  	 * force DPCD backlight mode on all of them.
>  	 */
> +	{ MFG(0x06, 0xaf), PROD_ID(0x8c, 0xcd), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  	{ MFG(0x06, 0xaf), PROD_ID(0x9b, 0x32), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  	{ MFG(0x06, 0xaf), PROD_ID(0xeb, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  	{ MFG(0x30, 0xe4), PROD_ID(0x61, 0x06), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>
Paolo Pisati Jan. 19, 2021, 9:55 a.m. UTC | #2
On Tue, Jan 12, 2021 at 06:54:46PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1911001
Ian May Jan. 22, 2021, 4:42 p.m. UTC | #3
LGTM

Acked-by: Ian May <ian.may@canonical.com>

On 2021-01-12 18:54:46 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1911001
> 
> Another HP DreamColor panel, which is used by new HP ZBook Fury, needs
> to use DPCD to control brightness.
> 
> Once the proper fix [1] is merged, this can be dropped.
> 
> [1] https://patchwork.freedesktop.org/series/81702/
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index c55c14453ecb..efd50e87ec99 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1881,6 +1881,7 @@ static const struct edid_quirk edid_quirk_list[] = {
>  	 * controls anyway...). Until we have a better way of detecting these,
>  	 * force DPCD backlight mode on all of them.
>  	 */
> +	{ MFG(0x06, 0xaf), PROD_ID(0x8c, 0xcd), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  	{ MFG(0x06, 0xaf), PROD_ID(0x9b, 0x32), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  	{ MFG(0x06, 0xaf), PROD_ID(0xeb, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  	{ MFG(0x30, 0xe4), PROD_ID(0x61, 0x06), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> -- 
> 2.29.2
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index c55c14453ecb..efd50e87ec99 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1881,6 +1881,7 @@  static const struct edid_quirk edid_quirk_list[] = {
 	 * controls anyway...). Until we have a better way of detecting these,
 	 * force DPCD backlight mode on all of them.
 	 */
+	{ MFG(0x06, 0xaf), PROD_ID(0x8c, 0xcd), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
 	{ MFG(0x06, 0xaf), PROD_ID(0x9b, 0x32), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
 	{ MFG(0x06, 0xaf), PROD_ID(0xeb, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
 	{ MFG(0x30, 0xe4), PROD_ID(0x61, 0x06), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },